All of lore.kernel.org
 help / color / mirror / Atom feed
From: Jonathan Cameron <jic23@kernel.org>
To: Alexandru Ardelean <alexandru.ardelean@analog.com>
Cc: <linux-iio@vger.kernel.org>, <devicetree@vger.kernel.org>,
	<linux-kernel@vger.kernel.org>, <robh+dt@kernel.org>,
	<Michael.Hennerich@analog.com>
Subject: Re: [PATCH v3 4/4] dt-bindings: iio: ad9467: add entries for for AD9434 & AD9265 ADCs
Date: Sat, 26 Sep 2020 16:03:11 +0100	[thread overview]
Message-ID: <20200926160311.1c9a0444@archlinux> (raw)
In-Reply-To: <20200924080518.96410-5-alexandru.ardelean@analog.com>

On Thu, 24 Sep 2020 11:05:18 +0300
Alexandru Ardelean <alexandru.ardelean@analog.com> wrote:

> Add entries for the AD9434 & AD9265 high-speed ADCs which are supported by
> the 'ad9467' driver.
> Better describe the family of ADCs similar to AD9467 in the description.
> 
> Signed-off-by: Alexandru Ardelean <alexandru.ardelean@analog.com>
As this is just an ID and a bit of descriptive text, I'm not going to
waste Rob's time by expecting him to take a look!
@Rob: Of course you are welcome to take a look if you like.

I've tweaked the description a tiny bit as below.

Series applied to the togreg branch of iio.git and pushed out as testing
for all the normal reasons (autobuilders etc).

Thanks,

Jonathan

> ---
>  .../devicetree/bindings/iio/adc/adi,ad9467.yaml   | 15 ++++++++++++---
>  1 file changed, 12 insertions(+), 3 deletions(-)
> 
> diff --git a/Documentation/devicetree/bindings/iio/adc/adi,ad9467.yaml b/Documentation/devicetree/bindings/iio/adc/adi,ad9467.yaml
> index c4f57fa6aad1..579dbc63e3fe 100644
> --- a/Documentation/devicetree/bindings/iio/adc/adi,ad9467.yaml
> +++ b/Documentation/devicetree/bindings/iio/adc/adi,ad9467.yaml
> @@ -4,21 +4,30 @@
>  $id: http://devicetree.org/schemas/iio/adc/adi,ad9467.yaml#
>  $schema: http://devicetree.org/meta-schemas/core.yaml#
>  
> -title: Analog Devices AD9467 High-Speed ADC
> +title: Analog Devices AD9467 and similar High-Speed ADCs
>  
>  maintainers:
>    - Michael Hennerich <michael.hennerich@analog.com>
>    - Alexandru Ardelean <alexandru.ardelean@analog.com>
>  
>  description: |
> -  The AD9467 is a 16-bit, monolithic, IF sampling analog-to-digital
> -  converter (ADC).
> +  The AD9467 and the parts similar with it, are high-speed analog-to-digital
> +  converters (ADCs), operating in the range of 100 to 500 mega samples
> +  per second (MSPS). Depending on the part, some support higher MSPS and some
> +  lower MSPS, depending on the application each part is intended for.
The Depending.... depending is a bit awkward so I'll rephrase that as

Some parts support higher MSPS and some lower MSPS, suitable for the
intended application of each part.

>  
> +  All the parts support the register map described by Application Note AN-877
> +   https://www.analog.com/media/en/technical-documentation/application-notes/AN-877.pdf
> +
> +  https://www.analog.com/media/en/technical-documentation/data-sheets/AD9265.pdf
> +  https://www.analog.com/media/en/technical-documentation/data-sheets/AD9434.pdf
>    https://www.analog.com/media/en/technical-documentation/data-sheets/AD9467.pdf
>  
>  properties:
>    compatible:
>      enum:
> +      - adi,ad9265
> +      - adi,ad9434
>        - adi,ad9467
>  
>    reg:


      reply	other threads:[~2020-09-26 15:03 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-09-24  8:05 [PATCH v3 0/4] iio: adc: ad9467: add support for AD9434 & AD9265 Alexandru Ardelean
2020-09-24  8:05 ` [PATCH v3 1/4] iio: adc: ad9467: wrap a axi-adc chip-info into a ad9467_chip_info type Alexandru Ardelean
2020-09-24  8:05 ` [PATCH v3 2/4] iio: adc: ad9467: add support for AD9434 high-speed ADC Alexandru Ardelean
2020-09-24  8:05 ` [PATCH v3 3/4] iio: adc: ad9467: add support for AD9265 " Alexandru Ardelean
2020-09-24  8:05 ` [PATCH v3 4/4] dt-bindings: iio: ad9467: add entries for for AD9434 & AD9265 ADCs Alexandru Ardelean
2020-09-26 15:03   ` Jonathan Cameron [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200926160311.1c9a0444@archlinux \
    --to=jic23@kernel.org \
    --cc=Michael.Hennerich@analog.com \
    --cc=alexandru.ardelean@analog.com \
    --cc=devicetree@vger.kernel.org \
    --cc=linux-iio@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=robh+dt@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.