From: Joel Fernandes <joel@joelfernandes.org>
To: Neeraj Upadhyay <neeraju@codeaurora.org>
Cc: paulmck@kernel.org, josh@joshtriplett.org, rostedt@goodmis.org,
mathieu.desnoyers@efficios.com, jiangshanlai@gmail.com,
rcu@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] rcu: Clarify nocb kthreads naming in RCU_NOCB_CPU config
Date: Sun, 27 Sep 2020 20:13:42 -0400 [thread overview]
Message-ID: <20200928001342.GD500818@google.com> (raw)
In-Reply-To: <1600929250-20344-1-git-send-email-neeraju@codeaurora.org>
On Thu, Sep 24, 2020 at 12:04:10PM +0530, Neeraj Upadhyay wrote:
> Clarify the "x" in rcuox/N naming in RCU_NOCB_CPU config
> description.
>
Reviewed-by: Joel Fernandes (Google) <joel@joelfernandes.org>
thanks,
- Joel
> Signed-off-by: Neeraj Upadhyay <neeraju@codeaurora.org>
> ---
> kernel/rcu/Kconfig | 11 ++++++-----
> 1 file changed, 6 insertions(+), 5 deletions(-)
>
> diff --git a/kernel/rcu/Kconfig b/kernel/rcu/Kconfig
> index b71e21f..5b22747 100644
> --- a/kernel/rcu/Kconfig
> +++ b/kernel/rcu/Kconfig
> @@ -227,11 +227,12 @@ config RCU_NOCB_CPU
> specified at boot time by the rcu_nocbs parameter. For each
> such CPU, a kthread ("rcuox/N") will be created to invoke
> callbacks, where the "N" is the CPU being offloaded, and where
> - the "p" for RCU-preempt (PREEMPTION kernels) and "s" for RCU-sched
> - (!PREEMPTION kernels). Nothing prevents this kthread from running
> - on the specified CPUs, but (1) the kthreads may be preempted
> - between each callback, and (2) affinity or cgroups can be used
> - to force the kthreads to run on whatever set of CPUs is desired.
> + the "x" is "p" for RCU-preempt (PREEMPTION kernels) and "s" for
> + RCU-sched (!PREEMPTION kernels). Nothing prevents this kthread
> + from running on the specified CPUs, but (1) the kthreads may be
> + preempted between each callback, and (2) affinity or cgroups can
> + be used to force the kthreads to run on whatever set of CPUs is
> + desired.
>
> Say Y here if you want to help to debug reduced OS jitter.
> Say N here if you are unsure.
> --
> The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum,
> a Linux Foundation Collaborative Project
>
next prev parent reply other threads:[~2020-09-28 0:13 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-09-24 6:34 [PATCH] rcu: Clarify nocb kthreads naming in RCU_NOCB_CPU config Neeraj Upadhyay
2020-09-24 22:59 ` Paul E. McKenney
2020-09-25 5:47 ` Neeraj Upadhyay
2020-09-28 0:13 ` Joel Fernandes [this message]
2020-09-28 3:41 ` Paul E. McKenney
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200928001342.GD500818@google.com \
--to=joel@joelfernandes.org \
--cc=jiangshanlai@gmail.com \
--cc=josh@joshtriplett.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mathieu.desnoyers@efficios.com \
--cc=neeraju@codeaurora.org \
--cc=paulmck@kernel.org \
--cc=rcu@vger.kernel.org \
--cc=rostedt@goodmis.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.