From mboxrd@z Thu Jan 1 00:00:00 1970 Content-Type: multipart/mixed; boundary="===============6642461160055894411==" MIME-Version: 1.0 From: kernel test robot Subject: [PATCH] coccinelle: api: fix kobj_to_dev.cocci warnings Date: Mon, 28 Sep 2020 10:40:09 +0800 Message-ID: <20200928024009.GA77354@7cfb741eb618> In-Reply-To: <202009281001.t5ySriDI%lkp@intel.com> List-Id: To: kbuild@lists.01.org --===============6642461160055894411== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable CC: kbuild-all(a)lists.01.org TO: Denis Efremov CC: Julia Lawall CC: "Michael S. Tsirkin" CC: Jason Wang CC: Paolo Bonzini CC: Stefan Hajnoczi CC: Jens Axboe CC: virtualization(a)lists.linux-foundation.org CC: linux-block(a)vger.kernel.org CC: linux-kernel(a)vger.kernel.org From: kernel test robot drivers/block/virtio_blk.c:634:60-61: WARNING opportunity for kobj_to_dev() Use kobj_to_dev() instead of container_of() Generated by: scripts/coccinelle/api/kobj_to_dev.cocci Fixes: a2fc3718bc22 ("coccinelle: api: add kobj_to_dev.cocci script") CC: Denis Efremov Signed-off-by: kernel test robot --- tree: https://git.kernel.org/pub/scm/linux/kernel/git/jlawall/linux.git f= or-5.10 head: e16a7c47d56b4eeee82be662014c145bce2380e5 commit: a2fc3718bc22e85378085568ecc5765fb28cabce [3/9] coccinelle: api: add= kobj_to_dev.cocci script :::::: branch date: 6 hours ago :::::: commit date: 5 weeks ago Please take the patch only if it's a positive warning. Thanks! virtio_blk.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) --- a/drivers/block/virtio_blk.c +++ b/drivers/block/virtio_blk.c @@ -631,7 +631,7 @@ static struct attribute *virtblk_attrs[] static umode_t virtblk_attrs_are_visible(struct kobject *kobj, struct attribute *a, int n) { - struct device *dev =3D container_of(kobj, struct device, kobj); + struct device *dev =3D kobj_to_dev(kobj); struct gendisk *disk =3D dev_to_disk(dev); struct virtio_blk *vblk =3D disk->private_data; struct virtio_device *vdev =3D vblk->vdev; --===============6642461160055894411==--