From: Sascha Hauer <s.hauer@pengutronix.de>
To: Ahmad Fatoum <a.fatoum@pengutronix.de>
Cc: barebox@lists.infradead.org
Subject: Re: [PATCH 1/2] lib: kasan: remove reference of non-existent test_kasan.o
Date: Mon, 28 Sep 2020 17:32:19 +0200 [thread overview]
Message-ID: <20200928153219.GK11648@pengutronix.de> (raw)
In-Reply-To: <510aac46-363f-a521-18a6-0b062368ef63@pengutronix.de>
On Mon, Sep 28, 2020 at 04:59:40PM +0200, Ahmad Fatoum wrote:
> On 9/28/20 4:58 PM, Sascha Hauer wrote:
> > On Mon, Sep 28, 2020 at 04:41:45PM +0200, Ahmad Fatoum wrote:
> >> We don't have anything that test_kasan.o can be generated out of,
> >> thus drop it to fix the build.
> >>
> >> It would still be nice to have this as a command, but that
> >> should be a separate patch.
> >>
> >> Signed-off-by: Ahmad Fatoum <a.fatoum@pengutronix.de>
> >> ---
> >> lib/kasan/Makefile | 2 +-
> >> 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > I prefer to add the code that I have forgotten to git add ;)
>
> Wouldn't locating it in commands/ be better?
It uses internal KASan functions. Putting it into commands would mean
that we have to include "../lib/kasan/kasan.h". That's possible of
course, but I thought it looks better that way.
Sascha
--
Pengutronix e.K. | |
Steuerwalder Str. 21 | http://www.pengutronix.de/ |
31137 Hildesheim, Germany | Phone: +49-5121-206917-0 |
Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |
_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox
next prev parent reply other threads:[~2020-09-28 15:32 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-09-28 14:41 [PATCH 1/2] lib: kasan: remove reference of non-existent test_kasan.o Ahmad Fatoum
2020-09-28 14:41 ` [PATCH 2/2] lib: kasan: migrate Kconfig option to Debugging menu Ahmad Fatoum
2020-09-29 6:37 ` Sascha Hauer
2020-09-28 14:58 ` [PATCH 1/2] lib: kasan: remove reference of non-existent test_kasan.o Sascha Hauer
2020-09-28 14:59 ` Ahmad Fatoum
2020-09-28 15:32 ` Sascha Hauer [this message]
2020-09-28 15:37 ` Ahmad Fatoum
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200928153219.GK11648@pengutronix.de \
--to=s.hauer@pengutronix.de \
--cc=a.fatoum@pengutronix.de \
--cc=barebox@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.