All of lore.kernel.org
 help / color / mirror / Atom feed
From: Denton Liu <liu.denton@gmail.com>
To: Junio C Hamano <gitster@pobox.com>
Cc: Robert Karszniewicz <avoidr@posteo.de>, git@vger.kernel.org
Subject: Re: [PATCH] git-completion.bash: stash-show: add --patch-with-stat
Date: Mon, 28 Sep 2020 23:25:55 -0700	[thread overview]
Message-ID: <20200929062555.GA45164@generichostname> (raw)
In-Reply-To: <xmqqh7rhn3nk.fsf@gitster.c.googlers.com>

Hi Junio,

On Mon, Sep 28, 2020 at 11:43:11AM -0700, Junio C Hamano wrote:
> In any case, it might make more sense to do this instead, and then
> rethink what options make sense to these subcommands of "git stash".
> I do not think patch-with-stat should be among them.

Perhaps it would make sense to add --patch and --no-patch to
$__git_diff_common_options and then use that list for `git stash show`
since it's documented that all of the diff options are valid.

Thanks,
Denton

  reply	other threads:[~2020-09-29  6:25 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-09-28 11:05 [PATCH] git-completion.bash: stash-show: add --patch-with-stat Robert Karszniewicz
2020-09-28 18:43 ` Junio C Hamano
2020-09-29  6:25   ` Denton Liu [this message]
2020-09-29 21:31   ` Robert Karszniewicz
2020-09-30 19:09     ` Junio C Hamano
2020-09-30 21:56       ` Robert Karszniewicz

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200929062555.GA45164@generichostname \
    --to=liu.denton@gmail.com \
    --cc=avoidr@posteo.de \
    --cc=git@vger.kernel.org \
    --cc=gitster@pobox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.