From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-13.5 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 35A81C4727C for ; Tue, 29 Sep 2020 11:13:56 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id E1151206A5 for ; Tue, 29 Sep 2020 11:13:55 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1601378036; bh=3tj9D3iBel13R7XRBxV6h/SiKAhmR9ZkKdrn07qj9qU=; h=From:To:Cc:Subject:Date:In-Reply-To:References:List-ID:From; b=eM4o8flAGszP6DqqBTm6WYLsfu6jy3XBZhWN0zQuKwu/yxGXP7zhk1jqxxFU9MRhC Q4Syt7tf+1lUV2iMnqGZ/dxxNeMacUtjnfGgtj4refgH6+94bVAtqPhmDwm2UzI/tB RWVOWVScB1yaanFkAGX8tWR97olsKUfBJi1GTKg0= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728464AbgI2LNy (ORCPT ); Tue, 29 Sep 2020 07:13:54 -0400 Received: from mail.kernel.org ([198.145.29.99]:56274 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1729382AbgI2LNo (ORCPT ); Tue, 29 Sep 2020 07:13:44 -0400 Received: from localhost (83-86-74-64.cable.dynamic.v4.ziggo.nl [83.86.74.64]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 486032158C; Tue, 29 Sep 2020 11:13:43 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1601378023; bh=3tj9D3iBel13R7XRBxV6h/SiKAhmR9ZkKdrn07qj9qU=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=aUOpHW/5Cz+1CvEwBoXQXpHDAEBtf3ylWAh/gWSd7FWs1W52okh2FO8P6eVDccvWK 9+lxtsaEX16rBb0zYewwTR15Ot5gjVKQxucvSVJfvRvOYIh3xbb8+JmeS9wfexOw66 CX7OB2vpDd3/XPENRphn4W88aKSCEKCARnpFtJJM= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Pan Bian , Jason Gunthorpe , Sasha Levin Subject: [PATCH 4.14 035/166] RDMA/i40iw: Fix potential use after free Date: Tue, 29 Sep 2020 12:59:07 +0200 Message-Id: <20200929105936.957107721@linuxfoundation.org> X-Mailer: git-send-email 2.28.0 In-Reply-To: <20200929105935.184737111@linuxfoundation.org> References: <20200929105935.184737111@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Pan Bian [ Upstream commit da046d5f895fca18d63b15ac8faebd5bf784e23a ] Release variable dst after logging dst->error to avoid possible use after free. Link: https://lore.kernel.org/r/1573022651-37171-1-git-send-email-bianpan2016@163.com Signed-off-by: Pan Bian Reviewed-by: Jason Gunthorpe Signed-off-by: Jason Gunthorpe Signed-off-by: Sasha Levin --- drivers/infiniband/hw/i40iw/i40iw_cm.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/infiniband/hw/i40iw/i40iw_cm.c b/drivers/infiniband/hw/i40iw/i40iw_cm.c index 880c63579ba88..adec03412506d 100644 --- a/drivers/infiniband/hw/i40iw/i40iw_cm.c +++ b/drivers/infiniband/hw/i40iw/i40iw_cm.c @@ -2052,9 +2052,9 @@ static int i40iw_addr_resolve_neigh_ipv6(struct i40iw_device *iwdev, dst = i40iw_get_dst_ipv6(&src_addr, &dst_addr); if (!dst || dst->error) { if (dst) { - dst_release(dst); i40iw_pr_err("ip6_route_output returned dst->error = %d\n", dst->error); + dst_release(dst); } return rc; } -- 2.25.1