From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-13.5 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,USER_AGENT_GIT autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id CAD0EC47423 for ; Tue, 29 Sep 2020 11:15:29 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 8FB7A221EC for ; Tue, 29 Sep 2020 11:15:29 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1601378129; bh=QIcUD7pcq/WoQm+jLDDTMgOtimxs82zZtwkuebuplto=; h=From:To:Cc:Subject:Date:In-Reply-To:References:List-ID:From; b=Dv4HSCS5hQOhJIkojBA1uf662wJtb6mwbzde39N63rUBQgPnYYME2WpIlc7MP9VSs 1PdJgkh/pRZB/Ctsu7FnCNbNfwHt+0yDbcx4vNqoqmiGkg5JtzvRXRD0xqcUwV/JzN YysVbSr8pV0pvxFPYRDw99F0gWHYL5S9hljnROO0= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729120AbgI2LP2 (ORCPT ); Tue, 29 Sep 2020 07:15:28 -0400 Received: from mail.kernel.org ([198.145.29.99]:59548 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1729511AbgI2LPP (ORCPT ); Tue, 29 Sep 2020 07:15:15 -0400 Received: from localhost (83-86-74-64.cable.dynamic.v4.ziggo.nl [83.86.74.64]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 10357208FE; Tue, 29 Sep 2020 11:15:13 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1601378114; bh=QIcUD7pcq/WoQm+jLDDTMgOtimxs82zZtwkuebuplto=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=uxxQ64bJgJ9NQxR5lJCD7TqGKGwOZqPHeUAY6at7aUxnO6yF78MGYGtxrfIeeUF45 bSgg1jpcjrMAnk9SctPKQ+Putc4MK7H7IMfcVAUNOu7n3II7oi+zUs3h+ZOvUcimIm RMmQfSZaPGwJHMkB7LjwDJaPnVgNqQrkfLKFMJu4= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Paolo Bonzini , Sasha Levin Subject: [PATCH 4.14 067/166] KVM: x86: fix incorrect comparison in trace event Date: Tue, 29 Sep 2020 12:59:39 +0200 Message-Id: <20200929105938.568850706@linuxfoundation.org> X-Mailer: git-send-email 2.28.0 In-Reply-To: <20200929105935.184737111@linuxfoundation.org> References: <20200929105935.184737111@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Paolo Bonzini [ Upstream commit 147f1a1fe5d7e6b01b8df4d0cbd6f9eaf6b6c73b ] The "u" field in the event has three states, -1/0/1. Using u8 however means that comparison with -1 will always fail, so change to signed char. Signed-off-by: Paolo Bonzini Signed-off-by: Sasha Levin --- arch/x86/kvm/mmutrace.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/arch/x86/kvm/mmutrace.h b/arch/x86/kvm/mmutrace.h index 918b0d5bf2724..1c1c2649829ba 100644 --- a/arch/x86/kvm/mmutrace.h +++ b/arch/x86/kvm/mmutrace.h @@ -339,7 +339,7 @@ TRACE_EVENT( /* These depend on page entry type, so compute them now. */ __field(bool, r) __field(bool, x) - __field(u8, u) + __field(signed char, u) ), TP_fast_assign( -- 2.25.1