From: Tom Parkin <tparkin@katalix.com>
To: David Miller <davem@davemloft.net>
Cc: netdev@vger.kernel.org, jchapman@katalix.com
Subject: Re: [PATCH net-next 1/1] l2tp: report rx cookie discards in netlink get
Date: Tue, 29 Sep 2020 13:16:25 +0100 [thread overview]
Message-ID: <20200929121625.GA4556@katalix.com> (raw)
In-Reply-To: <20200928.184625.1187203928205342651.davem@davemloft.net>
[-- Attachment #1: Type: text/plain, Size: 723 bytes --]
On Mon, Sep 28, 2020 at 18:46:25 -0700, David Miller wrote:
> From: Tom Parkin <tparkin@katalix.com>
> Date: Mon, 28 Sep 2020 13:46:34 +0100
>
> > --- a/include/uapi/linux/l2tp.h
> > +++ b/include/uapi/linux/l2tp.h
> > @@ -143,6 +143,7 @@ enum {
> > L2TP_ATTR_RX_SEQ_DISCARDS, /* u64 */
> > L2TP_ATTR_RX_OOS_PACKETS, /* u64 */
> > L2TP_ATTR_RX_ERRORS, /* u64 */
> > + L2TP_ATTR_RX_COOKIE_DISCARDS, /* u64 */
> > L2TP_ATTR_STATS_PAD,
> > __L2TP_ATTR_STATS_MAX,
> > };
>
> You can't change the value of the L2TP_ATTR_STATS_PAD attribute.
>
> Instead you must add new values strictly right before the
> __L2TP_ATTR_STATS_MAX.
Of course, my mistake :-(
I'll respin accordingly, thanks.
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
next prev parent reply other threads:[~2020-09-29 12:16 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-09-28 12:46 [PATCH net-next 1/1] l2tp: report rx cookie discards in netlink get Tom Parkin
2020-09-29 1:46 ` David Miller
2020-09-29 12:16 ` Tom Parkin [this message]
-- strict thread matches above, loose matches on Subject: below --
2020-09-29 12:35 Tom Parkin
2020-09-29 20:27 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200929121625.GA4556@katalix.com \
--to=tparkin@katalix.com \
--cc=davem@davemloft.net \
--cc=jchapman@katalix.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.