All of lore.kernel.org
 help / color / mirror / Atom feed
From: Brian Foster <bfoster@redhat.com>
To: linux-xfs@vger.kernel.org
Subject: [PATCH RFC 0/3] xfs: rework quotaoff to avoid log deadlock
Date: Tue, 29 Sep 2020 10:12:25 -0400	[thread overview]
Message-ID: <20200929141228.108688-1-bfoster@redhat.com> (raw)

Hi all,

Here's an RFC for the quotaoff rework (based on Dave's suggestion) to
incorporate a transaction subsystem quiesce to provide dquot log
ordering guarantees without creating a log deadlock vector. This is RFC
mainly due to patch 2, which was a quick hack to freeze the transaction
subsystem because I wanted to focus on the core approach/algorithm
first. If the general approach is acceptable, I'll go back and implement
something that doesn't abuse an external mechanism for transaction
freeze (perhaps just using a similar, internal percpu rwsem). Patch 1 is
a dependent bug fix to avoid logging dquots for inactive quota modes and
patch 3 reworks quotaoff as described. Thoughts, reviews, flames
appreciated.

Brian

Brian Foster (3):
  xfs: skip dquot reservations if quota is inactive
  xfs: temporary transaction subsystem freeze hack
  xfs: rework quotaoff logging to avoid log deadlock on active fs

 fs/xfs/xfs_qm_syscalls.c | 36 ++++++++++++++++--------------------
 fs/xfs/xfs_trans.c       | 16 ++++++++++++++++
 fs/xfs/xfs_trans.h       |  2 ++
 fs/xfs/xfs_trans_dquot.c | 22 +++++++++++-----------
 4 files changed, 45 insertions(+), 31 deletions(-)

-- 
2.25.4


             reply	other threads:[~2020-09-29 14:12 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-09-29 14:12 Brian Foster [this message]
2020-09-29 14:12 ` [PATCH RFC 1/3] xfs: skip dquot reservations if quota is inactive Brian Foster
2020-09-29 14:12 ` [PATCH RFC 2/3] xfs: temporary transaction subsystem freeze hack Brian Foster
2020-09-29 20:50   ` Dave Chinner
2020-09-30 13:30     ` Brian Foster
2020-09-29 14:12 ` [PATCH RFC 3/3] xfs: rework quotaoff logging to avoid log deadlock on active fs Brian Foster
2020-09-29 20:48   ` Dave Chinner
2020-09-30 13:30     ` Brian Foster
2020-09-30 16:53       ` Brian Foster

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200929141228.108688-1-bfoster@redhat.com \
    --to=bfoster@redhat.com \
    --cc=linux-xfs@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.