From: Jason Gunthorpe <jgg@nvidia.com>
To: Weihang Li <liweihang@huawei.com>
Cc: <dledford@redhat.com>, <leon@kernel.org>,
<linux-rdma@vger.kernel.org>, <linuxarm@huawei.com>
Subject: Re: [PATCH v2 for-next] RDMA/hns: Support owner mode doorbell
Date: Tue, 29 Sep 2020 13:53:56 -0300 [thread overview]
Message-ID: <20200929165356.GA757147@nvidia.com> (raw)
In-Reply-To: <1601199901-41677-1-git-send-email-liweihang@huawei.com>
On Sun, Sep 27, 2020 at 05:45:01PM +0800, Weihang Li wrote:
> @@ -517,7 +514,18 @@ static inline int set_ud_wqe(struct hns_roce_qp *qp,
>
> set_extend_sge(qp, wr, &curr_idx, valid_num_sge);
>
> + /*
> + * The pipeline can sequentially post all valid WQEs into WQ buffer,
> + * including new WQEs waiting for the doorbell to update the PI again.
> + * Therefore, the owner bit of WQE MUST be updated after all fields
> + * and extSGEs have been written into DDR instead of cache.
> + */
> + if (qp->en_flags & HNS_ROCE_QP_CAP_OWNER_DB)
> + wmb();
Should this be dma_wmb() ?
Jason
next prev parent reply other threads:[~2020-09-29 16:54 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-09-27 9:45 [PATCH v2 for-next] RDMA/hns: Support owner mode doorbell Weihang Li
2020-09-29 16:53 ` Jason Gunthorpe [this message]
2020-10-12 11:56 ` liweihang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200929165356.GA757147@nvidia.com \
--to=jgg@nvidia.com \
--cc=dledford@redhat.com \
--cc=leon@kernel.org \
--cc=linux-rdma@vger.kernel.org \
--cc=linuxarm@huawei.com \
--cc=liweihang@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.