From: Christoph Hellwig <hch@infradead.org>
To: Al Viro <viro@zeniv.linux.org.uk>
Cc: Christoph Hellwig <hch@infradead.org>,
Rich Felker <dalias@libc.org>,
linux-api@vger.kernel.org, linux-fsdevel@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 1/2] vfs: block chmod of symlinks
Date: Tue, 29 Sep 2020 18:49:42 +0100 [thread overview]
Message-ID: <20200929174942.GA1379@infradead.org> (raw)
In-Reply-To: <20200917041503.GT3421308@ZenIV.linux.org.uk>
On Thu, Sep 17, 2020 at 05:15:03AM +0100, Al Viro wrote:
> Arrgh... That'd break shmem and similar filesystems... Still, it
> feels like we should _not_ bother in cases when there's no ACL
> for that sucker; after all, if get_acl() returns NULL, we quietly
> return 0 and that's it.
>
> How about something like this instead?
Do you plan to turn this into a submission?
Rich, can you share your original reproducer? I would be really
helpful to have it wired up in xfstests as a regression tests.
next prev parent reply other threads:[~2020-09-29 17:49 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-09-16 0:22 [PATCH v2 0/2] changes for addding fchmodat2 syscall Rich Felker
2020-09-16 0:22 ` [PATCH v2 1/2] vfs: block chmod of symlinks Rich Felker
2020-09-16 6:18 ` Greg KH
2020-09-16 6:23 ` Christoph Hellwig
2020-09-16 15:36 ` Rich Felker
2020-09-16 6:25 ` Christoph Hellwig
2020-09-16 15:41 ` Rich Felker
2020-09-17 4:07 ` Al Viro
2020-09-17 4:15 ` Al Viro
2020-09-17 18:42 ` Rich Felker
2020-09-29 17:49 ` Christoph Hellwig [this message]
2020-09-16 0:23 ` [PATCH v2 2/2] vfs: add fchmodat2 syscall Rich Felker
2020-09-16 6:01 ` Aleksa Sarai
2020-09-16 6:19 ` Greg KH
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200929174942.GA1379@infradead.org \
--to=hch@infradead.org \
--cc=dalias@libc.org \
--cc=linux-api@vger.kernel.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=viro@zeniv.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.