From: Christoph Hellwig <hch@infradead.org>
To: Jason Gunthorpe <jgg@nvidia.com>
Cc: Leon Romanovsky <leon@kernel.org>,
Doug Ledford <dledford@redhat.com>,
Yishai Hadas <yishaih@nvidia.com>,
linux-rdma@vger.kernel.org, Christoph Hellwig <hch@infradead.org>
Subject: Re: [PATCH rdma-next v2 1/4] IB/core: Improve ODP to use hmm_range_fault()
Date: Tue, 29 Sep 2020 19:02:10 +0100 [thread overview]
Message-ID: <20200929180210.GA5012@infradead.org> (raw)
In-Reply-To: <20200929175946.GA767138@nvidia.com>
On Tue, Sep 29, 2020 at 02:59:46PM -0300, Jason Gunthorpe wrote:
> This leaves *dma_addr set to ib_dma_mapping_error, which means the
> next try to map it will fail the if (!dma_addr) and produce a
> corrupted dma address.
>
> *dma_addr should be set to 0 here
Maybe the code should use DMA_MAPPING_ERROR as the sentinel for a
not mapped entry?
next prev parent reply other threads:[~2020-09-29 18:02 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-09-22 8:21 [PATCH rdma-next v2 0/4] Improve ODP by using HMM API Leon Romanovsky
2020-09-22 8:21 ` [PATCH rdma-next v2 1/4] IB/core: Improve ODP to use hmm_range_fault() Leon Romanovsky
2020-09-29 17:59 ` Jason Gunthorpe
2020-09-29 18:02 ` Christoph Hellwig [this message]
2020-09-29 18:13 ` Jason Gunthorpe
2020-09-29 18:15 ` Christoph Hellwig
2020-09-29 18:27 ` Jason Gunthorpe
2020-09-29 20:20 ` Yishai Hadas
2020-09-29 19:27 ` Jason Gunthorpe
2020-09-29 20:09 ` Yishai Hadas
2020-09-29 20:13 ` Jason Gunthorpe
2020-09-29 20:30 ` Yishai Hadas
2020-09-30 0:37 ` Jason Gunthorpe
2020-09-29 21:34 ` Yishai Hadas
2020-09-30 0:35 ` Jason Gunthorpe
2020-09-30 7:32 ` Yishai Hadas
2020-09-22 8:21 ` [PATCH rdma-next v2 2/4] IB/core: Enable ODP sync without faulting Leon Romanovsky
2020-09-22 8:21 ` [PATCH rdma-next v2 3/4] RDMA/mlx5: Extend advice MR to support non faulting mode Leon Romanovsky
2020-09-22 8:21 ` [PATCH rdma-next v2 4/4] RDMA/mlx5: Sync device with CPU pages upon ODP MR registration Leon Romanovsky
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200929180210.GA5012@infradead.org \
--to=hch@infradead.org \
--cc=dledford@redhat.com \
--cc=jgg@nvidia.com \
--cc=leon@kernel.org \
--cc=linux-rdma@vger.kernel.org \
--cc=yishaih@nvidia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.