From: Ido Schimmel <idosch@idosch.org>
To: Jacob Keller <jacob.e.keller@intel.com>
Cc: Jakub Kicinski <kubakici@wp.pl>,
netdev@vger.kernel.org, snelson@pensando.io
Subject: Re: [RFC iproute2-next] devlink: display elapsed time during flash update
Date: Tue, 29 Sep 2020 21:07:22 +0300 [thread overview]
Message-ID: <20200929180722.GA1674045@shredder> (raw)
In-Reply-To: <b4f664d9-301c-1157-0049-50dbea856dda@intel.com>
On Tue, Sep 29, 2020 at 10:56:23AM -0700, Jacob Keller wrote:
>
>
> On 9/29/2020 10:18 AM, Jakub Kicinski wrote:
> > On Mon, 28 Sep 2020 16:49:45 -0700 Jacob Keller wrote:
> >> For some devices, updating the flash can take significant time during
> >> operations where no status can meaningfully be reported. This can be
> >> somewhat confusing to a user who sees devlink appear to hang on the
> >> terminal waiting for the device to update.
> >>
> >> Provide a ticking counter of the time elapsed since the previous status
> >> message in order to make it clear that the program is not simply stuck.
> >>
> >> Do not display this message unless a few seconds have passed since the
> >> last status update. Additionally, if the previous status notification
> >> included a timeout, display this as part of the message. If we do not
> >> receive an error or a new status without that time out, replace it with
> >> the text "timeout reached".
> >>
> >> Signed-off-by: Jacob Keller <jacob.e.keller@intel.com>
> >> ---
> >> Sending this as an RFC because I doubt this is the best implementation. For
> >> one, I get a weird display issue where the cursor doesn't always end up on
> >> the end of line in my shell.. The % display works properly, so I'm not sure
> >> what's wrong here.
> >>
> >> Second, even though select should be timing out every 1/10th of a second for
> >> screen updates, I don't seem to get that behavior in my test. It takes about
> >> 8 to 10 seconds for the first elapsed time message to be displayed, and it
> >> updates really slowly. Is select just not that precise? I even tried using a
> >> timeout of zero, but this means we refresh way too often and it looks bad. I
> >> am not sure what is wrong here...
> >
> > Strange. Did you strace it? Perhaps it's some form of output buffering?
> >
>
> Haven't yet, just noticed the weird output behavior and timing
> inconsistency.
Might be similar to this:
https://git.kernel.org/pub/scm/network/iproute2/iproute2.git/commit/?id=8e6bce735a132150c23503a55ea0aef55a01425f
next prev parent reply other threads:[~2020-09-29 18:07 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-09-28 23:49 [RFC iproute2-next] devlink: display elapsed time during flash update Jacob Keller
2020-09-29 17:18 ` Jakub Kicinski
2020-09-29 17:56 ` Jacob Keller
2020-09-29 18:07 ` Ido Schimmel [this message]
2020-09-29 18:45 ` Jacob Keller
2020-09-29 19:04 ` Jacob Keller
2020-09-29 18:13 ` Shannon Nelson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200929180722.GA1674045@shredder \
--to=idosch@idosch.org \
--cc=jacob.e.keller@intel.com \
--cc=kubakici@wp.pl \
--cc=netdev@vger.kernel.org \
--cc=snelson@pensando.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.