All of lore.kernel.org
 help / color / mirror / Atom feed
From: Christoph Hellwig <hch@lst.de>
To: Sagi Grimberg <sagi@grimberg.me>
Cc: Keith Busch <kbusch@kernel.org>, Christoph Hellwig <hch@lst.de>,
	linux-nvme@lists.infradead.org, Hannes Reinecke <hare@suse.de>
Subject: Re: [RFC] nvme-mpath: delete disk after last connection
Date: Tue, 29 Sep 2020 20:08:49 +0200	[thread overview]
Message-ID: <20200929180849.GB12546@lst.de> (raw)
In-Reply-To: <4af645fe-f513-22b5-2d28-3e8890cc8776@grimberg.me>

On Tue, Sep 29, 2020 at 01:28:51AM -0700, Sagi Grimberg wrote:
> Something here is not clear to me, we are not really talking about "all
> paths down" but rather "all paths lost", which should take the gendisk
> down AFAIK.
>
> Keith, shouldn't we modify the gendisk reference manipulation in
> nvme_mpath_remove_disk instead of moving it to the call sites?
>
> I'm still unsure why we need a timer for this. If a path is removed
> (e.g. disconnected, we shouldn't keep the gendisk up).

True.  And I guess the right place to deal with timers is on how long
we are going to keep retrying (or at least the underlying disks alive).

_______________________________________________
Linux-nvme mailing list
Linux-nvme@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-nvme

  reply	other threads:[~2020-09-29 18:09 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-09-25 21:38 [RFC] nvme-mpath: delete disk after last connection Keith Busch
2020-09-26 11:16 ` Hannes Reinecke
2020-09-27  6:07   ` Christoph Hellwig
2020-09-28 14:11     ` Keith Busch
2020-09-29  8:28       ` Sagi Grimberg
2020-09-29 18:08         ` Christoph Hellwig [this message]
2020-09-29 18:16           ` Sagi Grimberg
2020-09-30  5:36             ` Hannes Reinecke

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200929180849.GB12546@lst.de \
    --to=hch@lst.de \
    --cc=hare@suse.de \
    --cc=kbusch@kernel.org \
    --cc=linux-nvme@lists.infradead.org \
    --cc=sagi@grimberg.me \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.