From: Rob Herring <robh@kernel.org>
To: Markus Moll <moll.markus@arcor.de>
Cc: Pavel Machek <pavel@ucw.cz>, Dan Murphy <dmurphy@ti.com>,
linux-leds@vger.kernel.org, devicetree@vger.kernel.org
Subject: Re: [PATCH v1 2/2] dt: bindings: pca9532: add description of pwm and psc settings
Date: Tue, 29 Sep 2020 13:14:09 -0500 [thread overview]
Message-ID: <20200929181409.GA890687@bogus> (raw)
In-Reply-To: <1570334746.101942.1600803234657@mail.vodafone.de>
On Tue, Sep 22, 2020 at 09:33:54PM +0200, Markus Moll wrote:
> These properties allow users to configure the PCA9532 blink rates.
>
> Signed-off-by: Markus Moll <mmoll@de.pepperl-fuchs.com>
> ---
> .../devicetree/bindings/leds/leds-pca9532.txt | 10 ++++++++++
> 1 file changed, 10 insertions(+)
>
> diff --git a/Documentation/devicetree/bindings/leds/leds-pca9532.txt b/Documentation/devicetree/bindings/leds/leds-pca9532.txt
> index f769c52e364..3aa05eca9df 100644
> --- a/Documentation/devicetree/bindings/leds/leds-pca9532.txt
> +++ b/Documentation/devicetree/bindings/leds/leds-pca9532.txt
> @@ -11,6 +11,14 @@ Required properties:
> "nxp,pca9533"
> - reg - I2C slave address
>
> +Optional properties:
> + - nxp,pwm: array of two 8-bit values specifying the blink duty cycle
> + fractions of each pwm (default <0 0>)
> + The duty cycle is pwm/256.
> + - nxp,psc: array of two 8-bit values specifying the blink period of
> + each pwm (default <0 0>)
> + The period is (psc+1)/152 seconds.
I believe we have standard properties for LED patterns now.
> +
> Each led is represented as a sub-node of the nxp,pca9530.
>
> Optional sub-node properties:
> @@ -26,6 +34,8 @@ Example:
> leds: pca9530@60 {
> compatible = "nxp,pca9530";
> reg = <0x60>;
> + nxp,pwm = /bits/ 8 <128 128>; // 50% duty cycle
> + nxp,psc = /bits/ 8 <151 37>; // 1Hz and 4Hz, respectively
>
> red-power {
> label = "pca:red:power";
> --
> 2.25.1
next prev parent reply other threads:[~2020-09-29 18:14 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-09-22 19:33 [PATCH v1 2/2] dt: bindings: pca9532: add description of pwm and psc settings Markus Moll
2020-09-29 18:14 ` Rob Herring [this message]
2020-09-29 18:56 ` Markus Moll
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200929181409.GA890687@bogus \
--to=robh@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=dmurphy@ti.com \
--cc=linux-leds@vger.kernel.org \
--cc=moll.markus@arcor.de \
--cc=pavel@ucw.cz \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.