From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from fllv0016.ext.ti.com (fllv0016.ext.ti.com [198.47.19.142]) by arago-project.org (Postfix) with ESMTPS id 39B6552991 for ; Tue, 29 Sep 2020 18:51:43 +0000 (UTC) Received: from fllv0034.itg.ti.com ([10.64.40.246]) by fllv0016.ext.ti.com (8.15.2/8.15.2) with ESMTP id 08TImi2o016232 for ; Tue, 29 Sep 2020 13:48:44 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ti.com; s=ti-com-17Q1; t=1601405324; bh=L1GT7bcZA18di5bSuIUn0Htd64hb3lqygQdTYEyVJbY=; h=Date:From:To:CC:Subject:References:In-Reply-To; b=gcsJGXZWIVtQIEQB+cjNANzn9/HtOGRk5R+1wZYoa0qYEJPgNltZmBnGqAHy1Smkn tqoa+eYQ8XjBlbgEC8eOjrYbDelOzidyLRcFWIZrVvX5iviLtPPWhOHPBNoT5USVMw gzCE5AMQhPANDjeMpZA0MlkVLyyo1+a1C+ycj61g= Received: from DLEE115.ent.ti.com (dlee115.ent.ti.com [157.170.170.26]) by fllv0034.itg.ti.com (8.15.2/8.15.2) with ESMTPS id 08TImiFu101763 (version=TLSv1.2 cipher=AES256-GCM-SHA384 bits=256 verify=FAIL) for ; Tue, 29 Sep 2020 13:48:44 -0500 Received: from DLEE106.ent.ti.com (157.170.170.36) by DLEE115.ent.ti.com (157.170.170.26) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.1979.3; Tue, 29 Sep 2020 13:48:43 -0500 Received: from fllv0040.itg.ti.com (10.64.41.20) by DLEE106.ent.ti.com (157.170.170.36) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.1979.3 via Frontend Transport; Tue, 29 Sep 2020 13:48:43 -0500 Received: from localhost (ileax41-snat.itg.ti.com [10.172.224.153]) by fllv0040.itg.ti.com (8.15.2/8.15.2) with ESMTP id 08TImhvO035306; Tue, 29 Sep 2020 13:48:43 -0500 Date: Tue, 29 Sep 2020 14:48:43 -0400 From: Denys Dmytriyenko To: Gowtham Tammana Message-ID: <20200929184843.GE7434@beryl> References: <20200929184700.10399-1-g-tammana@ti.com> MIME-Version: 1.0 In-Reply-To: <20200929184700.10399-1-g-tammana@ti.com> User-Agent: Mutt/1.5.24 (2015-08-30) X-EXCLAIMER-MD-CONFIG: e1e8a2fd-e40a-4ac6-ac9b-f7e9cc9ee180 Cc: meta-arago@arago-project.org Subject: Re: [dunfell/master][PATCH v2] kmscube: enable gles3 targets conditionally X-BeenThere: meta-arago@arago-project.org X-Mailman-Version: 2.1.12 Precedence: list List-Id: Arago metadata layer for TI SDKs - OE-Core/Yocto compatible List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 29 Sep 2020 18:51:43 -0000 Content-Type: text/plain; charset="us-ascii" Content-Disposition: inline On Tue, Sep 29, 2020 at 01:47:00PM -0500, Gowtham Tammana wrote: > Patch kmscube to enable gles3 targets conditionally, as not all glesv2 > targets support glesv3. > > Signed-off-by: Gowtham Tammana Reviewed-by: Denys Dmytriyenko > --- > v2 > - %s/APPEND/apend > > .../0001-meson-check-for-gles3-support.patch | 50 +++++++++++++++++++ > .../kmscube/kmscube_%.bbappend | 7 +++ > 2 files changed, 57 insertions(+) > create mode 100644 meta-arago-distro/recipes-graphics/kmscube/kmscube/0001-meson-check-for-gles3-support.patch > create mode 100644 meta-arago-distro/recipes-graphics/kmscube/kmscube_%.bbappend > > diff --git a/meta-arago-distro/recipes-graphics/kmscube/kmscube/0001-meson-check-for-gles3-support.patch b/meta-arago-distro/recipes-graphics/kmscube/kmscube/0001-meson-check-for-gles3-support.patch > new file mode 100644 > index 00000000..1ebeee07 > --- /dev/null > +++ b/meta-arago-distro/recipes-graphics/kmscube/kmscube/0001-meson-check-for-gles3-support.patch > @@ -0,0 +1,50 @@ > +From 9f7efd751a3cdceaeefa6c215a81aa6368857e40 Mon Sep 17 00:00:00 2001 > +From: Gowtham Tammana > +Date: Mon, 28 Sep 2020 21:15:52 -0500 > +Subject: [PATCH] meson: check for gles3 support > + > +Some cores don't support gles3, so compile gles3 targets > +conditionally. > + > +Upstream-Status: Pending > + > +Signed-off-by: Gowtham Tammana > +--- > + meson.build | 22 +++++++++++++++------- > + 1 file changed, 15 insertions(+), 7 deletions(-) > + > +diff --git a/meson.build b/meson.build > +index df9c315..8bba902 100644 > +--- a/meson.build > ++++ b/meson.build > +@@ -91,12 +91,20 @@ else > + message('Building without gstreamer support') > + endif > + > +-executable('kmscube', sources, dependencies : dep_common, install : true) > ++# GLES3 check > ++gles3_h = false > ++if dep_gles2.found() > ++ gles3_h = cc.has_header('GLES3/gl3.h', dependencies: dep_gles2) > ++endif > + > ++executable('kmscube', sources, dependencies : dep_common, install : true) > + > +-executable('texturator', files( > +- 'common.c', > +- 'drm-legacy.c', > +- 'drm-common.c', > +- 'texturator.c', > +-), dependencies : dep_common, install : true) > ++if gles3_h > ++ message('Building with GLES3 support') > ++ executable('texturator', files( > ++ 'common.c', > ++ 'drm-legacy.c', > ++ 'drm-common.c', > ++ 'texturator.c', > ++ ), dependencies : dep_common, install : true) > ++endif > +-- > +2.17.1 > + > diff --git a/meta-arago-distro/recipes-graphics/kmscube/kmscube_%.bbappend b/meta-arago-distro/recipes-graphics/kmscube/kmscube_%.bbappend > new file mode 100644 > index 00000000..d11012a8 > --- /dev/null > +++ b/meta-arago-distro/recipes-graphics/kmscube/kmscube_%.bbappend > @@ -0,0 +1,7 @@ > +FILESEXTRAPATHS_append := "${THISDIR}/${PN}:" > + > +SRC_URI += " \ > +file://0001-meson-check-for-gles3-support.patch \ > +" > + > +PR_append = ".arago1" > -- > 2.28.0 >