All of lore.kernel.org
 help / color / mirror / Atom feed
From: Mauro Carvalho Chehab <mchehab+huawei@kernel.org>
To: Malcolm Priestley <tvboxspy@gmail.com>
Cc: Joe Perches <joe@perches.com>,
	LKML <linux-kernel@vger.kernel.org>,
	linux-media <linux-media@vger.kernel.org>,
	Julia Lawall <julia.lawall@lip6.fr>
Subject: Re: [likely PATCH] media: lmedm04: Fix misuse of comma
Date: Tue, 29 Sep 2020 19:09:53 +0200	[thread overview]
Message-ID: <20200929190953.2f621541@coco.lan> (raw)
In-Reply-To: <d4b13e5d-6c97-2594-0ca6-346bb2129b88@gmail.com>

Em Mon, 24 Aug 2020 21:01:12 +0100
Malcolm Priestley <tvboxspy@gmail.com> escreveu:

> Good catch the interrupt URB is not running because usb_submit_urb is tangled with it.
> 
> It only really affects signal strength.

Yeah, that indeed sounds to be a real bug.

> 
> add
> 
> Fixes: 15e1ce33182d ("[media] lmedm04: Fix usb_submit_urb BOGUS urb xfer, pipe 1 != type 3 in interrupt urb")
> Cc: <stable@vger.kernel.org>
> 
> Regards
> 
> 
> Malcolm

That's said, while here, it sounds weird to use GFP_ATOMIC instead
of GFP_KERNEL for the URB submissions. 

Malcolm,

if you still have the hardware for testing, could you please
check if replacing them by GFP_KERNEL will work?

Thanks!
Mauro

Thanks,
Mauro

  parent reply	other threads:[~2020-09-29 17:10 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-08-23 18:13 [likely PATCH] media: lmedm04: Fix misuse of comma Joe Perches
2020-08-24 20:01 ` Malcolm Priestley
2020-08-24 20:02   ` Joe Perches
2020-08-24 20:09     ` Malcolm Priestley
2020-09-29 17:09   ` Mauro Carvalho Chehab [this message]
2020-10-03  9:32     ` [PATCH] media: lmedm04: Use GFP_KERNEL for URB allocation/submission Malcolm Priestley

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200929190953.2f621541@coco.lan \
    --to=mchehab+huawei@kernel.org \
    --cc=joe@perches.com \
    --cc=julia.lawall@lip6.fr \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-media@vger.kernel.org \
    --cc=tvboxspy@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.