From: Jason Gunthorpe <jgg@ziepe.ca>
To: Kamal Heib <kamalheib1@gmail.com>
Cc: linux-rdma@vger.kernel.org, Doug Ledford <dledford@redhat.com>
Subject: Re: [PATCH for-rc] RDMA/ipoib: Set rtnl_link_ops for ipoib interfaces
Date: Tue, 29 Sep 2020 21:22:40 -0300 [thread overview]
Message-ID: <20200930002240.GA9916@ziepe.ca> (raw)
In-Reply-To: <20200929060438.GA73375@kheib-workstation>
On Tue, Sep 29, 2020 at 09:04:38AM +0300, Kamal Heib wrote:
> On Mon, Sep 28, 2020 at 07:36:02PM -0300, Jason Gunthorpe wrote:
> > On Mon, Sep 28, 2020 at 11:26:31PM +0300, Kamal Heib wrote:
> > > Before this patch, the rtnl_link_ops are set only for ipoib network
> > > devices that are created via the rtnl_link_ops->newlink() callback, this
> > > patch fixes that by setting the rtnl_link_ops for all ipoib network
> > > devices. Also, implement the dellink() callback to block users from
> > > trying to remove the base ipoib network device while allowing it only
> > > for child interfaces.
> >
> > Why?
> >
>
> This is needed to avoid the inconsistent user experience for PKeys that
> is created via netlink VS PKeys that is created via sysfs and the based
> ipoib interface, as you can see below the ipoib attributes are reported
> only for PKeys that is created via netlink in the 'ip -d link show'
> output:
Summarize this in the commit message please
Jason
prev parent reply other threads:[~2020-09-30 0:22 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-09-28 20:26 [PATCH for-rc] RDMA/ipoib: Set rtnl_link_ops for ipoib interfaces Kamal Heib
2020-09-28 22:36 ` Jason Gunthorpe
2020-09-29 6:04 ` Kamal Heib
2020-09-30 0:22 ` Jason Gunthorpe [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200930002240.GA9916@ziepe.ca \
--to=jgg@ziepe.ca \
--cc=dledford@redhat.com \
--cc=kamalheib1@gmail.com \
--cc=linux-rdma@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.