From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.0 required=3.0 tests=BAYES_00,DKIM_ADSP_CUSTOM_MED, DKIM_INVALID,DKIM_SIGNED,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6BAABC2D0A8 for ; Wed, 30 Sep 2020 05:55:43 +0000 (UTC) Received: from hemlock.osuosl.org (smtp2.osuosl.org [140.211.166.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 03047206B8 for ; Wed, 30 Sep 2020 05:55:42 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="Ha0J0YFF" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 03047206B8 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=iommu-bounces@lists.linux-foundation.org Received: from localhost (localhost [127.0.0.1]) by hemlock.osuosl.org (Postfix) with ESMTP id C0359871AE; Wed, 30 Sep 2020 05:55:42 +0000 (UTC) X-Virus-Scanned: amavisd-new at osuosl.org Received: from hemlock.osuosl.org ([127.0.0.1]) by localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id 0+1yo2Xz3lQq; Wed, 30 Sep 2020 05:55:42 +0000 (UTC) Received: from lists.linuxfoundation.org (lf-lists.osuosl.org [140.211.9.56]) by hemlock.osuosl.org (Postfix) with ESMTP id 511968708F; Wed, 30 Sep 2020 05:55:42 +0000 (UTC) Received: from lf-lists.osuosl.org (localhost [127.0.0.1]) by lists.linuxfoundation.org (Postfix) with ESMTP id 3CD13C0889; Wed, 30 Sep 2020 05:55:42 +0000 (UTC) Received: from fraxinus.osuosl.org (smtp4.osuosl.org [140.211.166.137]) by lists.linuxfoundation.org (Postfix) with ESMTP id 321EFC0051 for ; Wed, 30 Sep 2020 05:55:41 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by fraxinus.osuosl.org (Postfix) with ESMTP id 2E31285FC9 for ; Wed, 30 Sep 2020 05:55:41 +0000 (UTC) X-Virus-Scanned: amavisd-new at osuosl.org Received: from fraxinus.osuosl.org ([127.0.0.1]) by localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id Z2PuYR4_oNu4 for ; Wed, 30 Sep 2020 05:55:40 +0000 (UTC) X-Greylist: domain auto-whitelisted by SQLgrey-1.7.6 Received: from mail-pl1-f195.google.com (mail-pl1-f195.google.com [209.85.214.195]) by fraxinus.osuosl.org (Postfix) with ESMTPS id 2082F85F2F for ; Wed, 30 Sep 2020 05:55:40 +0000 (UTC) Received: by mail-pl1-f195.google.com with SMTP id bb1so344722plb.2 for ; Tue, 29 Sep 2020 22:55:40 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:content-transfer-encoding:in-reply-to :user-agent; bh=ZKt1l06WBiOe5oSa8hvHMMaReLuZvec2hHg90p7XYZw=; b=Ha0J0YFFJbPQksFeyj5p+V9nuCr+5BSKAknv2WvbX953a+2DlUmJ6wy4K5XDXRMwg7 /w7xQHmu0IsodtL9hWFAu0/LxDx0sVH6qUsXvXBhHK7esn1M2Aou30kHiz1SDOxk761X vxUyVBUPJ2B8jXI8kN97kwkIGvgDD0FcJ5h4Fw7+z2yAoOYB9btAMfuVVTpmx2+CeJUB DevOO0PMjyiFRJibfaW261V/zpVf9oLYHnydIaPfI5f9lSwAts/e92P/sDn41w5Ixg/g 7wUnFg5WSW0+OzdRzb8dHqwT6qYP+LjOUaBy3MPcxvwiMITWeesV6FCzwRlmtAdCS6DO urVQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:content-transfer-encoding :in-reply-to:user-agent; bh=ZKt1l06WBiOe5oSa8hvHMMaReLuZvec2hHg90p7XYZw=; b=twHldPKuErkIPhIyb9ACnR7InYU4qj9YjlLXa8RePAZwmmF1UW0CmManWQ6aWay7CM 5x+DHzs1W7zDUpvReiIYTI7Z2wehq+Sn3L2DkBfhLTV3XjeEyW24+v7nVSer1s21bp2v x28/ccdgJdTmk9p79mRqMKwTKzo2qdzz/YJTbyBU7c9QbSk0HDBMXzps1shsb/0XhJfo ZcBFSU4W/QDvRyR7iRk9S6L3zMoH25/Xgftml+neDwqKRVu1yP+mGmpZJ28oHt13uRIV NuOi4S5mFJ69lThkYwTFOM6JSNXgGQV24QB0TEcmMoxFVHmu9o0X3FiUWJCWHHoCXryO WLhg== X-Gm-Message-State: AOAM531AXGbZrQsEL1QEObQfywueAzuBS6FVXw5CGzC10b1KF3QmJg/y US3t6Vo9BzlHuXzGn8n1Ilk= X-Google-Smtp-Source: ABdhPJxxPH3+l0h0b3d77zTykpSEcWgLoj6N2dP/iZ7QevPI0t6mFehpDdcbtQHqGWvYygqI0MFMIw== X-Received: by 2002:a17:90a:104f:: with SMTP id y15mr1019025pjd.45.1601445339766; Tue, 29 Sep 2020 22:55:39 -0700 (PDT) Received: from Asurada-Nvidia (thunderhill.nvidia.com. [216.228.112.22]) by smtp.gmail.com with ESMTPSA id n2sm773071pfe.208.2020.09.29.22.55.39 (version=TLS1_2 cipher=ECDHE-ECDSA-CHACHA20-POLY1305 bits=256/256); Tue, 29 Sep 2020 22:55:39 -0700 (PDT) Date: Tue, 29 Sep 2020 22:50:09 -0700 From: Nicolin Chen To: Dmitry Osipenko Subject: Re: [PATCH v2 2/3] iommu/tegra-smmu: Rework .probe_device and .attach_dev Message-ID: <20200930055008.GH31821@Asurada-Nvidia> References: <20200930003013.31289-1-nicoleotsuka@gmail.com> <20200930003013.31289-3-nicoleotsuka@gmail.com> <931eb16b-4529-2c20-c696-c57a9138aded@gmail.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <931eb16b-4529-2c20-c696-c57a9138aded@gmail.com> User-Agent: Mutt/1.9.4 (2018-02-28) Cc: linux-kernel@vger.kernel.org, iommu@lists.linux-foundation.org, krzk@kernel.org, jonathanh@nvidia.com, thierry.reding@gmail.com, linux-tegra@vger.kernel.org X-BeenThere: iommu@lists.linux-foundation.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: Development issues for Linux IOMMU support List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Errors-To: iommu-bounces@lists.linux-foundation.org Sender: "iommu" T24gV2VkLCBTZXAgMzAsIDIwMjAgYXQgMDg6MjA6NTBBTSArMDMwMCwgRG1pdHJ5IE9zaXBlbmtv IHdyb3RlOgo+IDMwLjA5LjIwMjAgMDg6MTAsIERtaXRyeSBPc2lwZW5rbyDQv9C40YjQtdGCOgo+ ID4gMzAuMDkuMjAyMCAwMzozMCwgTmljb2xpbiBDaGVuINC/0LjRiNC10YI6Cj4gPj4gIHN0YXRp YyB2b2lkIHRlZ3JhX3NtbXVfcmVsZWFzZV9kZXZpY2Uoc3RydWN0IGRldmljZSAqZGV2KQo+ID4g Cj4gPiBUaGUgdGVncmFfZ2V0X21lbW9yeV9jb250cm9sbGVyKCkgdXNlcyBvZl9maW5kX2Rldmlj ZV9ieV9ub2RlKCksIGhlbmNlCj4gPiB0ZWdyYV9zbW11X3JlbGVhc2VfZGV2aWNlKCkgc2hvdWxk IHB1dF9kZXZpY2UobWMpIGluIG9yZGVyIHRvIGJhbGFuY2UKPiA+IGJhY2sgdGhlIHJlZmNvdW50 aW5nLgo+ID4gCj4gCj4gQWN0dWFsbHksIHRoZSBwdXRfZGV2aWNlKG1jKSBzaG91bGQgYmUgcmln aHQgYWZ0ZXIKPiB0ZWdyYV9nZXRfbWVtb3J5X2NvbnRyb2xsZXIoKSBpbiB0ZWdyYV9zbW11X3By b2JlX2RldmljZSgpIGJlY2F1c2UgU01NVQo+IGlzIGEgcGFydCBvZiBNQywgaGVuY2UgTUMgY2Fu J3QganVzdCBnbyBhd2F5LgoKV2lsbCBhZGQgaXQuIFRoYW5rcyBmb3IgcG9pbnRpbmcgaXQgb3V0 IQpfX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fXwppb21tdSBt YWlsaW5nIGxpc3QKaW9tbXVAbGlzdHMubGludXgtZm91bmRhdGlvbi5vcmcKaHR0cHM6Ly9saXN0 cy5saW51eGZvdW5kYXRpb24ub3JnL21haWxtYW4vbGlzdGluZm8vaW9tbXU= From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.3 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4F446C2D0A8 for ; Wed, 30 Sep 2020 05:55:41 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 1622F206B8 for ; Wed, 30 Sep 2020 05:55:40 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="Ha0J0YFF" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1725823AbgI3Fzk (ORCPT ); Wed, 30 Sep 2020 01:55:40 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:38546 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725535AbgI3Fzk (ORCPT ); Wed, 30 Sep 2020 01:55:40 -0400 Received: from mail-pl1-x642.google.com (mail-pl1-x642.google.com [IPv6:2607:f8b0:4864:20::642]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 2DE57C061755; Tue, 29 Sep 2020 22:55:40 -0700 (PDT) Received: by mail-pl1-x642.google.com with SMTP id t13so345860plb.10; Tue, 29 Sep 2020 22:55:40 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:content-transfer-encoding:in-reply-to :user-agent; bh=ZKt1l06WBiOe5oSa8hvHMMaReLuZvec2hHg90p7XYZw=; b=Ha0J0YFFJbPQksFeyj5p+V9nuCr+5BSKAknv2WvbX953a+2DlUmJ6wy4K5XDXRMwg7 /w7xQHmu0IsodtL9hWFAu0/LxDx0sVH6qUsXvXBhHK7esn1M2Aou30kHiz1SDOxk761X vxUyVBUPJ2B8jXI8kN97kwkIGvgDD0FcJ5h4Fw7+z2yAoOYB9btAMfuVVTpmx2+CeJUB DevOO0PMjyiFRJibfaW261V/zpVf9oLYHnydIaPfI5f9lSwAts/e92P/sDn41w5Ixg/g 7wUnFg5WSW0+OzdRzb8dHqwT6qYP+LjOUaBy3MPcxvwiMITWeesV6FCzwRlmtAdCS6DO urVQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:content-transfer-encoding :in-reply-to:user-agent; bh=ZKt1l06WBiOe5oSa8hvHMMaReLuZvec2hHg90p7XYZw=; b=dH7gl+ek8X1+cyMSDu3dAKREvM2yN0mwyqdYWBe3y2O0qqLP+RGBIYByv7Nk6i7P/o zZRCc/cnzQ37Ulx2pu30uPhNVQofva/E03vnvC5l3KAhbO8/VTPy87b5KEufaLfu/cR1 Klm5R7IUUsqMa6E3NWZDaJkf3McV8V+NZq1rXLKOfDWpx/Vm49CdzQTTAxPpM7JBbt+X H0ilvvZsPMXMOKdOCr4VPI6uAu4weFrLgpTj+fE0r0uxDQsFuqzNFul+dg5yUR1HWSPC /1isKvg2uGibQGo7a5hmWQVmo5GWzl+oemVmcWr7g0RB96c0IEbV1MYYEfisupgnhJ+K qlHQ== X-Gm-Message-State: AOAM533LUpZ8EY16T2Z1cWjOJEd8fxiUax3iZuCXQdW6q0V0xlXxTN+/ BCol2c0uQ1XPOYzzHu74Avw= X-Google-Smtp-Source: ABdhPJxxPH3+l0h0b3d77zTykpSEcWgLoj6N2dP/iZ7QevPI0t6mFehpDdcbtQHqGWvYygqI0MFMIw== X-Received: by 2002:a17:90a:104f:: with SMTP id y15mr1019025pjd.45.1601445339766; Tue, 29 Sep 2020 22:55:39 -0700 (PDT) Received: from Asurada-Nvidia (thunderhill.nvidia.com. [216.228.112.22]) by smtp.gmail.com with ESMTPSA id n2sm773071pfe.208.2020.09.29.22.55.39 (version=TLS1_2 cipher=ECDHE-ECDSA-CHACHA20-POLY1305 bits=256/256); Tue, 29 Sep 2020 22:55:39 -0700 (PDT) Date: Tue, 29 Sep 2020 22:50:09 -0700 From: Nicolin Chen To: Dmitry Osipenko Cc: thierry.reding@gmail.com, joro@8bytes.org, krzk@kernel.org, vdumpa@nvidia.com, jonathanh@nvidia.com, linux-tegra@vger.kernel.org, iommu@lists.linux-foundation.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v2 2/3] iommu/tegra-smmu: Rework .probe_device and .attach_dev Message-ID: <20200930055008.GH31821@Asurada-Nvidia> References: <20200930003013.31289-1-nicoleotsuka@gmail.com> <20200930003013.31289-3-nicoleotsuka@gmail.com> <931eb16b-4529-2c20-c696-c57a9138aded@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <931eb16b-4529-2c20-c696-c57a9138aded@gmail.com> User-Agent: Mutt/1.9.4 (2018-02-28) Precedence: bulk List-ID: X-Mailing-List: linux-tegra@vger.kernel.org On Wed, Sep 30, 2020 at 08:20:50AM +0300, Dmitry Osipenko wrote: > 30.09.2020 08:10, Dmitry Osipenko пишет: > > 30.09.2020 03:30, Nicolin Chen пишет: > >> static void tegra_smmu_release_device(struct device *dev) > > > > The tegra_get_memory_controller() uses of_find_device_by_node(), hence > > tegra_smmu_release_device() should put_device(mc) in order to balance > > back the refcounting. > > > > Actually, the put_device(mc) should be right after > tegra_get_memory_controller() in tegra_smmu_probe_device() because SMMU > is a part of MC, hence MC can't just go away. Will add it. Thanks for pointing it out!