From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.0 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3E21CC2D0A8 for ; Wed, 30 Sep 2020 07:37:31 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 01A742076E for ; Wed, 30 Sep 2020 07:37:30 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728126AbgI3Hha (ORCPT ); Wed, 30 Sep 2020 03:37:30 -0400 Received: from relay12.mail.gandi.net ([217.70.178.232]:34595 "EHLO relay12.mail.gandi.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725440AbgI3Hha (ORCPT ); Wed, 30 Sep 2020 03:37:30 -0400 X-Greylist: delayed 426 seconds by postgrey-1.27 at vger.kernel.org; Wed, 30 Sep 2020 03:37:29 EDT Received: from localhost (lfbn-lyo-1-1908-165.w90-65.abo.wanadoo.fr [90.65.88.165]) (Authenticated sender: alexandre.belloni@bootlin.com) by relay12.mail.gandi.net (Postfix) with ESMTPSA id BA61B200013; Wed, 30 Sep 2020 07:37:27 +0000 (UTC) Date: Wed, 30 Sep 2020 09:37:27 +0200 From: Alexandre Belloni To: Alexandru Ardelean Cc: linux-iio@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, jic23@kernel.org, nicolas.ferre@microchip.com, ludovic.desroches@microchip.com Subject: Re: [PATCH v2 3/4] iio: adc: at91_adc: add Kconfig dependency on the OF symbol Message-ID: <20200930073727.GC2804081@piout.net> References: <20200930060008.42134-1-alexandru.ardelean@analog.com> <20200930060008.42134-4-alexandru.ardelean@analog.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200930060008.42134-4-alexandru.ardelean@analog.com> Precedence: bulk List-ID: X-Mailing-List: linux-iio@vger.kernel.org Hi, On 30/09/2020 09:00:07+0300, Alexandru Ardelean wrote: > This tries to solve a warning reported by the lkp bot: > > >> drivers/iio/adc/at91_adc.c:1439:34: warning: unused variable > >> 'at91_adc_dt_ids' [-Wunused-const-variable] > static const struct of_device_id at91_adc_dt_ids[] = { > ^ > 1 warning generated. > > This shows up with 'compiler: clang version 12.0.0' and W=1 (as the bot > mentions). > > Forward declarations for global variables can be a bit weird; forward > function declarations are more common. > > Maybe another fix for this would have been to prefix with 'extern' the > 'at91_adc_dt_ids' variable, thus making it more friendly as a forward > declaration. It would look weird, but it would work. > > But, we can avoid that forward declaration altogether simply by obtaining > the private data with of_device_get_match_data(). > > This appeared after commit 4027860dcc4c ("iio: Kconfig: at91_adc: add > COMPILE_TEST dependency to driver"), which put this driver on the lkp's bot > radar. > Shouldn't all of that be part of the commit message for 1/4? This doesn't explicitly explain why you add a dependency on OF. > Fixes: 4027860dcc4c ("iio: Kconfig: at91_adc: add COMPILE_TEST dependency to driver") > Reported-by: kernel test robot > Signed-off-by: Alexandru Ardelean > --- > drivers/iio/adc/Kconfig | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/iio/adc/Kconfig b/drivers/iio/adc/Kconfig > index 91ae90514aff..17e9ceb9c6c4 100644 > --- a/drivers/iio/adc/Kconfig > +++ b/drivers/iio/adc/Kconfig > @@ -295,7 +295,7 @@ config ASPEED_ADC > config AT91_ADC > tristate "Atmel AT91 ADC" > depends on ARCH_AT91 || COMPILE_TEST > - depends on INPUT && SYSFS > + depends on INPUT && SYSFS && OF > select IIO_BUFFER > select IIO_TRIGGERED_BUFFER > help > -- > 2.17.1 > -- Alexandre Belloni, Bootlin Embedded Linux and Kernel engineering https://bootlin.com From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.5 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id C854FC2D0A8 for ; Wed, 30 Sep 2020 07:39:32 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 138EC2075F for ; Wed, 30 Sep 2020 07:39:32 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="CFXTHu/1" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 138EC2075F Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=bootlin.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References:Message-ID: Subject:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=Y9JGG2ZPtdDFRaQrTYx5UOUEkAEDuSY/7C0Vakndp5E=; b=CFXTHu/1XmfR/40NGal9AV4Uk 9Ff5MSrBQ5DeYIuA200xFPSHDUjFAJERhQQ3OWZ7nk9iPX2CUulDhps/wG0Zs99hk3FJa1M5gaF7z 63YTOjju5dWh0nGCI7annfunvo8i3SZld9544eSloYMwF5XDRzhIddpAw44/ZzOBltoAP9Xqg2XOs deRiX5vW/tey51S/ieZMYitL3N2CkOt3MjJxGEy3oh7K3fSgx1GIwBKrUUrNekc75FbbPCggz638m 63VYM8JpqhyPOBMoKmN9WLtENl5LYl6jxGgzX21gKmI3YI7K0wStY1iDieXnNs/C7eBVT+byjkOFh CPHVLX+Iw==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1kNWg8-00023Q-Ir; Wed, 30 Sep 2020 07:37:32 +0000 Received: from relay12.mail.gandi.net ([217.70.178.232]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1kNWg6-00021P-4O for linux-arm-kernel@lists.infradead.org; Wed, 30 Sep 2020 07:37:31 +0000 Received: from localhost (lfbn-lyo-1-1908-165.w90-65.abo.wanadoo.fr [90.65.88.165]) (Authenticated sender: alexandre.belloni@bootlin.com) by relay12.mail.gandi.net (Postfix) with ESMTPSA id BA61B200013; Wed, 30 Sep 2020 07:37:27 +0000 (UTC) Date: Wed, 30 Sep 2020 09:37:27 +0200 From: Alexandre Belloni To: Alexandru Ardelean Subject: Re: [PATCH v2 3/4] iio: adc: at91_adc: add Kconfig dependency on the OF symbol Message-ID: <20200930073727.GC2804081@piout.net> References: <20200930060008.42134-1-alexandru.ardelean@analog.com> <20200930060008.42134-4-alexandru.ardelean@analog.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20200930060008.42134-4-alexandru.ardelean@analog.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200930_033730_310834_96FFF5C1 X-CRM114-Status: GOOD ( 21.88 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org, ludovic.desroches@microchip.com, linux-arm-kernel@lists.infradead.org, jic23@kernel.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hi, On 30/09/2020 09:00:07+0300, Alexandru Ardelean wrote: > This tries to solve a warning reported by the lkp bot: > > >> drivers/iio/adc/at91_adc.c:1439:34: warning: unused variable > >> 'at91_adc_dt_ids' [-Wunused-const-variable] > static const struct of_device_id at91_adc_dt_ids[] = { > ^ > 1 warning generated. > > This shows up with 'compiler: clang version 12.0.0' and W=1 (as the bot > mentions). > > Forward declarations for global variables can be a bit weird; forward > function declarations are more common. > > Maybe another fix for this would have been to prefix with 'extern' the > 'at91_adc_dt_ids' variable, thus making it more friendly as a forward > declaration. It would look weird, but it would work. > > But, we can avoid that forward declaration altogether simply by obtaining > the private data with of_device_get_match_data(). > > This appeared after commit 4027860dcc4c ("iio: Kconfig: at91_adc: add > COMPILE_TEST dependency to driver"), which put this driver on the lkp's bot > radar. > Shouldn't all of that be part of the commit message for 1/4? This doesn't explicitly explain why you add a dependency on OF. > Fixes: 4027860dcc4c ("iio: Kconfig: at91_adc: add COMPILE_TEST dependency to driver") > Reported-by: kernel test robot > Signed-off-by: Alexandru Ardelean > --- > drivers/iio/adc/Kconfig | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/iio/adc/Kconfig b/drivers/iio/adc/Kconfig > index 91ae90514aff..17e9ceb9c6c4 100644 > --- a/drivers/iio/adc/Kconfig > +++ b/drivers/iio/adc/Kconfig > @@ -295,7 +295,7 @@ config ASPEED_ADC > config AT91_ADC > tristate "Atmel AT91 ADC" > depends on ARCH_AT91 || COMPILE_TEST > - depends on INPUT && SYSFS > + depends on INPUT && SYSFS && OF > select IIO_BUFFER > select IIO_TRIGGERED_BUFFER > help > -- > 2.17.1 > -- Alexandre Belloni, Bootlin Embedded Linux and Kernel engineering https://bootlin.com _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel