From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.0 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5B73CC2D0A8 for ; Wed, 30 Sep 2020 07:47:33 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 104DC2076E for ; Wed, 30 Sep 2020 07:47:33 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1725892AbgI3Hrc (ORCPT ); Wed, 30 Sep 2020 03:47:32 -0400 Received: from relay2-d.mail.gandi.net ([217.70.183.194]:38847 "EHLO relay2-d.mail.gandi.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725440AbgI3Hrc (ORCPT ); Wed, 30 Sep 2020 03:47:32 -0400 X-Greylist: delayed 917 seconds by postgrey-1.27 at vger.kernel.org; Wed, 30 Sep 2020 03:47:31 EDT X-Originating-IP: 90.65.88.165 Received: from localhost (lfbn-lyo-1-1908-165.w90-65.abo.wanadoo.fr [90.65.88.165]) (Authenticated sender: alexandre.belloni@bootlin.com) by relay2-d.mail.gandi.net (Postfix) with ESMTPSA id DF2F14000F; Wed, 30 Sep 2020 07:47:28 +0000 (UTC) Date: Wed, 30 Sep 2020 09:47:28 +0200 From: Alexandre Belloni To: Alexandru Ardelean Cc: linux-iio@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, jic23@kernel.org, nicolas.ferre@microchip.com, ludovic.desroches@microchip.com Subject: Re: [PATCH v2 4/4] iio: adc: at91_adc: remove of_match_ptr() usage Message-ID: <20200930074728.GD2804081@piout.net> References: <20200930060008.42134-1-alexandru.ardelean@analog.com> <20200930060008.42134-5-alexandru.ardelean@analog.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200930060008.42134-5-alexandru.ardelean@analog.com> Precedence: bulk List-ID: X-Mailing-List: linux-iio@vger.kernel.org Hi, On 30/09/2020 09:00:08+0300, Alexandru Ardelean wrote: > Since the driver should be allowed to build without OF support, the > of_match_ptr() is redundant. > This can probably be squashed with the previous commit. Also, I think that you should really make the driver DT only else, the driver will carry dead code and there will be no reminder that a cleanup is needed. I can take care of that if you feel that this is more work than what you wanted to spend on this driver. > Signed-off-by: Alexandru Ardelean > --- > drivers/iio/adc/at91_adc.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/iio/adc/at91_adc.c b/drivers/iio/adc/at91_adc.c > index 7d846a2852a5..473bffe84fbd 100644 > --- a/drivers/iio/adc/at91_adc.c > +++ b/drivers/iio/adc/at91_adc.c > @@ -1466,7 +1466,7 @@ static struct platform_driver at91_adc_driver = { > .id_table = at91_adc_ids, > .driver = { > .name = DRIVER_NAME, > - .of_match_table = of_match_ptr(at91_adc_dt_ids), > + .of_match_table = at91_adc_dt_ids, > .pm = &at91_adc_pm_ops, > }, > }; > -- > 2.17.1 > -- Alexandre Belloni, Bootlin Embedded Linux and Kernel engineering https://bootlin.com From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.5 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0307DC2D0A8 for ; Wed, 30 Sep 2020 07:48:45 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 753C42071E for ; Wed, 30 Sep 2020 07:48:44 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="gGZOWYAe" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 753C42071E Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=bootlin.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References:Message-ID: Subject:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=7UtTaztiz9wSUCXK9QeJk5rRgVQMJnF97fOsOVvaDFk=; b=gGZOWYAe/wGZ5mOv6gi2yNBWs /AOMNeoh2bKVi+yK0PAdrF7mTknkBZKCA6Xgh4U9mT0PXAj2w0p+3S3XmXqp/dNsqMErfn4F/susR Yqo1o8CxvuXdxyyheteYK1QwZPr5KCQ0jvYJPS2PmJZa7xyyiUNrrGQW/6sOWihOJw7Bc6U0+aj19 EN72ADh5NVSWFbIN412J2NIOm/sBi/4YJ05itFSciXp2ZRkujqQaBvXpzgeJ2x/2Cx57HK1CubHZr ZbPg1pY+TKiFqvg0fG0m87kGLUOgh5UACcPrwa5NbjnM0ukx69vYgM4B7e5gKRFsnHzZeFYigfmmA j/DG+0Tqg==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1kNWps-0004ig-BX; Wed, 30 Sep 2020 07:47:36 +0000 Received: from relay2-d.mail.gandi.net ([217.70.183.194]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1kNWpo-0004hN-MP for linux-arm-kernel@lists.infradead.org; Wed, 30 Sep 2020 07:47:33 +0000 X-Originating-IP: 90.65.88.165 Received: from localhost (lfbn-lyo-1-1908-165.w90-65.abo.wanadoo.fr [90.65.88.165]) (Authenticated sender: alexandre.belloni@bootlin.com) by relay2-d.mail.gandi.net (Postfix) with ESMTPSA id DF2F14000F; Wed, 30 Sep 2020 07:47:28 +0000 (UTC) Date: Wed, 30 Sep 2020 09:47:28 +0200 From: Alexandre Belloni To: Alexandru Ardelean Subject: Re: [PATCH v2 4/4] iio: adc: at91_adc: remove of_match_ptr() usage Message-ID: <20200930074728.GD2804081@piout.net> References: <20200930060008.42134-1-alexandru.ardelean@analog.com> <20200930060008.42134-5-alexandru.ardelean@analog.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20200930060008.42134-5-alexandru.ardelean@analog.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200930_034732_829031_618D7BB9 X-CRM114-Status: GOOD ( 17.57 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org, ludovic.desroches@microchip.com, linux-arm-kernel@lists.infradead.org, jic23@kernel.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hi, On 30/09/2020 09:00:08+0300, Alexandru Ardelean wrote: > Since the driver should be allowed to build without OF support, the > of_match_ptr() is redundant. > This can probably be squashed with the previous commit. Also, I think that you should really make the driver DT only else, the driver will carry dead code and there will be no reminder that a cleanup is needed. I can take care of that if you feel that this is more work than what you wanted to spend on this driver. > Signed-off-by: Alexandru Ardelean > --- > drivers/iio/adc/at91_adc.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/iio/adc/at91_adc.c b/drivers/iio/adc/at91_adc.c > index 7d846a2852a5..473bffe84fbd 100644 > --- a/drivers/iio/adc/at91_adc.c > +++ b/drivers/iio/adc/at91_adc.c > @@ -1466,7 +1466,7 @@ static struct platform_driver at91_adc_driver = { > .id_table = at91_adc_ids, > .driver = { > .name = DRIVER_NAME, > - .of_match_table = of_match_ptr(at91_adc_dt_ids), > + .of_match_table = at91_adc_dt_ids, > .pm = &at91_adc_pm_ops, > }, > }; > -- > 2.17.1 > -- Alexandre Belloni, Bootlin Embedded Linux and Kernel engineering https://bootlin.com _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel