From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.5 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id DA88DC4727F for ; Wed, 30 Sep 2020 09:02:56 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id A641220719 for ; Wed, 30 Sep 2020 09:02:56 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728235AbgI3JC4 (ORCPT ); Wed, 30 Sep 2020 05:02:56 -0400 Received: from verein.lst.de ([213.95.11.211]:43862 "EHLO verein.lst.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725776AbgI3JC4 (ORCPT ); Wed, 30 Sep 2020 05:02:56 -0400 Received: by verein.lst.de (Postfix, from userid 2407) id 9EFDB67357; Wed, 30 Sep 2020 11:02:52 +0200 (CEST) Date: Wed, 30 Sep 2020 11:02:52 +0200 From: Christoph Hellwig To: Paul Cercueil Cc: Christoph Hellwig , Stephen Rothwell , Dave Airlie , DRI , Linux Next Mailing List , Linux Kernel Mailing List Subject: Re: linux-next: build failure after merge of the drm tree Message-ID: <20200930090252.GA9357@lst.de> References: <20200928135405.73404219@canb.auug.org.au> <20200928060427.GA15041@lst.de> <20200928113415.GA555@lst.de> <72ADHQ.T6LL1SHQF0RG3@crapouillou.net> <20200928121002.GA3219@lst.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.17 (2007-11-01) Precedence: bulk List-ID: X-Mailing-List: linux-next@vger.kernel.org On Mon, Sep 28, 2020 at 03:31:28PM +0200, Paul Cercueil wrote: > It's allocated with dma_alloc_wc, but then it's only accessed as > non-coherent. > > Anyway, for the time being I guess you could revert 37054fc81443. But I > have patches on top of it in drm-misc-next so it's going to be a mess. > > If we have time I can come up with a custom dumb_create() fonction, to make > sure that the GEM buffers are allocated with dma_alloc_noncoherent(). Is > there a dma_mmap_noncoherent() too? Please use the lower-level dma_alloc_pages and then just insert the pages directly using remap_pfn_range. Although it might make sense to eventually create a wrapper around remap_pfn_range for all the vma sizing sanity checks. > > -Paul > ---end quoted text---