From: Jarkko Sakkinen <jarkko.sakkinen@linux.intel.com>
To: Andrew Cooper <andrew.cooper3@citrix.com>
Cc: Jethro Beekman <jethro@fortanix.com>,
Dave Hansen <dave.hansen@intel.com>,
Sean Christopherson <sean.j.christopherson@intel.com>,
linux-sgx@vger.kernel.org, x86@kernel.org,
Haitao Huang <haitao.huang@linux.intel.com>,
Borislav Petkov <bp@alien8.de>,
Dave Hansen <dave.hansen@linux.intel.com>,
Andy Lutomirski <luto@amacapital.net>,
Cedric Xing <cedric.xing@intel.com>
Subject: Re: [PATCH] x86/vdso: Remove retpoline from SGX vDSO call
Date: Wed, 30 Sep 2020 22:25:41 +0300 [thread overview]
Message-ID: <20200930192541.GA60658@linux.intel.com> (raw)
In-Reply-To: <cc222137-e488-c48a-ca66-000e74944eea@citrix.com>
On Wed, Sep 30, 2020 at 07:09:33PM +0100, Andrew Cooper wrote:
> Honestly, my advice would be to leave it unprotected for now. Anyone
> who managed to figure out the rest of the practical userspace issues
> will probably have a much better idea of what can/should be done in this
> case.
>
> If that doesn't sit well with people, then the next best would probably
> be LFENCE; CALL *reg/mem; LFENCE to cover as many of the corner cases as
> possible without being incompatible with CET. Its not as if this
> callback is the slow aspect of entering/exiting SGX mode.
>
> ~Andrew
I tend to agree. We cannot drive changes based on unknown unknowns.
And I don't see why we could not add boot time patching of retpoline
even after the code is in the mainline kernel, if something ever
pushes to that direction.
/Jarkko
next prev parent reply other threads:[~2020-09-30 19:25 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-09-30 14:01 [PATCH] x86/vdso: Remove retpoline from SGX vDSO call Jarkko Sakkinen
2020-09-30 14:08 ` Dave Hansen
2020-09-30 14:20 ` Jarkko Sakkinen
2020-09-30 14:33 ` Dave Hansen
2020-09-30 15:28 ` Jarkko Sakkinen
2020-09-30 15:43 ` Sean Christopherson
2020-09-30 16:28 ` Dave Hansen
2020-09-30 17:01 ` Jethro Beekman
2020-09-30 18:09 ` Andrew Cooper
2020-09-30 19:25 ` Jarkko Sakkinen [this message]
2020-09-30 20:45 ` Xing, Cedric
2020-09-30 21:22 ` Jarkko Sakkinen
2020-09-30 21:36 ` Jarkko Sakkinen
2020-09-30 21:46 ` Dave Hansen
2020-09-30 23:41 ` Jarkko Sakkinen
2020-09-30 16:38 ` Jarkko Sakkinen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200930192541.GA60658@linux.intel.com \
--to=jarkko.sakkinen@linux.intel.com \
--cc=andrew.cooper3@citrix.com \
--cc=bp@alien8.de \
--cc=cedric.xing@intel.com \
--cc=dave.hansen@intel.com \
--cc=dave.hansen@linux.intel.com \
--cc=haitao.huang@linux.intel.com \
--cc=jethro@fortanix.com \
--cc=linux-sgx@vger.kernel.org \
--cc=luto@amacapital.net \
--cc=sean.j.christopherson@intel.com \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.