From: Arnaldo Carvalho de Melo <acme@kernel.org>
To: Steven Rostedt <rostedt@goodmis.org>
Cc: "Tzvetomir Stoyanov (VMware)" <tz.stoyanov@gmail.com>,
arnaldo.melo@gmail.com, linux-trace-devel@vger.kernel.org,
ben@decadent.org.uk, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v4] tools lib traceevent: Hide non API functions
Date: Wed, 30 Sep 2020 22:33:49 -0300 [thread overview]
Message-ID: <20201001013349.GB3169811@kernel.org> (raw)
In-Reply-To: <20200930125027.7e54b71c@gandalf.local.home>
Em Wed, Sep 30, 2020 at 12:50:27PM -0400, Steven Rostedt escreveu:
> On Wed, 30 Sep 2020 14:07:33 +0300
> "Tzvetomir Stoyanov (VMware)" <tz.stoyanov@gmail.com> wrote:
>
> > There are internal library functions, which are not declared as a static.
> > They are used inside the library from different files. Hide them from
> > the library users, as they are not part of the API.
> > These functions are made hidden and are renamed without the prefix "tep_":
> > tep_free_plugin_paths
> > tep_peek_char
> > tep_buffer_init
> > tep_get_input_buf_ptr
> > tep_get_input_buf
> > tep_read_token
> > tep_free_token
> > tep_free_event
> > tep_free_format_field
> > __tep_parse_format
> >
> > Link: https://lore.kernel.org/linux-trace-devel/e4afdd82deb5e023d53231bb13e08dca78085fb0.camel@decadent.org.uk/
> > Reported-by: Ben Hutchings <ben@decadent.org.uk>
> > Signed-off-by: Tzvetomir Stoyanov (VMware) <tz.stoyanov@gmail.com>
> > ---
>
> Reviewed-by: Steven Rostedt (VMware) <rostedt@goodmis.org>
>
> Arnaldo,
>
> Can you pull this in?
Sure, I was just waiting for this to get to some conclusion.
- Arnaldo
prev parent reply other threads:[~2020-10-01 1:33 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-09-30 11:07 [PATCH v4] tools lib traceevent: Hide non API functions Tzvetomir Stoyanov (VMware)
2020-09-30 16:50 ` Steven Rostedt
2020-10-01 1:33 ` Arnaldo Carvalho de Melo [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201001013349.GB3169811@kernel.org \
--to=acme@kernel.org \
--cc=arnaldo.melo@gmail.com \
--cc=ben@decadent.org.uk \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-trace-devel@vger.kernel.org \
--cc=rostedt@goodmis.org \
--cc=tz.stoyanov@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.