From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-13.0 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 28215C4727F for ; Thu, 1 Oct 2020 09:41:09 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id C0D492087D for ; Thu, 1 Oct 2020 09:41:08 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="KF7VYn5D"; dkim=fail reason="signature verification failed" (1024-bit key) header.d=kernel.org header.i=@kernel.org header.b="PaZ6b2e8" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org C0D492087D Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:MIME-Version:Message-Id:Date:Subject:To:From: Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender :Resent-To:Resent-Cc:Resent-Message-ID:In-Reply-To:References:List-Owner; bh=UcOO8MqVWPNj6ZVFFLM8zMVH7bf/B4tcu5oGQddcc6s=; b=KF7VYn5DY77hzQU9Nt8JhVZYXN 33Vj1bIF11sy63vNEFJm8LGsh9Yb5z+x/NU/SiGGtWH93Pl38M+vOnp5oRSQwqQNYIhyB1YPFXvKY F/FEdH1qTzvZGWJiWZ6dtwSnojLOwclLccvoXFxZSbdEIKjYE8MFt74vvjiF5IrrUFo9149r3r8zz BUIX67YeBLaKdL2Ke5ULUTVWP5uFOiDKFNUGipfy0bP6dR/nhc0CN4eCFfFMA7+GYo+E0iWwQgOEE hQYjxQ99ihU6ISqJ5egGi0aRtLalDe6SGmwfFvtj7wtraHdWMZ3MmzYiwkYIYYIVDrA0luAR1LLHO 0fxATUeA==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1kNv3g-0006uQ-A2; Thu, 01 Oct 2020 09:39:28 +0000 Received: from mail.kernel.org ([198.145.29.99]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1kNv3e-0006tq-NE for linux-arm-kernel@lists.infradead.org; Thu, 01 Oct 2020 09:39:27 +0000 Received: from localhost.localdomain (236.31.169.217.in-addr.arpa [217.169.31.236]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 463BA2087D; Thu, 1 Oct 2020 09:39:24 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1601545165; bh=ci/0HdqOUybdH70kAtS3i32LCFKG/Yb4a+jd19E/qbY=; h=From:To:Cc:Subject:Date:From; b=PaZ6b2e8rjx1wYzwcHwnUr3feYwPEjkXLkdWbns409taOfGtYu+cPdzE3+YIQpdPs pbzQS27ciiTTQYAeRqE+wJ6CkYPsJdXu8z16xyg3lGRSdKEzthEauT1W8a/6Hm70Jf K+RGT8vtdbmjlybLSlW/JM1IePGaLbm3IfyZEKJs= From: Will Deacon To: linux-arm-kernel@lists.infradead.org Subject: [PATCH] arm64: dbm: Invalidate local TLB when setting TCR_EL1.HD Date: Thu, 1 Oct 2020 10:39:20 +0100 Message-Id: <20201001093920.18260-1-will@kernel.org> X-Mailer: git-send-email 2.20.1 MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20201001_053926_838308_23F17A51 X-CRM114-Status: GOOD ( 15.24 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Catalin Marinas , Will Deacon Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org TCR_EL1.HD is permitted to be cached in a TLB, so invalidate the local TLB after setting the bit when detected support for the feature. Although this isn't strictly necessary, since we can happily operate with the bit effectively clear, the current code uses an ISB in a half-hearted attempt to make the change effective, so let's just fix that up. Cc: Catalin Marinas Signed-off-by: Will Deacon --- arch/arm64/kernel/cpufeature.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/arch/arm64/kernel/cpufeature.c b/arch/arm64/kernel/cpufeature.c index 6424584be01e..29de76046977 100644 --- a/arch/arm64/kernel/cpufeature.c +++ b/arch/arm64/kernel/cpufeature.c @@ -1442,7 +1442,7 @@ static inline void __cpu_enable_hw_dbm(void) u64 tcr = read_sysreg(tcr_el1) | TCR_HD; write_sysreg(tcr, tcr_el1); - isb(); + local_flush_tlb_all(); } static bool cpu_has_broken_dbm(void) -- 2.28.0.709.gb0816b6eb0-goog _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel