From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.8 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE, SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 63116C4727C for ; Thu, 1 Oct 2020 13:43:22 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 2C4DE206FC for ; Thu, 1 Oct 2020 13:43:22 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1732229AbgJANnS (ORCPT ); Thu, 1 Oct 2020 09:43:18 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:50826 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1732178AbgJANnS (ORCPT ); Thu, 1 Oct 2020 09:43:18 -0400 Received: from ZenIV.linux.org.uk (zeniv.linux.org.uk [IPv6:2002:c35c:fd02::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 83D7FC0613D0; Thu, 1 Oct 2020 06:43:18 -0700 (PDT) Received: from viro by ZenIV.linux.org.uk with local (Exim 4.92.3 #3 (Red Hat Linux)) id 1kNyrd-009rLc-2e; Thu, 01 Oct 2020 13:43:17 +0000 Date: Thu, 1 Oct 2020 14:43:17 +0100 From: Al Viro To: Qian Cai Cc: David Howells , linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v3] pipe: Fix memory leaks in create_pipe_files() Message-ID: <20201001134317.GF3421308@ZenIV.linux.org.uk> References: <20201001125055.5042-1-cai@redhat.com> <20201001131659.GE3421308@ZenIV.linux.org.uk> <68ab61d0ba3a6ddd7838bc293c9e24f5d8002e27.camel@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <68ab61d0ba3a6ddd7838bc293c9e24f5d8002e27.camel@redhat.com> Sender: Al Viro Precedence: bulk List-ID: X-Mailing-List: linux-fsdevel@vger.kernel.org On Thu, Oct 01, 2020 at 09:37:02AM -0400, Qian Cai wrote: > > Fixed by providing a dummy wath_queue_init() in !CONFIG_WATCH_QUEUE watch_queue_init(), that is > > case and by having failures of wath_queue_init() handled the same way ditto > > we handle alloc_file_pseudo() ones. > > > > Fixes: c73be61cede5 ("pipe: Add general notification queue support") > > Signed-off-by: Qian Cai > > ======================= > > Thanks Al. This looks very good to me. Applied with that commit message (and typos above corrected) to #fixes and pushed