From: "Theodore Y. Ts'o" <tytso@mit.edu>
To: Andreas Dilger <adilger@dilger.ca>
Cc: linux-ext4@vger.kernel.org, Andreas Dilger <adilger@whamcloud.com>
Subject: Re: [PATCH] tune2fs: reset MMP state on error exit
Date: Thu, 1 Oct 2020 10:26:37 -0400 [thread overview]
Message-ID: <20201001142637.GG23474@mit.edu> (raw)
In-Reply-To: <20200617114049.93821-1-adilger@dilger.ca>
On Wed, Jun 17, 2020 at 05:40:49AM -0600, Andreas Dilger wrote:
> From: Andreas Dilger <adilger@whamcloud.com>
>
> If tune2fs cannot perform the requested change, ensure that the MMP
> block is reset to the unused state before exiting. Otherwise, the
> filesystem will be left with mmp_seq = EXT4_MMP_SEQ_FSCK set, which
> prevents it from being mounted afterward:
>
> EXT4-fs warning (device dm-9): ext4_multi_mount_protect:311:
> fsck is running on the filesystem
>
> Add a test to try some failed tune2fs operations and verify that the
> MMP block is left in a clean state afterward.
>
> Lustre-bug-id: https://jira.whamcloud.com/browse/LU-13672
> Signed-off-by: Andreas Dilger <adilger@whamcloud.com>
Applied, thanks.
- Ted
prev parent reply other threads:[~2020-10-01 14:26 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-06-17 11:40 [PATCH] tune2fs: reset MMP state on error exit Andreas Dilger
2020-10-01 14:26 ` Theodore Y. Ts'o [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201001142637.GG23474@mit.edu \
--to=tytso@mit.edu \
--cc=adilger@dilger.ca \
--cc=adilger@whamcloud.com \
--cc=linux-ext4@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.