From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.7 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id AA18DC4727C for ; Thu, 1 Oct 2020 14:26:42 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 7DAB5207FB for ; Thu, 1 Oct 2020 14:26:42 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1732213AbgJAO0m (ORCPT ); Thu, 1 Oct 2020 10:26:42 -0400 Received: from outgoing-auth-1.mit.edu ([18.9.28.11]:50850 "EHLO outgoing.mit.edu" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1732099AbgJAO0m (ORCPT ); Thu, 1 Oct 2020 10:26:42 -0400 Received: from callcc.thunk.org (pool-72-74-133-215.bstnma.fios.verizon.net [72.74.133.215]) (authenticated bits=0) (User authenticated as tytso@ATHENA.MIT.EDU) by outgoing.mit.edu (8.14.7/8.12.4) with ESMTP id 091EQbh6029126 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Thu, 1 Oct 2020 10:26:38 -0400 Received: by callcc.thunk.org (Postfix, from userid 15806) id A46AA42003C; Thu, 1 Oct 2020 10:26:37 -0400 (EDT) Date: Thu, 1 Oct 2020 10:26:37 -0400 From: "Theodore Y. Ts'o" To: Andreas Dilger Cc: linux-ext4@vger.kernel.org, Andreas Dilger Subject: Re: [PATCH] tune2fs: reset MMP state on error exit Message-ID: <20201001142637.GG23474@mit.edu> References: <20200617114049.93821-1-adilger@dilger.ca> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200617114049.93821-1-adilger@dilger.ca> Precedence: bulk List-ID: X-Mailing-List: linux-ext4@vger.kernel.org On Wed, Jun 17, 2020 at 05:40:49AM -0600, Andreas Dilger wrote: > From: Andreas Dilger > > If tune2fs cannot perform the requested change, ensure that the MMP > block is reset to the unused state before exiting. Otherwise, the > filesystem will be left with mmp_seq = EXT4_MMP_SEQ_FSCK set, which > prevents it from being mounted afterward: > > EXT4-fs warning (device dm-9): ext4_multi_mount_protect:311: > fsck is running on the filesystem > > Add a test to try some failed tune2fs operations and verify that the > MMP block is left in a clean state afterward. > > Lustre-bug-id: https://jira.whamcloud.com/browse/LU-13672 > Signed-off-by: Andreas Dilger Applied, thanks. - Ted