From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.1 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id EC163C4727C for ; Thu, 1 Oct 2020 14:42:56 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id AD8A9207FB for ; Thu, 1 Oct 2020 14:42:56 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1601563376; bh=ZQziUgppnvjdBIHDd9I0yU4UKdsjTr0ONLsGApQyUxY=; h=Date:From:To:Cc:Subject:References:In-Reply-To:List-ID:From; b=EYT0aHi6qXgVh7LiN+/fstg3W1Ag4lIz1ZViaTZnZ82AYsH3PLsSX7T3VxiwZRqC8 DsfrT9Vj+DQYM36VVxbvT9wwr32DWURFN1Bb0guwcr6YAKjpDVszMF45lC3AwkkPxb jolf8CFNmK40F0zHBP44rLzkSYbtLQ6TKiTj72OE= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1732147AbgJAOm4 (ORCPT ); Thu, 1 Oct 2020 10:42:56 -0400 Received: from mail-oi1-f196.google.com ([209.85.167.196]:43735 "EHLO mail-oi1-f196.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1732020AbgJAOm4 (ORCPT ); Thu, 1 Oct 2020 10:42:56 -0400 Received: by mail-oi1-f196.google.com with SMTP id i17so5805194oig.10 for ; Thu, 01 Oct 2020 07:42:55 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:content-transfer-encoding :in-reply-to; bh=0204NW6ER5exEU55fNd1mRlRwGnFW2TRYfVBPjMBJIE=; b=dop2KfegvQbt4BwVD/Fqy/F+7p0vjgcAx1SitT4OGIAH1dhe0Odgv0w2jELCiDFRJZ n0kzHykluKBwkZ/VXJ+Bgc2aMdagQGZv6gO7J89oLhQI+2y3/cN0h0jcG0NI5sDg9hDJ 1zpCfqpDLwA8lxGHRABNxcav/0XKWWBT0VANvDLGicUQWCdK4iBI6elEkN1Mtry+gxPT ja/8H+nhGG0HDr9wO67TB5z31KILy6x99ZL2LZgriQnVCj1trPTywyz+hR0bpgLdfumY nywfgjcomWePaozJONNrueQd7B5U54w4oiFsdXCO7jmIxf4QwTP2shiMF0IW3nLOm/ub Iq0g== X-Gm-Message-State: AOAM533tKl6oT6KcqUMnvpxH/04Z/Pd00biWHhamlEJ2333rna/l0q7Z E1q5yPXMJMZdxGY32Z8Fdg== X-Google-Smtp-Source: ABdhPJzUHjqh43Bmrgr/HhR+8aqng4ADr49hmNuJ5ZQR4ufyX79gcbYCEnEZ3VeJu9yTgfbNy3bwkw== X-Received: by 2002:aca:654b:: with SMTP id j11mr189497oiw.77.1601563375158; Thu, 01 Oct 2020 07:42:55 -0700 (PDT) Received: from xps15 (24-155-109-49.dyn.grandenetworks.net. [24.155.109.49]) by smtp.gmail.com with ESMTPSA id 68sm298363otu.33.2020.10.01.07.42.54 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 01 Oct 2020 07:42:54 -0700 (PDT) Received: (nullmailer pid 709304 invoked by uid 1000); Thu, 01 Oct 2020 14:42:53 -0000 Date: Thu, 1 Oct 2020 09:42:53 -0500 From: Rob Herring To: Krzysztof =?utf-8?Q?Wilczy=C5=84ski?= Cc: linux-arm-kernel@lists.infradead.org, linux-pci@vger.kernel.org, Duc Dang , Bjorn Helgaas , Toan Le , Lorenzo Pieralisi Subject: Re: [PATCH] PCI: xgene: Remove unused assignment to variable msi_val Message-ID: <20201001144253.GA709251@bogus> References: <20200922030257.459898-1-kw@linux.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20200922030257.459898-1-kw@linux.com> Precedence: bulk List-ID: X-Mailing-List: linux-pci@vger.kernel.org On Tue, 22 Sep 2020 03:02:57 +0000, Krzysztof Wilczyński wrote: > The value assigned to msi_val after the inner loop finishes its run is > never used for anything, and it is also immediately overridden in the > line that follows with the return value from the xgene_msi_int_read() > function. > > Since the value of msi_val following the inner loop completion is never > used in any meaningful way the assignment can be removed. > > Addresses-Coverity-ID: 1437183 ("Unused value") > Signed-off-by: Krzysztof Wilczyński > --- > drivers/pci/controller/pci-xgene-msi.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > Reviewed-by: Rob Herring From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.0 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id E6D3DC4727C for ; Thu, 1 Oct 2020 14:44:12 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 862A620780 for ; Thu, 1 Oct 2020 14:44:12 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="Uoid2RMT" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 862A620780 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References:Message-ID: Subject:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=lSsAQK0LQaUrHxer9atQlIfj4rsiL1zAEXnxjQqImYY=; b=Uoid2RMTS1N9AfBFIhmlF7JRg hW8x+6mAJWbOsm+wG0zA+Xv34mzIKF3prqalUpnw3l/R0Q3q4Nq/851MuyrIW64WY2W45+pygkFmx kbXw5VfIJyQvZYNZsFCgihubv5S6TARYU+Pj0z51SFBUFvK2gEKuffNIV4Nf2xlR8kkw1UhNy2jGb hE8iAVaYWQfp00pxaNq7nbx/WulZ5onAZfLJdX2Fvnpsoeb/gyDmpmPvDuL0sJaH+aefqJdoyUVGS 3N3usXcT/m/XQmRPM0mVG3rJzjrJZSC0o4X/67BPy4o/Mm9D2Hevj2ZvH1uSKuA6ja7j5TTDlBM/m g5QWy/XQA==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1kNznS-0001Yr-VW; Thu, 01 Oct 2020 14:43:03 +0000 Received: from mail-oi1-f196.google.com ([209.85.167.196]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1kNznQ-0001Y2-Ml for linux-arm-kernel@lists.infradead.org; Thu, 01 Oct 2020 14:43:01 +0000 Received: by mail-oi1-f196.google.com with SMTP id x14so5797060oic.9 for ; Thu, 01 Oct 2020 07:42:55 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:content-transfer-encoding :in-reply-to; bh=0204NW6ER5exEU55fNd1mRlRwGnFW2TRYfVBPjMBJIE=; b=lMOPS3Ufd8w8d8X8MF4LVbKrroGh4wfdlCqQlrkkp8ZuUm3jQmjS95EwVwJYhsbBsG lp7k35WvLRiYOWWtMOS6D3vIkpdiBGDV32WKY5IkB75xAGvFPJqA5bain8qKNTexhVGj VlDIlmn8B4KM5A5Boh3LWGt9muLsTgIK9RU+sz7Y+hipxSfnMgdVxLn6A7T9Yq4Yrjrl 3F1wwFCMhaPNzHRKqL3adIY/g6DoQIO1CXDYkDra4CiSOzjhdXUcuA5yrrkEA1VAjMlq crnw+uLeG9GRKaslzhU6OoHD+N1RgC+ztMqrRyyf+ANMyf2C6hQxTvcwoha2MGupbQLt h7fw== X-Gm-Message-State: AOAM531jxNbHDtWItI+VeVYXoghMnhgUh+2V1DubcK97SCmyWrUN+jby ci4pXxG1k6MRe5VoFuN80PkSmlr8tx1X X-Google-Smtp-Source: ABdhPJzUHjqh43Bmrgr/HhR+8aqng4ADr49hmNuJ5ZQR4ufyX79gcbYCEnEZ3VeJu9yTgfbNy3bwkw== X-Received: by 2002:aca:654b:: with SMTP id j11mr189497oiw.77.1601563375158; Thu, 01 Oct 2020 07:42:55 -0700 (PDT) Received: from xps15 (24-155-109-49.dyn.grandenetworks.net. [24.155.109.49]) by smtp.gmail.com with ESMTPSA id 68sm298363otu.33.2020.10.01.07.42.54 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 01 Oct 2020 07:42:54 -0700 (PDT) Received: (nullmailer pid 709304 invoked by uid 1000); Thu, 01 Oct 2020 14:42:53 -0000 Date: Thu, 1 Oct 2020 09:42:53 -0500 From: Rob Herring To: Krzysztof =?utf-8?Q?Wilczy=C5=84ski?= Subject: Re: [PATCH] PCI: xgene: Remove unused assignment to variable msi_val Message-ID: <20201001144253.GA709251@bogus> References: <20200922030257.459898-1-kw@linux.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20200922030257.459898-1-kw@linux.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20201001_104300_765171_A58C6E0F X-CRM114-Status: GOOD ( 15.35 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Lorenzo Pieralisi , linux-pci@vger.kernel.org, Duc Dang , Bjorn Helgaas , Toan Le , linux-arm-kernel@lists.infradead.org Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org T24gVHVlLCAyMiBTZXAgMjAyMCAwMzowMjo1NyArMDAwMCwgS3J6eXN6dG9mIFdpbGN6ecWEc2tp IHdyb3RlOgo+IFRoZSB2YWx1ZSBhc3NpZ25lZCB0byBtc2lfdmFsIGFmdGVyIHRoZSBpbm5lciBs b29wIGZpbmlzaGVzIGl0cyBydW4gaXMKPiBuZXZlciB1c2VkIGZvciBhbnl0aGluZywgYW5kIGl0 IGlzIGFsc28gaW1tZWRpYXRlbHkgb3ZlcnJpZGRlbiBpbiB0aGUKPiBsaW5lIHRoYXQgZm9sbG93 cyB3aXRoIHRoZSByZXR1cm4gdmFsdWUgZnJvbSB0aGUgeGdlbmVfbXNpX2ludF9yZWFkKCkKPiBm dW5jdGlvbi4KPiAKPiBTaW5jZSB0aGUgdmFsdWUgb2YgbXNpX3ZhbCBmb2xsb3dpbmcgdGhlIGlu bmVyIGxvb3AgY29tcGxldGlvbiBpcyBuZXZlcgo+IHVzZWQgaW4gYW55IG1lYW5pbmdmdWwgd2F5 IHRoZSBhc3NpZ25tZW50IGNhbiBiZSByZW1vdmVkLgo+IAo+IEFkZHJlc3Nlcy1Db3Zlcml0eS1J RDogMTQzNzE4MyAoIlVudXNlZCB2YWx1ZSIpCj4gU2lnbmVkLW9mZi1ieTogS3J6eXN6dG9mIFdp bGN6ecWEc2tpIDxrd0BsaW51eC5jb20+Cj4gLS0tCj4gIGRyaXZlcnMvcGNpL2NvbnRyb2xsZXIv cGNpLXhnZW5lLW1zaS5jIHwgNCArKy0tCj4gIDEgZmlsZSBjaGFuZ2VkLCAyIGluc2VydGlvbnMo KyksIDIgZGVsZXRpb25zKC0pCj4gCgpSZXZpZXdlZC1ieTogUm9iIEhlcnJpbmcgPHJvYmhAa2Vy bmVsLm9yZz4KCl9fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f CmxpbnV4LWFybS1rZXJuZWwgbWFpbGluZyBsaXN0CmxpbnV4LWFybS1rZXJuZWxAbGlzdHMuaW5m cmFkZWFkLm9yZwpodHRwOi8vbGlzdHMuaW5mcmFkZWFkLm9yZy9tYWlsbWFuL2xpc3RpbmZvL2xp bnV4LWFybS1rZXJuZWwK