From: "Theodore Y. Ts'o" <tytso@mit.edu>
To: Andreas Dilger <adilger@dilger.ca>
Cc: linux-ext4@vger.kernel.org
Subject: Re: [PATCH] tests: replace perl usage with shell built-in
Date: Thu, 1 Oct 2020 13:08:17 -0400 [thread overview]
Message-ID: <20201001170817.GL23474@mit.edu> (raw)
In-Reply-To: <20201001145809.GA584291@mit.edu>
On Thu, Oct 01, 2020 at 10:58:09AM -0400, Theodore Y. Ts'o wrote:
> On Sun, Jul 19, 2020 at 05:00:33AM -0600, Andreas Dilger wrote:
> > A couple of tests use perl only for generating a string of
> > N characters long. Instead of requiring perl to run a few
> > tests, use shell built-in commands and don't repeatedly run
> > a separate subshell just to get a string of characters.
> > h
> > Signed-off-by: Andreas Dilger <adilger@dilger.ca>
>
> Thanks, applied.
.... and I have to revert the patch. It's using a non-standard shell
construction which fails on strict POSIX compliant shells, such as
dash.
- Ted
next prev parent reply other threads:[~2020-10-01 17:08 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-07-19 11:00 [PATCH] tests: replace perl usage with shell built-in Andreas Dilger
2020-10-01 14:58 ` Theodore Y. Ts'o
2020-10-01 17:08 ` Theodore Y. Ts'o [this message]
2020-10-02 2:05 ` Andreas Dilger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201001170817.GL23474@mit.edu \
--to=tytso@mit.edu \
--cc=adilger@dilger.ca \
--cc=linux-ext4@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.