All of lore.kernel.org
 help / color / mirror / Atom feed
From: David Teigland <teigland@sourceware.org>
To: lvm-devel@redhat.com
Subject: master - improve message for invalid device arg
Date: Thu,  1 Oct 2020 17:20:48 +0000 (GMT)	[thread overview]
Message-ID: <20201001172048.913403857C41@sourceware.org> (raw)

Gitweb:        https://sourceware.org/git/?p=lvm2.git;a=commitdiff;h=74ed6e8a9969bb7d20c21f88b53e6134d81eab1d
Commit:        74ed6e8a9969bb7d20c21f88b53e6134d81eab1d
Parent:        450f272b31ef95bd7cb61812d9ef0525c7c1c341
Author:        David Teigland <teigland@redhat.com>
AuthorDate:    Thu Oct 1 12:19:27 2020 -0500
Committer:     David Teigland <teigland@redhat.com>
CommitterDate: Thu Oct 1 12:20:16 2020 -0500

improve message for invalid device arg

for pvcreate, pvremove, vgcreate, vgextend.
---
 tools/toollib.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/tools/toollib.c b/tools/toollib.c
index 1814399b9..f6879745b 100644
--- a/tools/toollib.c
+++ b/tools/toollib.c
@@ -5248,7 +5248,7 @@ int pvcreate_each_device(struct cmd_context *cmd,
 	dm_list_iterate_items_safe(pd, pd2, &pp->arg_devices) {
 		pd->dev = dev_cache_get(cmd, pd->name, cmd->filter);
 		if (!pd->dev) {
-			log_error("Device %s not found.", pd->name);
+			log_error("Cannot use %s: %s", pd->name, devname_error_reason(pd->name));
 			dm_list_del(&pd->list);
 			dm_list_add(&pp->arg_fail, &pd->list);
 		}



                 reply	other threads:[~2020-10-01 17:20 UTC|newest]

Thread overview: [no followups] expand[flat|nested]  mbox.gz  Atom feed

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20201001172048.913403857C41@sourceware.org \
    --to=teigland@sourceware.org \
    --cc=lvm-devel@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.