From: David Teigland <teigland@sourceware.org>
To: lvm-devel@redhat.com
Subject: master - improve message for invalid device arg in process_each_pv
Date: Thu, 1 Oct 2020 17:36:48 +0000 (GMT) [thread overview]
Message-ID: <20201001173648.7F2603857C41@sourceware.org> (raw)
Gitweb: https://sourceware.org/git/?p=lvm2.git;a=commitdiff;h=0143c7aebe2389ceada6ca0a314a3ff0fd9cdfef
Commit: 0143c7aebe2389ceada6ca0a314a3ff0fd9cdfef
Parent: 74ed6e8a9969bb7d20c21f88b53e6134d81eab1d
Author: David Teigland <teigland@redhat.com>
AuthorDate: Thu Oct 1 12:34:36 2020 -0500
Committer: David Teigland <teigland@redhat.com>
CommitterDate: Thu Oct 1 12:34:36 2020 -0500
improve message for invalid device arg in process_each_pv
Multiple commands process pvs by name using process_each_pv()
and will now have an improved error message for a device
that's excluded by filters.
---
tools/toollib.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/tools/toollib.c b/tools/toollib.c
index f6879745b..f2372e095 100644
--- a/tools/toollib.c
+++ b/tools/toollib.c
@@ -3839,7 +3839,7 @@ static int _get_arg_devices(struct cmd_context *cmd,
}
if (!(dil->dev = dev_cache_get(cmd, sl->str, cmd->filter))) {
- log_error("Failed to find device for physical volume \"%s\".", sl->str);
+ log_error("Cannot use %s: %s", sl->str, devname_error_reason(sl->str));
ret_max = ECMD_FAILED;
} else {
strncpy(dil->pvid, dil->dev->pvid, ID_LEN);
reply other threads:[~2020-10-01 17:36 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201001173648.7F2603857C41@sourceware.org \
--to=teigland@sourceware.org \
--cc=lvm-devel@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.