From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.6 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 078B1C47423 for ; Thu, 1 Oct 2020 19:03:06 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 9CA15208A9 for ; Thu, 1 Oct 2020 19:03:05 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1601578985; bh=r3hzfdLTNgCneOouEZfr5T3nicxtJYS1kg2mr0GikQc=; h=Date:From:To:Cc:Subject:References:In-Reply-To:List-ID:From; b=hFs+HHqoU511V6QhskqgZonKUwEqT/mXKrY+u6bbubc5WdS0/2mcxWGv1s5SCauvq OXXyJetnMUQ04GTzcjN/OiDEIAJuXPswYjH4qR3fMe3HOmvaMt7JKXpHd83vFoC4mG GjvjOQfHJSY2w6XrdFZoFhUkQoJYGpPopWevHeTc= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1732829AbgJATDF convert rfc822-to-8bit (ORCPT ); Thu, 1 Oct 2020 15:03:05 -0400 Received: from mail-ej1-f67.google.com ([209.85.218.67]:36439 "EHLO mail-ej1-f67.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1729418AbgJATDE (ORCPT ); Thu, 1 Oct 2020 15:03:04 -0400 Received: by mail-ej1-f67.google.com with SMTP id qp15so8738306ejb.3; Thu, 01 Oct 2020 12:03:01 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:content-transfer-encoding :in-reply-to:user-agent; bh=QlsQhAx8VcoMU7dV3V3+HZkVbJgpPbjjv2CFsBU0+FM=; b=YtApYRsP/VX55+FIl7qwgQLzMnlPtiXghfEzyxBlV7NL0JY/sGzO2dIcfuL/kS/6JZ mvJkHJ5cU4+9zN4HzdlXIaFIHMOps4VYrEb48/umrRj2rUA2NDYqZUfR0ynE3KH6Vn7A 457S6qO4BpDLiNj0HeiSFAZJojm+uFwSR181QIyxTZzF3nES9yqsHBcMqp/B/+b+WyQH 7ytj5D8nLEEdppIIXPjR9EMchUZ7CL73Kk2lux3f06Hn0S5ePOR2zqp8Qjr6zjCI+PcV cydHkja/CrDmkY3+er1zp5qDLkRlMyH/jvSsyre2vZ/QFA1OEWEg2oLtxj8Kd3r8uzr6 TnXQ== X-Gm-Message-State: AOAM533s61dFMG97UXL5gn/gtd3UhXrfhXhouw95SXh0iPqn6Ap9GOKz box05W3Rbxca2eKntnKIgTU= X-Google-Smtp-Source: ABdhPJwsZ1HHAGL3BP39ZVnfdMPs0Y2DJohS6bL0m7Sdcm1Uzv9RKqktA42we/OUm8J/rSSGH4TqcA== X-Received: by 2002:a17:906:1f43:: with SMTP id d3mr9739989ejk.395.1601578981194; Thu, 01 Oct 2020 12:03:01 -0700 (PDT) Received: from kozik-lap ([194.230.155.194]) by smtp.googlemail.com with ESMTPSA id r13sm4824687edo.48.2020.10.01.12.02.58 (version=TLS1_2 cipher=ECDHE-ECDSA-CHACHA20-POLY1305 bits=256/256); Thu, 01 Oct 2020 12:02:59 -0700 (PDT) Date: Thu, 1 Oct 2020 21:02:57 +0200 From: Krzysztof Kozlowski To: Lukasz Stelmach Cc: Mark Brown , Tomasz Figa , Kukjin Kim , Andi Shyti , linux-spi@vger.kernel.org, linux-samsung-soc@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, m.szyprowski@samsung.com, b.zolnierkie@samsung.com Subject: Re: [PATCH v2 RESEND 0/9] Some fixes for spi-s3c64xx Message-ID: <20201001190257.GA11048@kozik-lap> References: <20201001161340.GM6715@sirena.org.uk> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8BIT In-Reply-To: User-Agent: Mutt/1.9.4 (2018-02-28) Precedence: bulk List-ID: X-Mailing-List: linux-samsung-soc@vger.kernel.org On Thu, Oct 01, 2020 at 08:23:00PM +0200, Lukasz Stelmach wrote: > It was <2020-10-01 czw 17:13>, when Mark Brown wrote: > > On Thu, Oct 01, 2020 at 05:21:39PM +0200, Łukasz Stelmach wrote: > >> This is a series of fixes created during porting a device driver (these > >> patches will be released soon too) for an SPI device to the current kernel. > > > > There appeared to be a number of outstanding review comments (misleading > > commit message on patch 7, some concerns about the non-CMU case), please > > address those. > > We discussed with Tomasz Figa and Krzysztof Kozłowski off the list that > this is practically unused. Tomasz, Krzysztof, would you be so kind to > share the details? That is correct. We did not provide final comments on the list so they could be added here - in change log. This would also be an explanation why there is a resend. Another solution would be to extend the commit #7 description - why only CMU case is covered. About patch #7: The decision was not to correct non-CMU case because there were not actual reports about clock rounding poblems, it would not be trivial change and we do not have the HW to test. Thanks Mark for looking into it. Best regards, Krzysztof From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.5 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3D28AC4727E for ; Thu, 1 Oct 2020 19:04:47 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id C751D208A9 for ; Thu, 1 Oct 2020 19:04:46 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="vaZXla/q" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org C751D208A9 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References:Message-ID: Subject:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=IHdIJYOs8Ny9s/fExRXWPUe4Hq/SXljIBHfurty6pMA=; b=vaZXla/q5CSfq+r8ENCeNWuyx 58dHR6TXTYkQLMySac8P7ndbYMkwxkaPCP1cXuplGg+oPh/delOZ18GRJ/D+EQNFs7FSaw4dTampq /IoTpQHNvujnqzlVX80kk4fAJMMi5JKBS7VO5fOhOgBKv0JYepTmEgB4NV/Q9dvCBglIsOYAvuIpJ R80GYLvG2/rJNDM/mGpDiRenuNpIdPyvlONv8+Nkz765WT8oHxJLYExdqt0lZlFRxJ6oA2SHGQ91h 66FprwZ6YS3D4hlDOK5kFHn0q9EyhImQU8HxBrnvrhie3hHSB9T6cQoU2cv3pt59DURUnaw3IyVUe Q3gmGqzJA==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1kO3r7-00006k-Bx; Thu, 01 Oct 2020 19:03:05 +0000 Received: from mail-ej1-f65.google.com ([209.85.218.65]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1kO3r4-00005z-CS for linux-arm-kernel@lists.infradead.org; Thu, 01 Oct 2020 19:03:03 +0000 Received: by mail-ej1-f65.google.com with SMTP id p15so9639453ejm.7 for ; Thu, 01 Oct 2020 12:03:02 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:content-transfer-encoding :in-reply-to:user-agent; bh=QlsQhAx8VcoMU7dV3V3+HZkVbJgpPbjjv2CFsBU0+FM=; b=dh9NAxMfd0iUK8j+VDC7VrL33/qLK73HIDBRljQxigmv3EZhdU6DC4wlKmYMPBV0p9 yN/rGyuaX5wSNNU3G2JT2C/i0mqsMYYpxrL6OcNxxc7cpdyGgTKMGU/jbY0cUCizffxJ CyDBTTceol4Fu8uShFvfhL2YyvGyDI0FTp2zs/KuZszI7zGZF2DmH4+z6HlH1oVxZMB2 spU3aBtX4j2KEvav1QbhjgrPo6iallFCHZf5DaTVhQ66h/eAVA8QZT/luQKcA0EI1lc3 Lo4KJ4RkzCn8LTQHW/FCOM3Rc+I087fMjlDkekvCokqdxd7HmFkITnT74wkAPuIKMcjL OfLQ== X-Gm-Message-State: AOAM533cxB7aNtEGpvG0Pz9OQZO+ghR5DUCm457vZG72PlZteerCBiOw py0/iXIaRPJWRGxvJ9iDl0E= X-Google-Smtp-Source: ABdhPJwsZ1HHAGL3BP39ZVnfdMPs0Y2DJohS6bL0m7Sdcm1Uzv9RKqktA42we/OUm8J/rSSGH4TqcA== X-Received: by 2002:a17:906:1f43:: with SMTP id d3mr9739989ejk.395.1601578981194; Thu, 01 Oct 2020 12:03:01 -0700 (PDT) Received: from kozik-lap ([194.230.155.194]) by smtp.googlemail.com with ESMTPSA id r13sm4824687edo.48.2020.10.01.12.02.58 (version=TLS1_2 cipher=ECDHE-ECDSA-CHACHA20-POLY1305 bits=256/256); Thu, 01 Oct 2020 12:02:59 -0700 (PDT) Date: Thu, 1 Oct 2020 21:02:57 +0200 From: Krzysztof Kozlowski To: Lukasz Stelmach Subject: Re: [PATCH v2 RESEND 0/9] Some fixes for spi-s3c64xx Message-ID: <20201001190257.GA11048@kozik-lap> References: <20201001161340.GM6715@sirena.org.uk> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.9.4 (2018-02-28) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20201001_150302_422806_077B805B X-CRM114-Status: GOOD ( 18.26 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: linux-samsung-soc@vger.kernel.org, b.zolnierkie@samsung.com, linux-kernel@vger.kernel.org, Mark Brown , Tomasz Figa , linux-spi@vger.kernel.org, Kukjin Kim , Andi Shyti , linux-arm-kernel@lists.infradead.org, m.szyprowski@samsung.com Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org T24gVGh1LCBPY3QgMDEsIDIwMjAgYXQgMDg6MjM6MDBQTSArMDIwMCwgTHVrYXN6IFN0ZWxtYWNo IHdyb3RlOgo+IEl0IHdhcyA8MjAyMC0xMC0wMSBjencgMTc6MTM+LCB3aGVuIE1hcmsgQnJvd24g d3JvdGU6Cj4gPiBPbiBUaHUsIE9jdCAwMSwgMjAyMCBhdCAwNToyMTozOVBNICswMjAwLCDFgXVr YXN6IFN0ZWxtYWNoIHdyb3RlOgo+ID4+IFRoaXMgaXMgYSBzZXJpZXMgb2YgZml4ZXMgY3JlYXRl ZCBkdXJpbmcgcG9ydGluZyBhIGRldmljZSBkcml2ZXIgKHRoZXNlCj4gPj4gcGF0Y2hlcyB3aWxs IGJlIHJlbGVhc2VkIHNvb24gdG9vKSBmb3IgYW4gU1BJIGRldmljZSB0byB0aGUgY3VycmVudCBr ZXJuZWwuCj4gPgo+ID4gVGhlcmUgYXBwZWFyZWQgdG8gYmUgYSBudW1iZXIgb2Ygb3V0c3RhbmRp bmcgcmV2aWV3IGNvbW1lbnRzIChtaXNsZWFkaW5nCj4gPiBjb21taXQgbWVzc2FnZSBvbiBwYXRj aCA3LCBzb21lIGNvbmNlcm5zIGFib3V0IHRoZSBub24tQ01VIGNhc2UpLCBwbGVhc2UKPiA+IGFk ZHJlc3MgdGhvc2UuCj4gCj4gV2UgZGlzY3Vzc2VkIHdpdGggVG9tYXN6IEZpZ2EgYW5kIEtyenlz enRvZiBLb3rFgm93c2tpIG9mZiB0aGUgbGlzdCB0aGF0Cj4gdGhpcyBpcyBwcmFjdGljYWxseSB1 bnVzZWQuIFRvbWFzeiwgS3J6eXN6dG9mLCB3b3VsZCB5b3UgYmUgc28ga2luZCB0bwo+IHNoYXJl IHRoZSBkZXRhaWxzPwoKVGhhdCBpcyBjb3JyZWN0LiBXZSBkaWQgbm90IHByb3ZpZGUgZmluYWwg Y29tbWVudHMgb24gdGhlIGxpc3Qgc28gdGhleQpjb3VsZCBiZSBhZGRlZCBoZXJlIC0gaW4gY2hh bmdlIGxvZy4gVGhpcyB3b3VsZCBhbHNvIGJlIGFuIGV4cGxhbmF0aW9uCndoeSB0aGVyZSBpcyBh IHJlc2VuZC4gQW5vdGhlciBzb2x1dGlvbiB3b3VsZCBiZSB0byBleHRlbmQgdGhlIGNvbW1pdCAj NwpkZXNjcmlwdGlvbiAtIHdoeSBvbmx5IENNVSBjYXNlIGlzIGNvdmVyZWQuCgpBYm91dCBwYXRj aCAjNzogVGhlIGRlY2lzaW9uIHdhcyBub3QgdG8gY29ycmVjdCBub24tQ01VIGNhc2UgYmVjYXVz ZQp0aGVyZSB3ZXJlIG5vdCBhY3R1YWwgcmVwb3J0cyBhYm91dCBjbG9jayByb3VuZGluZyBwb2Js ZW1zLCBpdCB3b3VsZCBub3QKYmUgdHJpdmlhbCBjaGFuZ2UgYW5kIHdlIGRvIG5vdCBoYXZlIHRo ZSBIVyB0byB0ZXN0LgoKVGhhbmtzIE1hcmsgZm9yIGxvb2tpbmcgaW50byBpdC4KCkJlc3QgcmVn YXJkcywKS3J6eXN6dG9mCgoKX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX18KbGludXgtYXJtLWtlcm5lbCBtYWlsaW5nIGxpc3QKbGludXgtYXJtLWtlcm5lbEBs aXN0cy5pbmZyYWRlYWQub3JnCmh0dHA6Ly9saXN0cy5pbmZyYWRlYWQub3JnL21haWxtYW4vbGlz dGluZm8vbGludXgtYXJtLWtlcm5lbAo=