From: Johan Hovold <johan@kernel.org>
To: Mychaela Falconia <mychaela.falconia@gmail.com>
Cc: Johan Hovold <johan@kernel.org>, linux-usb@vger.kernel.org
Subject: Re: [RFC] ftdi_sio driver: use altsetting or cur_altsetting?
Date: Fri, 2 Oct 2020 10:40:01 +0200 [thread overview]
Message-ID: <20201002084001.GG5141@localhost> (raw)
In-Reply-To: <CA+uuBqZg+GJk+7FNUh9V4LhCU5L0QSHsM_3Q5bVfsOecBkAnQw@mail.gmail.com>
On Fri, Oct 02, 2020 at 12:37:58AM -0800, Mychaela Falconia wrote:
> Hi Johan,
>
> > As long as you only access bNumInterfaces, which by definition is
> > identical for all altsettings, it's not wrong per se.
>
> But the code in ftdi_determine_type() that uses the altsetting pointer
> is not looking at bNumInterfaces, it is looking at bInterfaceNumber
> instead:
>
> inter = serial->interface->altsetting->desc.bInterfaceNumber;
Sorry, I meant bInterfaceNumber above.
Johan
prev parent reply other threads:[~2020-10-02 8:40 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-10-01 19:20 [RFC] ftdi_sio driver: use altsetting or cur_altsetting? Mychaela Falconia
2020-10-02 7:01 ` Johan Hovold
2020-10-02 8:37 ` Mychaela Falconia
2020-10-02 8:40 ` Johan Hovold [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201002084001.GG5141@localhost \
--to=johan@kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=mychaela.falconia@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.