From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.2 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id E9EEDC4363D for ; Fri, 2 Oct 2020 14:51:26 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id BCAC920708 for ; Fri, 2 Oct 2020 14:51:26 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2388002AbgJBOv0 (ORCPT ); Fri, 2 Oct 2020 10:51:26 -0400 Received: from foss.arm.com ([217.140.110.172]:38184 "EHLO foss.arm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726386AbgJBOv0 (ORCPT ); Fri, 2 Oct 2020 10:51:26 -0400 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 2D0071FB; Fri, 2 Oct 2020 07:51:25 -0700 (PDT) Received: from bogus (unknown [10.57.48.110]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 7BDAF3F73B; Fri, 2 Oct 2020 07:51:22 -0700 (PDT) Date: Fri, 2 Oct 2020 15:51:15 +0100 From: Sudeep Holla To: Michal Simek Cc: muhammad.husaini.zulkifli@intel.com, adrian.hunter@intel.com, ulf.hansson@linaro.org, linux-mmc@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, lakshmi.bai.raja.subramanian@intel.com, arnd@arndb.de, Sudeep Holla , wan.ahmad.zainie.wan.mohamad@intel.com Subject: Re: [PATCH v2 2/3] firmware: Keem Bay: Add support for Arm Trusted Firmware Service call Message-ID: <20201002145115.GA6520@bogus> References: <20201001142149.23445-1-muhammad.husaini.zulkifli@intel.com> <20201001142149.23445-3-muhammad.husaini.zulkifli@intel.com> <20201001153526.GD906@bogus> <20201002105840.GE906@bogus> <1b714566-d6dd-ead1-322e-f92847b923f3@xilinx.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <1b714566-d6dd-ead1-322e-f92847b923f3@xilinx.com> User-Agent: Mutt/1.9.4 (2018-02-28) Precedence: bulk List-ID: X-Mailing-List: linux-mmc@vger.kernel.org Hi Michal, On Fri, Oct 02, 2020 at 03:53:33PM +0200, Michal Simek wrote: > Hi Sudeep, > > On 02. 10. 20 12:58, Sudeep Holla wrote: > > Hi Michal, > > > > On Fri, Oct 02, 2020 at 10:23:02AM +0200, Michal Simek wrote: > >> Hi Sudeep, > >> > >> On 01. 10. 20 17:35, Sudeep Holla wrote: > > > > [...] > > > >>> > >>> What are the other uses of this KEEMBAY_SIP_* ? > >>> For now I tend to move this to the driver making use of it using > >>> arm_smccc_1_1_invoke directly if possible. I don't see the need for this > >>> to be separate driver. But do let us know the features implemented in the > >>> firmware. If it is not v1.1+, reasons for not upgrading as you need v1.1 > >>> for some CPU errata implementation. > >> > >> This driver has been created based on my request to move it out the mmc > >> driver. It looks quite hacky to have arm_smccc_res and call > >> arm_smccc_smc() also with some IDs where it is visible that the part of > >> ID is just based on any spec. > > > > OK, driver is fine but no dt-bindings as it is discoverable. It can > > also be just a wrapper library instead as it needs no explicit > > initialisation like drivers to setup. > > I am fine with it. Do we have any example which we can point him to? > You seem to have figured that out already with SOC_ID example. That was quick I must say 😄. > > > > >> Also in v1 he is just calling SMC. But maybe there is going a need to > >> call HVC instead which is something what device driver shouldn't decide > >> that's why IMHO doing step via firmware driver is much better approach. > > > > Agreed and one must use arm_smccc_get_conduit or something similar. No > > additional bindings for each and ever platform and driver that uses SMCCC > > please. > > > >> Of course if there is a better/cleaner way how this should be done I am > >> happy to get more information about it. > >> > > > > Let me know what you think about my thoughts stated above. > > > I am fine with it. The key point is to have these sort it out because I > see that a lot of drivers just simply call that SMCs from drivers which > is IMHO wrong. > Sure, sorry I didn't express my concern properly. I want to avoid dt bindings for these and use the SMCCC discovery we have in place already if possible. If this driver had consumers in the DT and it needs to be represented in DT, it is a different story and I agree for need for a driver there. But I don't see one in this usecase. > > BTW: I see you have added soc id reading which you are saying is the > part of smcc v1.2 but I can't see any implementation in TF-A. Is this > spec publicly available? > Spec is out[1], include/linux/arm-smccc.h points to the latest spec. TF-A does have implementation as I tested with it and even reported bug that I discovered when I tested with my patches that are now merged upstream. Are you referring to master of TF-A or last release version ? If latter, it had bug and may not be working. I may be wrong though, as I am just telling what was told to me couple of months back and things might have changed in TF-A land. -- Regards, Sudeep [1] https://developer.arm.com/documentation/den0028/latest From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.2 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id CE7F9C4363D for ; Fri, 2 Oct 2020 14:52:46 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 8125E20665 for ; Fri, 2 Oct 2020 14:52:46 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="eT5BlTsM" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 8125E20665 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=arm.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References:Message-ID: Subject:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=f+ThmTzQcg3XNRs40rWSfhfPKb5bMhCbwsWI8t2pF28=; b=eT5BlTsMMOJ1czw/Z3DutQaHs FDly6K9hYr15kEJxOr/9CSNm9kZ6oSx4ag85yzNi4lt7TaQsixpMEWKtziKFECNLWmL58LSQ2KQ3X cQwEn6slTXeH1OO2ggbkHwib3dJlm/yC8C8MEpaRSBttNC2YwkRCX5apAAqfupUuuX9I6GbD3RjcG AAoHoQmtZq2tL+j3apycKiUDCHHYupsWm2L4rB++G4T+UKfSd7ARBNUKYc9rLPi4F08Yhy06dFfvI RtzNXZP9dvlB9YIti7CUQvZ1AsvqgMQbFYChmwceEHtnktoZuvY0y5Y7G6lbCqifEaHq1CYiCW70W WRrJnLl6A==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1kOMPC-0006aK-7l; Fri, 02 Oct 2020 14:51:30 +0000 Received: from foss.arm.com ([217.140.110.172]) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1kOMP9-0006Zh-J2 for linux-arm-kernel@lists.infradead.org; Fri, 02 Oct 2020 14:51:28 +0000 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 2D0071FB; Fri, 2 Oct 2020 07:51:25 -0700 (PDT) Received: from bogus (unknown [10.57.48.110]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 7BDAF3F73B; Fri, 2 Oct 2020 07:51:22 -0700 (PDT) Date: Fri, 2 Oct 2020 15:51:15 +0100 From: Sudeep Holla To: Michal Simek Subject: Re: [PATCH v2 2/3] firmware: Keem Bay: Add support for Arm Trusted Firmware Service call Message-ID: <20201002145115.GA6520@bogus> References: <20201001142149.23445-1-muhammad.husaini.zulkifli@intel.com> <20201001142149.23445-3-muhammad.husaini.zulkifli@intel.com> <20201001153526.GD906@bogus> <20201002105840.GE906@bogus> <1b714566-d6dd-ead1-322e-f92847b923f3@xilinx.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <1b714566-d6dd-ead1-322e-f92847b923f3@xilinx.com> User-Agent: Mutt/1.9.4 (2018-02-28) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20201002_105127_725538_43F5D34F X-CRM114-Status: GOOD ( 33.85 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: ulf.hansson@linaro.org, arnd@arndb.de, lakshmi.bai.raja.subramanian@intel.com, linux-mmc@vger.kernel.org, adrian.hunter@intel.com, linux-kernel@vger.kernel.org, wan.ahmad.zainie.wan.mohamad@intel.com, Sudeep Holla , muhammad.husaini.zulkifli@intel.com, linux-arm-kernel@lists.infradead.org Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org SGkgTWljaGFsLAoKT24gRnJpLCBPY3QgMDIsIDIwMjAgYXQgMDM6NTM6MzNQTSArMDIwMCwgTWlj aGFsIFNpbWVrIHdyb3RlOgo+IEhpIFN1ZGVlcCwKPgo+IE9uIDAyLiAxMC4gMjAgMTI6NTgsIFN1 ZGVlcCBIb2xsYSB3cm90ZToKPiA+IEhpIE1pY2hhbCwKPiA+Cj4gPiBPbiBGcmksIE9jdCAwMiwg MjAyMCBhdCAxMDoyMzowMkFNICswMjAwLCBNaWNoYWwgU2ltZWsgd3JvdGU6Cj4gPj4gSGkgU3Vk ZWVwLAo+ID4+Cj4gPj4gT24gMDEuIDEwLiAyMCAxNzozNSwgU3VkZWVwIEhvbGxhIHdyb3RlOgo+ ID4KPiA+IFsuLi5dCj4gPgo+ID4+Pgo+ID4+PiBXaGF0IGFyZSB0aGUgb3RoZXIgdXNlcyBvZiB0 aGlzIEtFRU1CQVlfU0lQXyogPwo+ID4+PiBGb3Igbm93IEkgdGVuZCB0byBtb3ZlIHRoaXMgdG8g dGhlIGRyaXZlciBtYWtpbmcgdXNlIG9mIGl0IHVzaW5nCj4gPj4+IGFybV9zbWNjY18xXzFfaW52 b2tlIGRpcmVjdGx5IGlmIHBvc3NpYmxlLiBJIGRvbid0IHNlZSB0aGUgbmVlZCBmb3IgdGhpcwo+ ID4+PiB0byBiZSBzZXBhcmF0ZSBkcml2ZXIuIEJ1dCBkbyBsZXQgdXMga25vdyB0aGUgZmVhdHVy ZXMgaW1wbGVtZW50ZWQgaW4gdGhlCj4gPj4+IGZpcm13YXJlLiBJZiBpdCBpcyBub3QgdjEuMSss IHJlYXNvbnMgZm9yIG5vdCB1cGdyYWRpbmcgYXMgeW91IG5lZWQgdjEuMQo+ID4+PiBmb3Igc29t ZSBDUFUgZXJyYXRhIGltcGxlbWVudGF0aW9uLgo+ID4+Cj4gPj4gVGhpcyBkcml2ZXIgaGFzIGJl ZW4gY3JlYXRlZCBiYXNlZCBvbiBteSByZXF1ZXN0IHRvIG1vdmUgaXQgb3V0IHRoZSBtbWMKPiA+ PiBkcml2ZXIuIEl0IGxvb2tzIHF1aXRlIGhhY2t5IHRvIGhhdmUgYXJtX3NtY2NjX3JlcyBhbmQg Y2FsbAo+ID4+IGFybV9zbWNjY19zbWMoKSBhbHNvIHdpdGggc29tZSBJRHMgd2hlcmUgaXQgaXMg dmlzaWJsZSB0aGF0IHRoZSBwYXJ0IG9mCj4gPj4gSUQgaXMganVzdCBiYXNlZCBvbiBhbnkgc3Bl Yy4KPiA+Cj4gPiBPSywgZHJpdmVyIGlzIGZpbmUgYnV0IG5vIGR0LWJpbmRpbmdzIGFzIGl0IGlz IGRpc2NvdmVyYWJsZS4gSXQgY2FuCj4gPiBhbHNvIGJlIGp1c3QgYSB3cmFwcGVyIGxpYnJhcnkg aW5zdGVhZCBhcyBpdCBuZWVkcyBubyBleHBsaWNpdAo+ID4gaW5pdGlhbGlzYXRpb24gbGlrZSBk cml2ZXJzIHRvIHNldHVwLgo+Cj4gSSBhbSBmaW5lIHdpdGggaXQuIERvIHdlIGhhdmUgYW55IGV4 YW1wbGUgd2hpY2ggd2UgY2FuIHBvaW50IGhpbSB0bz8KPgoKWW91IHNlZW0gdG8gaGF2ZSBmaWd1 cmVkIHRoYXQgb3V0IGFscmVhZHkgd2l0aCBTT0NfSUQgZXhhbXBsZS4KVGhhdCB3YXMgcXVpY2sg SSBtdXN0IHNheSDwn5iELgoKPgo+ID4KPiA+PiBBbHNvIGluIHYxIGhlIGlzIGp1c3QgY2FsbGlu ZyBTTUMuIEJ1dCBtYXliZSB0aGVyZSBpcyBnb2luZyBhIG5lZWQgdG8KPiA+PiBjYWxsIEhWQyBp bnN0ZWFkIHdoaWNoIGlzIHNvbWV0aGluZyB3aGF0IGRldmljZSBkcml2ZXIgc2hvdWxkbid0IGRl Y2lkZQo+ID4+IHRoYXQncyB3aHkgSU1ITyBkb2luZyBzdGVwIHZpYSBmaXJtd2FyZSBkcml2ZXIg aXMgbXVjaCBiZXR0ZXIgYXBwcm9hY2guCj4gPgo+ID4gQWdyZWVkIGFuZCBvbmUgbXVzdCB1c2Ug YXJtX3NtY2NjX2dldF9jb25kdWl0IG9yIHNvbWV0aGluZyBzaW1pbGFyLiBObwo+ID4gYWRkaXRp b25hbCBiaW5kaW5ncyBmb3IgZWFjaCBhbmQgZXZlciBwbGF0Zm9ybSBhbmQgZHJpdmVyIHRoYXQg dXNlcyBTTUNDQwo+ID4gcGxlYXNlLgo+ID4KPiA+PiBPZiBjb3Vyc2UgaWYgdGhlcmUgaXMgYSBi ZXR0ZXIvY2xlYW5lciB3YXkgaG93IHRoaXMgc2hvdWxkIGJlIGRvbmUgSSBhbQo+ID4+IGhhcHB5 IHRvIGdldCBtb3JlIGluZm9ybWF0aW9uIGFib3V0IGl0Lgo+ID4+Cj4gPgo+ID4gTGV0IG1lIGtu b3cgd2hhdCB5b3UgdGhpbmsgYWJvdXQgbXkgdGhvdWdodHMgc3RhdGVkIGFib3ZlLgo+Cj4KPiBJ IGFtIGZpbmUgd2l0aCBpdC4gVGhlIGtleSBwb2ludCBpcyB0byBoYXZlIHRoZXNlIHNvcnQgaXQg b3V0IGJlY2F1c2UgSQo+IHNlZSB0aGF0IGEgbG90IG9mIGRyaXZlcnMganVzdCBzaW1wbHkgY2Fs bCB0aGF0IFNNQ3MgZnJvbSBkcml2ZXJzIHdoaWNoCj4gaXMgSU1ITyB3cm9uZy4KPgoKU3VyZSwg c29ycnkgSSBkaWRuJ3QgZXhwcmVzcyBteSBjb25jZXJuIHByb3Blcmx5LiBJIHdhbnQgdG8gYXZv aWQgZHQgYmluZGluZ3MKZm9yIHRoZXNlIGFuZCB1c2UgdGhlIFNNQ0NDIGRpc2NvdmVyeSB3ZSBo YXZlIGluIHBsYWNlIGFscmVhZHkgaWYgcG9zc2libGUuCgpJZiB0aGlzIGRyaXZlciBoYWQgY29u c3VtZXJzIGluIHRoZSBEVCBhbmQgaXQgbmVlZHMgdG8gYmUgcmVwcmVzZW50ZWQKaW4gRFQsIGl0 IGlzIGEgZGlmZmVyZW50IHN0b3J5IGFuZCBJIGFncmVlIGZvciBuZWVkIGZvciBhIGRyaXZlciB0 aGVyZS4KQnV0IEkgZG9uJ3Qgc2VlIG9uZSBpbiB0aGlzIHVzZWNhc2UuCgo+Cj4gQlRXOiBJIHNl ZSB5b3UgaGF2ZSBhZGRlZCBzb2MgaWQgcmVhZGluZyB3aGljaCB5b3UgYXJlIHNheWluZyBpcyB0 aGUKPiBwYXJ0IG9mIHNtY2MgdjEuMiBidXQgSSBjYW4ndCBzZWUgYW55IGltcGxlbWVudGF0aW9u IGluIFRGLUEuIElzIHRoaXMKPiBzcGVjIHB1YmxpY2x5IGF2YWlsYWJsZT8KPgoKU3BlYyBpcyBv dXRbMV0sIGluY2x1ZGUvbGludXgvYXJtLXNtY2NjLmggcG9pbnRzIHRvIHRoZSBsYXRlc3Qgc3Bl Yy4KVEYtQSBkb2VzIGhhdmUgaW1wbGVtZW50YXRpb24gYXMgSSB0ZXN0ZWQgd2l0aCBpdCBhbmQg ZXZlbiByZXBvcnRlZApidWcgdGhhdCBJIGRpc2NvdmVyZWQgd2hlbiBJIHRlc3RlZCB3aXRoIG15 IHBhdGNoZXMgdGhhdCBhcmUgbm93IG1lcmdlZAp1cHN0cmVhbS4gQXJlIHlvdSByZWZlcnJpbmcg dG8gbWFzdGVyIG9mIFRGLUEgb3IgbGFzdCByZWxlYXNlIHZlcnNpb24gPwpJZiBsYXR0ZXIsIGl0 IGhhZCBidWcgYW5kIG1heSBub3QgYmUgd29ya2luZy4gSSBtYXkgYmUgd3JvbmcgdGhvdWdoLCBh cwpJIGFtIGp1c3QgdGVsbGluZyB3aGF0IHdhcyB0b2xkIHRvIG1lIGNvdXBsZSBvZiBtb250aHMg YmFjayBhbmQgdGhpbmdzCm1pZ2h0IGhhdmUgY2hhbmdlZCBpbiBURi1BIGxhbmQuCgotLQpSZWdh cmRzLApTdWRlZXAKClsxXSBodHRwczovL2RldmVsb3Blci5hcm0uY29tL2RvY3VtZW50YXRpb24v ZGVuMDAyOC9sYXRlc3QKCl9fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fCmxpbnV4LWFybS1rZXJuZWwgbWFpbGluZyBsaXN0CmxpbnV4LWFybS1rZXJuZWxAbGlz dHMuaW5mcmFkZWFkLm9yZwpodHRwOi8vbGlzdHMuaW5mcmFkZWFkLm9yZy9tYWlsbWFuL2xpc3Rp bmZvL2xpbnV4LWFybS1rZXJuZWwK