From mboxrd@z Thu Jan 1 00:00:00 1970 Content-Type: multipart/mixed; boundary="===============2068813772325723582==" MIME-Version: 1.0 From: kernel test robot Subject: [PATCH] coccinelle: api: fix kobj_to_dev.cocci warnings Date: Fri, 02 Oct 2020 23:06:11 +0800 Message-ID: <20201002150611.GA25139@8cbb73b479b5> In-Reply-To: <202010022336.F4IlTzZV-lkp@intel.com> List-Id: To: kbuild@lists.01.org --===============2068813772325723582== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable CC: kbuild-all(a)lists.01.org TO: Denis Efremov CC: Julia Lawall CC: Keith Busch CC: Jens Axboe CC: Christoph Hellwig CC: Sagi Grimberg CC: linux-nvme(a)lists.infradead.org CC: linux-kernel(a)vger.kernel.org From: kernel test robot drivers/nvme/host/core.c:3646:60-61: WARNING opportunity for kobj_to_dev() drivers/nvme/host/core.c:3403:60-61: WARNING opportunity for kobj_to_dev() Use kobj_to_dev() instead of container_of() Generated by: scripts/coccinelle/api/kobj_to_dev.cocci Fixes: a2fc3718bc22 ("coccinelle: api: add kobj_to_dev.cocci script") CC: Denis Efremov Signed-off-by: kernel test robot --- tree: https://git.kernel.org/pub/scm/linux/kernel/git/jlawall/linux.git f= or-5.10 head: 44d8870f21529cfa8f50b503b5d949c6d46e6fc1 commit: a2fc3718bc22e85378085568ecc5765fb28cabce [3/10] coccinelle: api: ad= d kobj_to_dev.cocci script :::::: branch date: 19 hours ago :::::: commit date: 6 weeks ago Please take the patch only if it's a positive warning. Thanks! core.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) --- a/drivers/nvme/host/core.c +++ b/drivers/nvme/host/core.c @@ -3400,7 +3400,7 @@ static struct attribute *nvme_ns_id_attr static umode_t nvme_ns_id_attrs_are_visible(struct kobject *kobj, struct attribute *a, int n) { - struct device *dev =3D container_of(kobj, struct device, kobj); + struct device *dev =3D kobj_to_dev(kobj); struct nvme_ns_ids *ids =3D &dev_to_ns_head(dev)->ids; = if (a =3D=3D &dev_attr_uuid.attr) { @@ -3643,7 +3643,7 @@ static struct attribute *nvme_dev_attrs[ static umode_t nvme_dev_attrs_are_visible(struct kobject *kobj, struct attribute *a, int n) { - struct device *dev =3D container_of(kobj, struct device, kobj); + struct device *dev =3D kobj_to_dev(kobj); struct nvme_ctrl *ctrl =3D dev_get_drvdata(dev); = if (a =3D=3D &dev_attr_delete_controller.attr && !ctrl->ops->delete_ctrl) --===============2068813772325723582==--