Re: [PATCH] Revert "Bluetooth: Update resolving list when updating whitelist"

[Greg Kroah-Hartman <gregkh@linuxfoundation.org>]

[-- Attachment #1: Type: text/plain, Size: 3750 bytes --]

On Sun, Oct 04, 2020 at 03:23:18PM +0200, Bastien Nocera wrote:
> On Sun, 2020-10-04 at 15:18 +0200, Greg Kroah-Hartman wrote:
> > On Sun, Oct 04, 2020 at 02:17:06PM +0200, Bastien Nocera wrote:
> > > On Sun, 2020-10-04 at 12:51 +0200, Greg Kroah-Hartman wrote:
> > > > On Sat, Oct 03, 2020 at 08:33:18PM +0200, Marcel Holtmann wrote:
> > > > > Hi Greg,
> > > > > 
> > > > > > > > This reverts commit
> > > > > > > > 0eee35bdfa3b472cc986ecc6ad76293fdcda59e2
> > > > > > > > as it
> > > > > > > > breaks all bluetooth connections on my machine.
> > > > > > > > 
> > > > > > > > Cc: Marcel Holtmann <marcel@holtmann.org>
> > > > > > > > Cc: Sathish Narsimman <sathish.narasimman@intel.com>
> > > > > > > > Fixes: 0eee35bdfa3b ("Bluetooth: Update resolving list
> > > > > > > > when
> > > > > > > > updating whitelist")
> > > > > > > > Signed-off-by: Greg Kroah-Hartman
> > > > > > > > <gregkh@linuxfoundation.org>
> > > > > > > > ---
> > > > > > > > net/bluetooth/hci_request.c | 41 ++----------------------
> > > > > > > > ----
> > > > > > > > ---------
> > > > > > > > 1 file changed, 2 insertions(+), 39 deletions(-)
> > > > > > > > 
> > > > > > > > This has been bugging me for since 5.9-rc1, when all
> > > > > > > > bluetooth devices
> > > > > > > > stopped working on my desktop system.  I finally got the
> > > > > > > > time
> > > > > > > > to do
> > > > > > > > bisection today, and it came down to this patch. 
> > > > > > > > Reverting
> > > > > > > > it on top of
> > > > > > > > 5.9-rc7 restored bluetooth devices and now my input
> > > > > > > > devices
> > > > > > > > properly
> > > > > > > > work.
> > > > > > > > 
> > > > > > > > As it's almost 5.9-final, any chance this can be merged
> > > > > > > > now
> > > > > > > > to fix the
> > > > > > > > issue?
> > > > > > > 
> > > > > > > can you be specific what breaks since our guys and I also
> > > > > > > think
> > > > > > > the
> > > > > > > ChromeOS guys have been testing these series of patches
> > > > > > > heavily.
> > > > > > 
> > > > > > My bluetooth trackball does not connect at all.  With this
> > > > > > reverted, it
> > > > > > all "just works".
> > > > > > 
> > > > > > Same I think for a Bluetooth headset, can check that again if
> > > > > > you
> > > > > > really
> > > > > > need me to, but the trackball is reliable here.
> > > > > > 
> > > > > > > When you run btmon does it indicate any errors?
> > > > > > 
> > > > > > How do I run it and where are the errors displayed?
> > > > > 
> > > > > you can do btmon -w trace.log and just let it run like tcdpump.
> > > > 
> > > > Ok, attached.
> > > > 
> > > > The device is not connecting, and then I open the gnome bluetooth
> > > > dialog
> > > > and it scans for devices in the area, but does not connect to my
> > > > existing devices at all.
> > > > 
> > > > Any ideas?
> > > 
> > > Use bluetoothctl instead, the Bluetooth Settings from GNOME also
> > > run a
> > > discovery the whole time the panel is opened, and this breaks a
> > > fair
> > > number of poor quality adapters. This is worked-around in the most
> > > recent version, but using bluetoothctl is a better debugging option
> > > in
> > > all cases.
> > 
> > Ok, but how do I use that tool?  How do I shut down the gnome
> > bluetooth
> > stuff?
> 
> You close the settings window...
> 
> > I need newbie steps here please for what to run and what to show you.
> 
> bluetoothctl connect "bluetooth address"
> eg.
> bluetoothctl connect "12:34:56:78:90"

Ok, here that is on a clean 5.9-rc8 release:

$ bluetoothctl connect F1:85:91:79:73:70
Attempting to connect to F1:85:91:79:73:70
Failed to connect: org.bluez.Error.Failed

I've attached the trace log from that effort.

I'll go try Marcel's proposed patch now as well...

thanks,

greg k-h

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: trace.log --]
[-- Type: text/plain; charset=utf-8, Size: 663 bytes --]

btsnoop\0\0\0\0\x01\0\0\aÑ\0\0\0!\0\0\0!ÿÿ\0\f\0\0\0\0\0⎛M#=ÊLinux version 5.9.0-rc8 (x86_64)\0\0\0\0!\0\0\0!ÿÿ\0\f\0\0\0\0\0⎛M#=ÌBluetooth subsystem version 2.22\0\0\0\0\x10\0\0\0\x10\0\0\0\0\0\0\0\0\0⎛M#=Í\0\x01peö…àPhci0\0\0\0\0\0\0\0\0\0\0\0\0\0\0\0\b\0\0\0\0\0⎛M#=Í\0\0\0\b\0\0\0\b\0\0\0
\0\0\0\0\0⎛M#=Îpeö…àP\x02\0\0\0\0\x1e\0\0\0\x1eÿÿ\0\x0e\0\0\0\0\0⎛M#=Î\x01\0\0\0\x02\0\x01\x12\0\x01\0\0\0\x10bluetoothd\0\0\0\0\0\0\0\0\0	\0\0\0	\0\0\0\x02\0\0\0\0\0⎛N\x12\x13üB \x06\0\0\0\0\0\0\0\0\0\x06\0\0\0\x06\0\0\0\x03\0\0\0\0\0⎛N\x13Ýg\x0e\x04\x02B \0\0\0\0\v\0\0\0\v\0\0\0\x02\0\0\0\0\0⎛N\x13ÝŒA \b\0\x01\x01\0`\0`\0\0\0\0\x06\0\0\0\x06\0\0\0\x03\0\0\0\0\0⎛N\x13ít\x0e\x04\x01A \0\0\0\0	\0\0\0	\0\0\0\x02\0\0\0\0\0⎛N\x13í¡B \x06\x01\x01\0\0\0\0\0\0\0\x06\0\0\0\x06\0\0\0\x03\0\0\0\0\0⎛N\x13ý\x19\x0e\x04\x02B \0\0\0\0	\0\0\0	\0\0\0\x02\0\0\0\0\0⎛P….)B \x06\0\0\0\0\0\0\0\0\0\x06\0\0\0\x06\0\0\0\x03\0\0\0\0\0⎛P‡ °\x0e\x04\x02B \0\0\0\0\v\0\0\0\v\0\0\0\x02\0\0\0\0\0⎛P‡ ÿA \b\0\x01\x01\0`\00\0\0\0\0\x06\0\0\0\x06\0\0\0\x03\0\0\0\0\0⎛P‡,N\x0e\x04\x01A \0\0\0\0	\0\0\0	\0\0\0\x02\0\0\0\0\0⎛P‡,B \x06\x01\x01\0\0\0\0\0\0\0\x06\0\0\0\x06\0\0\0\x03\0\0\0\0\0⎛P‡:`\x0e\x04\x02B \0