From: Christoph Hellwig <hch@infradead.org>
To: davem@davemloft.net, Magnus Karlsson <magnus.karlsson@intel.com>
Cc: bjorn.topel@intel.com, ast@kernel.org, daniel@iogearbox.net,
netdev@vger.kernel.org, jonathan.lemon@gmail.com,
maximmi@mellanox.com, bpf@vger.kernel.org,
jeffrey.t.kirsher@intel.com, anthony.l.nguyen@intel.com,
maciej.fijalkowski@intel.com, maciejromanfijalkowski@gmail.com,
cristian.dumitrescu@intel.com
Subject: Re: please revert [PATCH bpf-next v5 03/15] xsk: create and free buffer pool independently from umem
Date: Mon, 5 Oct 2020 09:43:41 +0100 [thread overview]
Message-ID: <20201005084341.GA3224@infradead.org> (raw)
In-Reply-To: <20201005083535.GA512@infradead.org>
On Mon, Oct 05, 2020 at 09:35:35AM +0100, Christoph Hellwig wrote:
> Hi Dave,
>
> please can you rever this? This is the second xsk patch this year
> that pokes into dma-mapping internals for absolutely not reason.
>
> And we discussed this in detail the last time around: drivers have
> absolutely no business poking into dma-direct.h and dma-noncoherent.h.
> In fact because people do this crap I have a patch to remove these
> headers that I'm about to queue up, so if this doesn't get reverted
> the linux-next build will break soon.
Looks like it doesn't actually use any functionality and just
pointlessly includes internal headers. So just removing dma-direct.h,
dma-noncoherent.h and swiotlb.h should do the job as well.
But guys, don't do this.
next prev parent reply other threads:[~2020-10-05 8:43 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-08-28 8:26 [PATCH bpf-next v5 00/15] xsk: support shared umems between devices and queues Magnus Karlsson
2020-08-28 8:26 ` [PATCH bpf-next v5 01/15] xsk: i40e: ice: ixgbe: mlx5: pass buffer pool to driver instead of umem Magnus Karlsson
2020-08-28 8:26 ` [PATCH bpf-next v5 02/15] xsk: i40e: ice: ixgbe: mlx5: rename xsk zero-copy driver interfaces Magnus Karlsson
2020-08-28 8:26 ` [PATCH bpf-next v5 03/15] xsk: create and free buffer pool independently from umem Magnus Karlsson
2020-10-05 8:35 ` please revert " Christoph Hellwig
2020-10-05 8:43 ` Christoph Hellwig [this message]
2020-10-05 8:47 ` Björn Töpel
2020-08-28 8:26 ` [PATCH bpf-next v5 04/15] xsk: move fill and completion rings to buffer pool Magnus Karlsson
2020-08-28 8:26 ` [PATCH bpf-next v5 05/15] xsk: move queue_id, dev and need_wakeup " Magnus Karlsson
2020-08-28 8:26 ` [PATCH bpf-next v5 06/15] xsk: move xsk_tx_list and its lock " Magnus Karlsson
2020-08-28 8:26 ` [PATCH bpf-next v5 07/15] xsk: move addrs from buffer pool to umem Magnus Karlsson
2020-08-28 8:26 ` [PATCH bpf-next v5 08/15] xsk: enable sharing of dma mappings Magnus Karlsson
2020-08-28 8:26 ` [PATCH bpf-next v5 09/15] xsk: rearrange internal structs for better performance Magnus Karlsson
2020-08-28 8:26 ` [PATCH bpf-next v5 10/15] xsk: i40e: ice: ixgbe: mlx5: test for dma_need_sync earlier " Magnus Karlsson
2020-08-28 8:26 ` [PATCH bpf-next v5 11/15] xsk: add shared umem support between queue ids Magnus Karlsson
2020-08-28 8:26 ` [PATCH bpf-next v5 12/15] xsk: add shared umem support between devices Magnus Karlsson
2020-08-28 8:26 ` [PATCH bpf-next v5 13/15] libbpf: support shared umems between queues and devices Magnus Karlsson
2020-08-28 8:26 ` [PATCH bpf-next v5 14/15] samples/bpf: add new sample xsk_fwd.c Magnus Karlsson
2020-08-28 8:26 ` [PATCH bpf-next v5 15/15] xsk: documentation for XDP_SHARED_UMEM between queues and netdevs Magnus Karlsson
2020-08-31 20:20 ` [PATCH bpf-next v5 00/15] xsk: support shared umems between devices and queues Daniel Borkmann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201005084341.GA3224@infradead.org \
--to=hch@infradead.org \
--cc=anthony.l.nguyen@intel.com \
--cc=ast@kernel.org \
--cc=bjorn.topel@intel.com \
--cc=bpf@vger.kernel.org \
--cc=cristian.dumitrescu@intel.com \
--cc=daniel@iogearbox.net \
--cc=davem@davemloft.net \
--cc=jeffrey.t.kirsher@intel.com \
--cc=jonathan.lemon@gmail.com \
--cc=maciej.fijalkowski@intel.com \
--cc=maciejromanfijalkowski@gmail.com \
--cc=magnus.karlsson@intel.com \
--cc=maximmi@mellanox.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.