From: "Daniel P. Berrangé" <berrange@redhat.com>
To: Markus Armbruster <armbru@redhat.com>
Cc: Kevin Wolf <kwolf@redhat.com>, Peter Krempa <pkrempa@redhat.com>,
"Denis V. Lunev" <den@virtuozzo.com>,
qemu-block@nongnu.org, Juan Quintela <quintela@redhat.com>,
John Snow <jsnow@redhat.com>,
qemu-devel@nongnu.org, Max Reitz <mreitz@redhat.com>,
Pavel Dovgalyuk <pavel.dovgaluk@ispras.ru>,
Paolo Bonzini <pbonzini@redhat.com>,
"Dr. David Alan Gilbert" <dgilbert@redhat.com>
Subject: Re: [PATCH v5 10/10] migration: introduce snapshot-{save, load, delete} QMP commands
Date: Mon, 5 Oct 2020 12:36:12 +0100 [thread overview]
Message-ID: <20201005113612.GH2385272@redhat.com> (raw)
In-Reply-To: <87a6x1cev5.fsf@dusky.pond.sub.org>
On Mon, Oct 05, 2020 at 09:26:54AM +0200, Markus Armbruster wrote:
> Eric Blake <eblake@redhat.com> writes:
>
> > On 10/2/20 11:27 AM, Daniel P. Berrangé wrote:
> >
> > Do we have a query- command handy to easily learn which snapshot names
> > are even available to attempt deletion on? If not, that's worth a
> > separate patch.
>
> Oh, I missed that one. It's the QMP equivalent to "info snapshots", and
> it is required to finish the job. Since we're at v5, I'd be okay with a
> follow-up patch, as long as it is done for 5.2.
"query-named-block-nodes" returns BlockDeviceInfo struct, which
contains ImageInfo which contains an array of SnapshotInfo. So
we don't need any new query command.
Regards,
Daniel
--
|: https://berrange.com -o- https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org -o- https://fstop138.berrange.com :|
|: https://entangle-photo.org -o- https://www.instagram.com/dberrange :|
next prev parent reply other threads:[~2020-10-05 11:37 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-10-02 16:27 [PATCH v5 00/10] migration: bring improved savevm/loadvm/delvm to QMP Daniel P. Berrangé
2020-10-02 16:27 ` [PATCH v5 01/10] block: push error reporting into bdrv_all_*_snapshot functions Daniel P. Berrangé
2020-10-02 16:27 ` [PATCH v5 02/10] migration: stop returning errno from load_snapshot() Daniel P. Berrangé
2020-10-02 16:27 ` [PATCH v5 03/10] block: add ability to specify list of blockdevs during snapshot Daniel P. Berrangé
2020-10-02 16:27 ` [PATCH v5 04/10] block: allow specifying name of block device for vmstate storage Daniel P. Berrangé
2020-10-02 16:27 ` [PATCH v5 05/10] block: rename and alter bdrv_all_find_snapshot semantics Daniel P. Berrangé
2020-10-02 16:27 ` [PATCH v5 06/10] migration: control whether snapshots are ovewritten Daniel P. Berrangé
2020-10-02 16:27 ` [PATCH v5 07/10] migration: wire up support for snapshot device selection Daniel P. Berrangé
2020-10-02 16:27 ` [PATCH v5 08/10] migration: introduce a delete_snapshot wrapper Daniel P. Berrangé
2020-10-02 16:27 ` [PATCH v5 09/10] iotests: add support for capturing and matching QMP events Daniel P. Berrangé
2020-10-02 16:27 ` [PATCH v5 10/10] migration: introduce snapshot-{save, load, delete} QMP commands Daniel P. Berrangé
2020-10-02 19:46 ` Eric Blake
2020-10-05 7:26 ` Markus Armbruster
2020-10-05 11:36 ` Daniel P. Berrangé [this message]
2020-10-05 12:45 ` Markus Armbruster
2020-10-05 11:37 ` [PATCH v5 10/10] migration: introduce snapshot-{save,load,delete} " Daniel P. Berrangé
2020-10-06 17:36 ` Dr. David Alan Gilbert
2020-11-25 10:13 ` [PATCH v5 00/10] migration: bring improved savevm/loadvm/delvm to QMP Markus Armbruster
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201005113612.GH2385272@redhat.com \
--to=berrange@redhat.com \
--cc=armbru@redhat.com \
--cc=den@virtuozzo.com \
--cc=dgilbert@redhat.com \
--cc=jsnow@redhat.com \
--cc=kwolf@redhat.com \
--cc=mreitz@redhat.com \
--cc=pavel.dovgaluk@ispras.ru \
--cc=pbonzini@redhat.com \
--cc=pkrempa@redhat.com \
--cc=qemu-block@nongnu.org \
--cc=qemu-devel@nongnu.org \
--cc=quintela@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.