From: Jason Gunthorpe <jgg@nvidia.com>
To: Kamal Heib <kamalheib1@gmail.com>
Cc: <linux-rdma@vger.kernel.org>, Doug Ledford <dledford@redhat.com>
Subject: Re: [PATCH for-rc v3] RDMA/ipoib: Set rtnl_link_ops for ipoib interfaces
Date: Mon, 5 Oct 2020 15:10:34 -0300 [thread overview]
Message-ID: <20201005181034.GA31303@nvidia.com> (raw)
In-Reply-To: <20201004132948.26669-1-kamalheib1@gmail.com>
On Sun, Oct 04, 2020 at 04:29:48PM +0300, Kamal Heib wrote:
> To avoid inconsistent user experience for PKey interfaces that are
> created via netlink VS PKey interfaces that are created via sysfs and
> parent interfaces, make sure to set the rtnl_link_ops for all ipoib
> network devices (PKeys and parent interfaces), so the ipoib attributes
> will be reported/modified via iproute2 for all ipoib interfaces
> regardless of how they are created.
>
> Also, after setting the rtnl_link_ops for the parent interface, implement
> the dellink() callback to block users from trying to remove it.
>
> Fixes: 9baa0b036410 ("IB/ipoib: Add rtnl_link_ops support")
> Signed-off-by: Kamal Heib <kamalheib1@gmail.com>
> ---
> v3: Move the setting of rtnl_link_ops to ipoib_vlan_add() and update
> the commit message.
> v2: Update commit message.
> ---
> drivers/infiniband/ulp/ipoib/ipoib_main.c | 2 ++
> drivers/infiniband/ulp/ipoib/ipoib_netlink.c | 11 +++++++++++
> drivers/infiniband/ulp/ipoib/ipoib_vlan.c | 2 ++
> 3 files changed, 15 insertions(+)
Applied to for-next, thanks
Jason
next prev parent reply other threads:[~2020-10-05 18:10 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-10-04 13:29 [PATCH for-rc v3] RDMA/ipoib: Set rtnl_link_ops for ipoib interfaces Kamal Heib
2020-10-05 18:10 ` Jason Gunthorpe [this message]
2020-10-05 18:13 ` Jason Gunthorpe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201005181034.GA31303@nvidia.com \
--to=jgg@nvidia.com \
--cc=dledford@redhat.com \
--cc=kamalheib1@gmail.com \
--cc=linux-rdma@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.