From: Pablo Neira Ayuso <pablo@netfilter.org>
To: Phil Sutter <phil@nwl.cc>
Cc: netfilter-devel@vger.kernel.org,
Serhey Popovych <serhe.popovych@gmail.com>
Subject: Re: [iptables PATCH 2/3] libxtables: Simplify pending extension registration
Date: Tue, 6 Oct 2020 01:08:16 +0200 [thread overview]
Message-ID: <20201005230816.GA13745@salvia> (raw)
In-Reply-To: <20200922225341.8976-3-phil@nwl.cc>
On Wed, Sep 23, 2020 at 12:53:40AM +0200, Phil Sutter wrote:
> Assuming that pending extensions are sorted by first name and family,
> then descending revision, the decision where to insert a newly
> registered extension may be simplified by memorizing the previous
> registration (which obviously is of same name and family and higher
> revision).
>
> As a side-effect, fix for unsupported old extension revisions lingering
> in pending extension list forever and being retried with every use of
> the given extension. Any revision being rejected by the kernel may
> safely be dropped iff a previous (read: higher) revision was accepted
> already.
>
> Yet another side-effect of this change is the removal of an unwanted
> recursion by xtables_fully_register_pending_*() into itself via
> xtables_find_*().
LGTM.
next prev parent reply other threads:[~2020-10-05 23:08 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-09-22 22:53 [iptables PATCH 0/3] libxtables: Fix for pointless socket() calls Phil Sutter
2020-09-22 22:53 ` [iptables PATCH 1/3] libxtables: Make sure extensions register in revision order Phil Sutter
2020-10-03 11:17 ` Pablo Neira Ayuso
2020-10-04 14:53 ` Phil Sutter
2020-10-05 22:42 ` Pablo Neira Ayuso
2020-10-06 9:27 ` Phil Sutter
2020-10-06 9:50 ` Pablo Neira Ayuso
2020-10-06 10:13 ` Phil Sutter
2020-10-06 10:48 ` Pablo Neira Ayuso
2020-10-06 12:07 ` [iptables PATCH v2] " Phil Sutter
2020-10-06 23:59 ` Pablo Neira Ayuso
2020-09-22 22:53 ` [iptables PATCH 2/3] libxtables: Simplify pending extension registration Phil Sutter
2020-10-05 23:08 ` Pablo Neira Ayuso [this message]
2020-09-22 22:53 ` [iptables PATCH 3/3] libxtables: Register multiple extensions in ascending order Phil Sutter
2020-10-05 23:41 ` Pablo Neira Ayuso
2020-10-06 9:29 ` Phil Sutter
2020-09-23 11:45 ` [iptables PATCH 0/3] libxtables: Fix for pointless socket() calls Pablo Neira Ayuso
2020-09-23 14:30 ` Phil Sutter
2020-10-07 0:02 ` Pablo Neira Ayuso
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201005230816.GA13745@salvia \
--to=pablo@netfilter.org \
--cc=netfilter-devel@vger.kernel.org \
--cc=phil@nwl.cc \
--cc=serhe.popovych@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.