[ulfh-mmc:next 92/92] drivers/mmc/host/sdhci-acpi.c:562:39: error: 'SDHCI_PRESET_DRV_SHIFT' undeclared; did you mean

[kernel test robot <lkp@intel.com>]

[-- Attachment #1: Type: text/plain, Size: 3548 bytes --]

tree:   git://git.kernel.org/pub/scm/linux/kernel/git/ulfh/mmc.git next
head:   e9b80bb74fddd0d5476e5954e16a3804d2f78250
commit: e9b80bb74fddd0d5476e5954e16a3804d2f78250 [92/92] mmc: sdhci-acpi: AMDI0040: Allow changing HS200/HS400 driver strength
config: i386-allyesconfig (attached as .config)
compiler: gcc-9 (Debian 9.3.0-15) 9.3.0
reproduce (this is a W=1 build):
        # https://git.kernel.org/pub/scm/linux/kernel/git/ulfh/mmc.git/commit/?id=e9b80bb74fddd0d5476e5954e16a3804d2f78250
        git remote add ulfh-mmc git://git.kernel.org/pub/scm/linux/kernel/git/ulfh/mmc.git
        git fetch --no-tags ulfh-mmc next
        git checkout e9b80bb74fddd0d5476e5954e16a3804d2f78250
        # save the attached .config to linux build tree
        make W=1 ARCH=i386 

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>

All errors (new ones prefixed by >>):

   drivers/mmc/host/sdhci-acpi.c: In function 'amd_select_drive_strength':
>> drivers/mmc/host/sdhci-acpi.c:562:39: error: 'SDHCI_PRESET_DRV_SHIFT' undeclared (first use in this function); did you mean 'SDHCI_PRESET_DRV_MASK'?
     562 |   (preset & SDHCI_PRESET_DRV_MASK) >> SDHCI_PRESET_DRV_SHIFT;
         |                                       ^~~~~~~~~~~~~~~~~~~~~~
         |                                       SDHCI_PRESET_DRV_MASK
   drivers/mmc/host/sdhci-acpi.c:562:39: note: each undeclared identifier is reported only once for each function it appears in

vim +562 drivers/mmc/host/sdhci-acpi.c

   545	
   546	static int amd_select_drive_strength(struct mmc_card *card,
   547					     unsigned int max_dtr, int host_drv,
   548					     int card_drv, int *host_driver_strength)
   549	{
   550		struct sdhci_host *host = mmc_priv(card->host);
   551		u16 preset, preset_driver_strength;
   552	
   553		/*
   554		 * This method is only called by mmc_select_hs200 so we only need to
   555		 * read from the HS200 (SDR104) preset register.
   556		 *
   557		 * Firmware that has "invalid/default" presets return a driver strength
   558		 * of A. This matches the previously hard coded value.
   559		 */
   560		preset = sdhci_readw(host, SDHCI_PRESET_FOR_SDR104);
   561		preset_driver_strength =
 > 562			(preset & SDHCI_PRESET_DRV_MASK) >> SDHCI_PRESET_DRV_SHIFT;
   563	
   564		/*
   565		 * We want the controller driver strength to match the card's driver
   566		 * strength so they have similar rise/fall times.
   567		 *
   568		 * The controller driver strength set by this method is sticky for all
   569		 * timings after this method is called. This unfortunately means that
   570		 * while HS400 tuning is in progress we end up with mismatched driver
   571		 * strengths between the controller and the card. HS400 tuning requires
   572		 * switching from HS400->DDR52->HS->HS200->HS400. So the driver mismatch
   573		 * happens while in DDR52 and HS modes. This has not been observed to
   574		 * cause problems. Enabling presets would fix this issue.
   575		 */
   576		*host_driver_strength = preset_driver_strength;
   577	
   578		/*
   579		 * The resulting card driver strength is only set when switching the
   580		 * card's timing to HS200 or HS400. The card will use the default driver
   581		 * strength (B) for any other mode.
   582		 */
   583		return preset_driver_strength;
   584	

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all(a)lists.01.org

[-- Attachment #2: config.gz --]
[-- Type: application/gzip, Size: 74812 bytes --]