From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.2 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id EFF84C4363A for ; Tue, 6 Oct 2020 02:28:38 +0000 (UTC) Received: from mother.openwall.net (mother.openwall.net [195.42.179.200]) by mail.kernel.org (Postfix) with SMTP id 979B5208A9 for ; Tue, 6 Oct 2020 02:28:37 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 979B5208A9 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=1wt.eu Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=kernel-hardening-return-20108-kernel-hardening=archiver.kernel.org@lists.openwall.com Received: (qmail 17810 invoked by uid 550); 6 Oct 2020 02:28:31 -0000 Mailing-List: contact kernel-hardening-help@lists.openwall.com; run by ezmlm Precedence: bulk List-Post: List-Help: List-Unsubscribe: List-Subscribe: List-ID: Received: (qmail 17772 invoked from network); 6 Oct 2020 02:28:30 -0000 Date: Tue, 6 Oct 2020 04:28:09 +0200 From: Willy Tarreau To: Kees Cook Cc: Thibaut Sautereau , "David S . Miller" , Jakub Kicinski , netdev@vger.kernel.org, kernel-hardening@lists.openwall.com, linux-kernel@vger.kernel.org, Thibaut Sautereau , Linus Torvalds , Emese Revfy , "Theodore Ts'o" , Andrew Morton Subject: Re: [PATCH] random32: Restore __latent_entropy attribute on net_rand_state Message-ID: <20201006022808.GA5531@1wt.eu> References: <20201002151610.24258-1-thibaut.sautereau@clip-os.org> <202010051910.BC7E9F4@keescook> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <202010051910.BC7E9F4@keescook> User-Agent: Mutt/1.6.1 (2016-04-27) Hi Kees, On Mon, Oct 05, 2020 at 07:12:29PM -0700, Kees Cook wrote: > On Fri, Oct 02, 2020 at 05:16:11PM +0200, Thibaut Sautereau wrote: > > From: Thibaut Sautereau > > > > Commit f227e3ec3b5c ("random32: update the net random state on interrupt > > and activity") broke compilation and was temporarily fixed by Linus in > > 83bdc7275e62 ("random32: remove net_rand_state from the latent entropy > > gcc plugin") by entirely moving net_rand_state out of the things handled > > by the latent_entropy GCC plugin. > > > > From what I understand when reading the plugin code, using the > > __latent_entropy attribute on a declaration was the wrong part and > > simply keeping the __latent_entropy attribute on the variable definition > > was the correct fix. > > > > Fixes: 83bdc7275e62 ("random32: remove net_rand_state from the latent entropy gcc plugin") > > Cc: Linus Torvalds > > Cc: Willy Tarreau > > Cc: Emese Revfy > > Signed-off-by: Thibaut Sautereau > > Yes, that looks correct. Thank you! > > Acked-by: Kees Cook > > I'm not sure the best tree for this. Ted, Andrew, Linus? I'll take it > via my gcc plugin tree if no one else takes it. :) It was already merged as commit 09a6b0bc3be79 and queued for -stable. Cheers, Willy