From: Greg KH <gregkh@linuxfoundation.org>
To: Giuliano Procida <gprocida@google.com>
Cc: stable@vger.kernel.org
Subject: Re: [PATCH 1/1] drm/syncobj: Fix drm_syncobj_handle_to_fd refcount leak
Date: Tue, 6 Oct 2020 17:31:04 +0200 [thread overview]
Message-ID: <20201006153104.GB23711@kroah.com> (raw)
In-Reply-To: <20201006135228.113259-2-gprocida@google.com>
On Tue, Oct 06, 2020 at 02:52:28PM +0100, Giuliano Procida wrote:
> commit e7cdf5c82f1773c3386b93bbcf13b9bfff29fa31 upstream.
That's not what this commit is :(
Are you sure this is correct?
> The cherry-pick 5fb252cad61f of the above commit introduced a refcount
> imbalance and so leak of struct drm_syncobj objects that can be
> triggered with DRM_IOCTL_SYNCOBJ_HANDLE_TO_FD.
Ok, so the backport of e7cdf5c82f1773c3386b93bbcf13b9bfff29fa31 is the
problem, so this needs a bit of wording change to make it obvious what
is happening here.
Can you fix that up and resend?
thanks,
greg k-h
next prev parent reply other threads:[~2020-10-06 15:30 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-10-06 13:52 [PATCH 0/1] Fix drm_syncobj_handle_to_fd refcount leak Giuliano Procida
2020-10-06 13:52 ` [PATCH 1/1] drm/syncobj: " Giuliano Procida
2020-10-06 15:31 ` Greg KH [this message]
2020-10-06 16:20 ` [PATCH v2 " Giuliano Procida
2020-10-06 16:39 ` Greg KH
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201006153104.GB23711@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=gprocida@google.com \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.