From: Jason Gunthorpe <jgg@nvidia.com>
To: "Saleem, Shiraz" <shiraz.saleem@intel.com>
Cc: Adit Ranadive <aditr@vmware.com>,
Ariel Elior <aelior@marvell.com>,
Christian Benvenuti <benve@cisco.com>,
Potnuri Bharat Teja <bharat@chelsio.com>,
Bernard Metzler <bmt@zurich.ibm.com>,
"Dalessandro, Dennis" <dennis.dalessandro@intel.com>,
Devesh Sharma <devesh.sharma@broadcom.com>,
Doug Ledford <dledford@redhat.com>,
"Latif, Faisal" <faisal.latif@intel.com>,
Gal Pressman <galpress@amazon.com>,
"Wei Hu(Xavier)" <huwei87@hisilicon.com>,
Leon Romanovsky <leon@kernel.org>,
"linux-rdma@vger.kernel.org" <linux-rdma@vger.kernel.org>,
Weihang Li <liweihang@huawei.com>,
"Marciniszyn, Mike" <mike.marciniszyn@intel.com>,
Michal Kalderon <mkalderon@marvell.com>,
Naresh Kumar PBS <nareshkumar.pbs@broadcom.com>,
Nelson Escobar <neescoba@cisco.com>,
Lijun Ou <oulijun@huawei.com>,
Parvi Kaustubhi <pkaustub@cisco.com>,
VMware PV-Drivers <pv-drivers@vmware.com>,
Bob Pearson <rpearsonhpe@gmail.com>,
Selvin Xavier <selvin.xavier@broadcom.com>,
Yossi Leybovich <sleybo@amazon.com>,
"Somnath Kotur" <somnath.kotur@broadcom.com>,
Sriharsha Basavapatna <sriharsha.basavapatna@broadcom.com>,
Zhu Yanjun <yanjunz@nvidia.com>,
Yishai Hadas <yishaih@nvidia.com>
Subject: Re: [PATCH 07/11] RDMA: Check flags during create_cq
Date: Tue, 6 Oct 2020 15:13:26 -0300 [thread overview]
Message-ID: <20201006181326.GM4734@nvidia.com> (raw)
In-Reply-To: <dae8db3a1d134141bdd6dbcca5564433@intel.com>
On Tue, Oct 06, 2020 at 06:04:29PM +0000, Saleem, Shiraz wrote:
> > a/drivers/infiniband/hw/i40iw/i40iw_verbs.c
> > b/drivers/infiniband/hw/i40iw/i40iw_verbs.c
> > index 26a61af2d3977f..4aade66ad2aea8 100644
> > +++ b/drivers/infiniband/hw/i40iw/i40iw_verbs.c
> > @@ -1107,6 +1107,9 @@ static int i40iw_create_cq(struct ib_cq *ibcq,
> > int err_code;
> > int entries = attr->cqe;
> >
> > + if (attr->flags)
> > + return -EOPNOTSUPP;
> > +
>
> I am slightly confused.
> So these flags are set for drivers that support the extended create CQ API?
No, the flags can be set by any user or kernel program creating a
CQ. The driver must ensure it supports all requested flags.
Omitting the flags check was always a mistake because an in-kernel ULP
could attempt to use them - luckily none due today.
Jason
next prev parent reply other threads:[~2020-10-06 18:13 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-10-03 23:20 [PATCH 00/11] Reduce uverbs_cmd_mask and remove uverbs_ex_cmd_mask Jason Gunthorpe
2020-10-03 23:20 ` [PATCH 01/11] RDMA/cxgb4: Remove MW support Jason Gunthorpe
2020-10-05 5:56 ` Leon Romanovsky
2020-10-05 16:17 ` Jason Gunthorpe
2020-10-09 16:40 ` Potnuri Bharat Teja
2020-10-14 23:27 ` Jason Gunthorpe
2020-10-03 23:20 ` [PATCH 02/11] RDMA: Remove uverbs_ex_cmd_mask values that are linked to functions Jason Gunthorpe
2020-10-04 11:04 ` Gal Pressman
2020-10-05 16:20 ` Jason Gunthorpe
2020-10-03 23:20 ` [PATCH 03/11] RDMA: Remove elements in uverbs_cmd_mask that all drivers set Jason Gunthorpe
2020-10-03 23:20 ` [PATCH 04/11] RDMA: Move more uverbs_cmd_mask settings to the core Jason Gunthorpe
2020-10-03 23:20 ` [PATCH 05/11] RDMA: Check srq_type during create_srq Jason Gunthorpe
2020-10-03 23:20 ` [PATCH 06/11] RDMA: Check attr_mask during modify_qp Jason Gunthorpe
2020-10-04 11:02 ` Gal Pressman
2020-10-05 16:19 ` Jason Gunthorpe
2020-10-03 23:20 ` [PATCH 07/11] RDMA: Check flags during create_cq Jason Gunthorpe
2020-10-06 18:04 ` Saleem, Shiraz
2020-10-06 18:13 ` Jason Gunthorpe [this message]
2020-10-06 18:23 ` Saleem, Shiraz
2020-10-03 23:20 ` [PATCH 08/11] RDMA: Check create_flags during create_qp Jason Gunthorpe
2020-10-03 23:20 ` [PATCH 09/11] RDMA/core Remove uverbs_ex_cmd_mask Jason Gunthorpe
2020-10-03 23:20 ` [PATCH 10/11] RDMA: Remove uverbs cmds from drivers that don't use them Jason Gunthorpe
2020-10-03 23:20 ` [PATCH 11/11] RDMA: Remove AH from uverbs_cmd_mask Jason Gunthorpe
2020-10-06 18:32 ` [PATCH 00/11] Reduce uverbs_cmd_mask and remove uverbs_ex_cmd_mask Saleem, Shiraz
2020-10-26 22:39 ` Jason Gunthorpe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201006181326.GM4734@nvidia.com \
--to=jgg@nvidia.com \
--cc=aditr@vmware.com \
--cc=aelior@marvell.com \
--cc=benve@cisco.com \
--cc=bharat@chelsio.com \
--cc=bmt@zurich.ibm.com \
--cc=dennis.dalessandro@intel.com \
--cc=devesh.sharma@broadcom.com \
--cc=dledford@redhat.com \
--cc=faisal.latif@intel.com \
--cc=galpress@amazon.com \
--cc=huwei87@hisilicon.com \
--cc=leon@kernel.org \
--cc=linux-rdma@vger.kernel.org \
--cc=liweihang@huawei.com \
--cc=mike.marciniszyn@intel.com \
--cc=mkalderon@marvell.com \
--cc=nareshkumar.pbs@broadcom.com \
--cc=neescoba@cisco.com \
--cc=oulijun@huawei.com \
--cc=pkaustub@cisco.com \
--cc=pv-drivers@vmware.com \
--cc=rpearsonhpe@gmail.com \
--cc=selvin.xavier@broadcom.com \
--cc=shiraz.saleem@intel.com \
--cc=sleybo@amazon.com \
--cc=somnath.kotur@broadcom.com \
--cc=sriharsha.basavapatna@broadcom.com \
--cc=yanjunz@nvidia.com \
--cc=yishaih@nvidia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.