From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.0 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id D10BFC4363D for ; Tue, 6 Oct 2020 20:44:48 +0000 (UTC) Received: from alsa0.perex.cz (alsa0.perex.cz [77.48.224.243]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 4F63920866 for ; Tue, 6 Oct 2020 20:44:47 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=alsa-project.org header.i=@alsa-project.org header.b="Cti1yV2+" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 4F63920866 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=alsa-devel-bounces@alsa-project.org Received: from alsa1.perex.cz (alsa1.perex.cz [207.180.221.201]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by alsa0.perex.cz (Postfix) with ESMTPS id C84EA16D6; Tue, 6 Oct 2020 22:43:55 +0200 (CEST) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa0.perex.cz C84EA16D6 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=alsa-project.org; s=default; t=1602017085; bh=20Ppm3eXqL31Dyc98b9cqyG6F2Kb9nNC7ZM9dhbQrdM=; h=Date:From:To:Subject:References:In-Reply-To:Cc:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From; b=Cti1yV2+0crWNKtE2B1QXGyxXMHsGaRy6vBnxdwn715tV6O363t6EejzG6ne4GkeV FF0nTphw+ReehovZK5BAHGP6A4UhgXT8eE1tPfwCmEUO1H8q2F2M7Idew03WzG4zMH 8Vv9ysSp6n1dHyPykwgiG9utDyX1oGSS50uo4f80= Received: from alsa1.perex.cz (localhost.localdomain [127.0.0.1]) by alsa1.perex.cz (Postfix) with ESMTP id 54D59F80129; Tue, 6 Oct 2020 22:43:55 +0200 (CEST) Received: by alsa1.perex.cz (Postfix, from userid 50401) id 8B0DCF8012A; Tue, 6 Oct 2020 22:43:54 +0200 (CEST) Received: from mail-ot1-f65.google.com (mail-ot1-f65.google.com [209.85.210.65]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by alsa1.perex.cz (Postfix) with ESMTPS id 60E9BF80127 for ; Tue, 6 Oct 2020 22:43:47 +0200 (CEST) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa1.perex.cz 60E9BF80127 Received: by mail-ot1-f65.google.com with SMTP id o8so108798otl.4 for ; Tue, 06 Oct 2020 13:43:47 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=4LMhyTOT+VAAaRU5CJODNmpQONO/RSgV3tZAx3nzv1s=; b=p+26tsGe6AK46+3gP+bNCH2I+NKuzrCE3fgzFiyT/vikVBfolsUZtVH1KXYrsDDQyq +eFUgYRO8NwzIojQbuxFqgUtggfD39qL2HOgy7aiEL0rInfFfk6reANEaUZgzyhMDWWr 99MLOovBARb9ZvbEhN4BA4Vx6kRM1m+hY7nb6cK8tq/htyjxDiWqtE8BkQDxIFL1cOXL nmlAPIiqtAnT0aIJG5fWEXJmLYHG3f9GNJDWuII1yILtESTR1anKInXWiuyBKz0CISJu xsWoZaEd/j85Mf37eKdCcDzfoz4jDb6SATQdbev/r4Tm5NQtIo7TVMZY749J94qGoXnK gdBw== X-Gm-Message-State: AOAM532NXRQKm2YAZFiW+kI3YP5YshEmrWZopx68zzhqFnmfdcEKCSS6 j5dYwj0bSoOTWpzSF5r2NQ== X-Google-Smtp-Source: ABdhPJxcFTHl/Zxl9qzw0vdVU0w3yDGzsHIJvGPcCAWCrYTm8MbmtyeEQMqz1oTH2yBnSUGZBdrqmA== X-Received: by 2002:a05:6830:1be2:: with SMTP id k2mr675329otb.70.1602017026150; Tue, 06 Oct 2020 13:43:46 -0700 (PDT) Received: from xps15 (24-155-109-49.dyn.grandenetworks.net. [24.155.109.49]) by smtp.gmail.com with ESMTPSA id o205sm1822353oig.8.2020.10.06.13.43.45 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 06 Oct 2020 13:43:45 -0700 (PDT) Received: (nullmailer pid 2804669 invoked by uid 1000); Tue, 06 Oct 2020 20:43:44 -0000 Date: Tue, 6 Oct 2020 15:43:44 -0500 From: Rob Herring To: Jiaxin Yu Subject: Re: [PATCH 5/5] dt-bindings: mediatek: mt8192: add mt8192-mt6358-rt1015-rt5682 document Message-ID: <20201006204344.GA2791644@bogus> References: <1601624142-18991-1-git-send-email-jiaxin.yu@mediatek.com> <1601624142-18991-6-git-send-email-jiaxin.yu@mediatek.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1601624142-18991-6-git-send-email-jiaxin.yu@mediatek.com> Cc: devicetree@vger.kernel.org, alsa-devel@alsa-project.org, kuninori.morimoto.gx@renesas.com, shane.chien@mediatek.com, tiwai@suse.com, maowenan@huawei.com, tzungbi@google.com, broonie@kernel.org, linux-mediatek@lists.infradead.org, p.zabel@pengutronix.de, matthias.bgg@gmail.com, linux-arm-kernel@lists.infradead.org X-BeenThere: alsa-devel@alsa-project.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: "Alsa-devel mailing list for ALSA developers - http://www.alsa-project.org" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: alsa-devel-bounces@alsa-project.org Sender: "Alsa-devel" On Fri, Oct 02, 2020 at 03:35:42PM +0800, Jiaxin Yu wrote: > This patch adds document for the machine board with mt6358, rt1015 and rt5682. > > Signed-off-by: Jiaxin Yu > --- > .../sound/mt8192-mt6359-rt1015-rt5682.yaml | 44 +++++++++++++++++++ > 1 file changed, 44 insertions(+) > create mode 100644 Documentation/devicetree/bindings/sound/mt8192-mt6359-rt1015-rt5682.yaml > > diff --git a/Documentation/devicetree/bindings/sound/mt8192-mt6359-rt1015-rt5682.yaml b/Documentation/devicetree/bindings/sound/mt8192-mt6359-rt1015-rt5682.yaml > new file mode 100644 > index 0000000000000..dff5004cd0368 > --- /dev/null > +++ b/Documentation/devicetree/bindings/sound/mt8192-mt6359-rt1015-rt5682.yaml > @@ -0,0 +1,44 @@ > +# SPDX-License-Identifier: GPL-2.0 Dual license new bindings: (GPL-2.0-only OR BSD-2-Clause) > +%YAML 1.2 > +--- > +$id: http://devicetree.org/schemas/sound/mt8192-mt6359-rt1015-rt5682.yaml# > +$schema: http://devicetree.org/meta-schemas/core.yaml# > + > +title: Mediatek MT8192 with MT6359, RT1015 and RT5682 ASoC sound card driver > + > +maintainers: > + - Jiaxin Yu > + - Shane Chien > + > +description: > + This binding describes the MT8192 sound card. > + > +properties: > + compatible: > + contains: Drop this. Other strings shouldn't be allowed. > + const: mediatek,mt8192_mt6359_rt1015_rt5682 Just a list of part numbers? A different codec would be a different compatible and driver? You should have a link to the codec and you can read it's compatible to get what codec you have. > + > + mediatek,platform: > + $ref: "/schemas/types.yaml#/definitions/phandle" > + description: | > + The DT/OF node which is used to specify the link's platform driver. What's "link's platform driver"? A DT doesn't have drivers. > + > +additionalProperties: false > + > +required: > + - compatible > + - mediatek,platform > + > +examples: > + - | > + > + sound: mt8192-sound { > + compatible = "mediatek,mt8192-mt6359-rt1015-rt5682"; > + mediatek,platform = <&afe>; > + pinctrl-names = "aud_clk_mosi_off", > + "aud_clk_mosi_on"; > + pinctrl-0 = <&aud_clk_mosi_off>; > + pinctrl-1 = <&aud_clk_mosi_on>; > + }; > + > +... > -- > 2.18.0 From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.7 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 47394C4363D for ; Tue, 6 Oct 2020 20:44:04 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id CC08620866 for ; Tue, 6 Oct 2020 20:44:03 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="tUnTcA3A" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org CC08620866 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-mediatek-bounces+linux-mediatek=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References:Message-ID: Subject:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=qBIYDzcqbB+CXAJug4WxcL1Sr4yHRproqPzq1yDAGIQ=; b=tUnTcA3AvCfCQcowAvgggGhpX sM7AUvDr7ay4o1AGaG5grT0hm7tbHIpP756tr7oVGzmaMHJ0r++TiEQL60F9zbXDZAzK6+3UQWPP8 pzlXIRNFUC656SUbT2nE8rBlo5iqT27gwhiYUQg0U+S1Zk/V13imR8quk+mBrl0+BScAh7fKVZOGf kIBrvNHY0XCWdyZI3NE238iMhhlDd4yKqkrhNEbliLBRK/X5cZku4/4vML4LKSnkUecQa+LgnbJji 6yhNL2VK4V+P6dBFMbfE5NF8xKDsqAR0mFD8MTtpv/0linZcTVI5L54+87t90DsiamGTF/xkJlqLE 71Tt7ScyQ==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1kPtoO-0001Xn-4K; Tue, 06 Oct 2020 20:43:52 +0000 Received: from mail-ot1-f68.google.com ([209.85.210.68]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1kPtoK-0001Wo-8g; Tue, 06 Oct 2020 20:43:49 +0000 Received: by mail-ot1-f68.google.com with SMTP id 60so115749otw.3; Tue, 06 Oct 2020 13:43:46 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=4LMhyTOT+VAAaRU5CJODNmpQONO/RSgV3tZAx3nzv1s=; b=Ux6+dYl7HBaKSSTbD98iXfw7nnJlOY+IEITuwQpKXcgsWMw61V5HR57vHqOxxf0W4G KVyPIR6Oi/fRInQDvwaBgrzs0lmTt/3UIUkOf/a0UeKA2orwYCpaVFSDICrHVzoxQLYc yIKFiQK2hiTIGpr/iILck4gG9Z1vEzQwdTOS8iZBxfqWqOlg0KYDnrMnAe4IHg0rebN6 3mc82vyS4w16QpSp9flWYEhZQrD3UcRjfASpzeqhlLf5lvmGxG01GxMoYHAzQqGVCs5x vPETpHyy80lnlbRo9s1YevT8eZeKA8t/tz5uHUpY3gxtmDQSoTb3hkwByqXRKoIew5Jf 4KWw== X-Gm-Message-State: AOAM5318H0+Eki/0llM2jrsU5hKr6z0w7aAjUA1egQjGRIdrwWln2n9I OjwDY7VvJd3X+ZGxglBv/6kcuUNoYgUX X-Google-Smtp-Source: ABdhPJxcFTHl/Zxl9qzw0vdVU0w3yDGzsHIJvGPcCAWCrYTm8MbmtyeEQMqz1oTH2yBnSUGZBdrqmA== X-Received: by 2002:a05:6830:1be2:: with SMTP id k2mr675329otb.70.1602017026150; Tue, 06 Oct 2020 13:43:46 -0700 (PDT) Received: from xps15 (24-155-109-49.dyn.grandenetworks.net. [24.155.109.49]) by smtp.gmail.com with ESMTPSA id o205sm1822353oig.8.2020.10.06.13.43.45 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 06 Oct 2020 13:43:45 -0700 (PDT) Received: (nullmailer pid 2804669 invoked by uid 1000); Tue, 06 Oct 2020 20:43:44 -0000 Date: Tue, 6 Oct 2020 15:43:44 -0500 From: Rob Herring To: Jiaxin Yu Subject: Re: [PATCH 5/5] dt-bindings: mediatek: mt8192: add mt8192-mt6358-rt1015-rt5682 document Message-ID: <20201006204344.GA2791644@bogus> References: <1601624142-18991-1-git-send-email-jiaxin.yu@mediatek.com> <1601624142-18991-6-git-send-email-jiaxin.yu@mediatek.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <1601624142-18991-6-git-send-email-jiaxin.yu@mediatek.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20201006_164348_330456_A9BAD4A9 X-CRM114-Status: GOOD ( 19.48 ) X-BeenThere: linux-mediatek@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: devicetree@vger.kernel.org, alsa-devel@alsa-project.org, kuninori.morimoto.gx@renesas.com, shane.chien@mediatek.com, tiwai@suse.com, maowenan@huawei.com, tzungbi@google.com, broonie@kernel.org, linux-mediatek@lists.infradead.org, p.zabel@pengutronix.de, matthias.bgg@gmail.com, linux-arm-kernel@lists.infradead.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "Linux-mediatek" Errors-To: linux-mediatek-bounces+linux-mediatek=archiver.kernel.org@lists.infradead.org On Fri, Oct 02, 2020 at 03:35:42PM +0800, Jiaxin Yu wrote: > This patch adds document for the machine board with mt6358, rt1015 and rt5682. > > Signed-off-by: Jiaxin Yu > --- > .../sound/mt8192-mt6359-rt1015-rt5682.yaml | 44 +++++++++++++++++++ > 1 file changed, 44 insertions(+) > create mode 100644 Documentation/devicetree/bindings/sound/mt8192-mt6359-rt1015-rt5682.yaml > > diff --git a/Documentation/devicetree/bindings/sound/mt8192-mt6359-rt1015-rt5682.yaml b/Documentation/devicetree/bindings/sound/mt8192-mt6359-rt1015-rt5682.yaml > new file mode 100644 > index 0000000000000..dff5004cd0368 > --- /dev/null > +++ b/Documentation/devicetree/bindings/sound/mt8192-mt6359-rt1015-rt5682.yaml > @@ -0,0 +1,44 @@ > +# SPDX-License-Identifier: GPL-2.0 Dual license new bindings: (GPL-2.0-only OR BSD-2-Clause) > +%YAML 1.2 > +--- > +$id: http://devicetree.org/schemas/sound/mt8192-mt6359-rt1015-rt5682.yaml# > +$schema: http://devicetree.org/meta-schemas/core.yaml# > + > +title: Mediatek MT8192 with MT6359, RT1015 and RT5682 ASoC sound card driver > + > +maintainers: > + - Jiaxin Yu > + - Shane Chien > + > +description: > + This binding describes the MT8192 sound card. > + > +properties: > + compatible: > + contains: Drop this. Other strings shouldn't be allowed. > + const: mediatek,mt8192_mt6359_rt1015_rt5682 Just a list of part numbers? A different codec would be a different compatible and driver? You should have a link to the codec and you can read it's compatible to get what codec you have. > + > + mediatek,platform: > + $ref: "/schemas/types.yaml#/definitions/phandle" > + description: | > + The DT/OF node which is used to specify the link's platform driver. What's "link's platform driver"? A DT doesn't have drivers. > + > +additionalProperties: false > + > +required: > + - compatible > + - mediatek,platform > + > +examples: > + - | > + > + sound: mt8192-sound { > + compatible = "mediatek,mt8192-mt6359-rt1015-rt5682"; > + mediatek,platform = <&afe>; > + pinctrl-names = "aud_clk_mosi_off", > + "aud_clk_mosi_on"; > + pinctrl-0 = <&aud_clk_mosi_off>; > + pinctrl-1 = <&aud_clk_mosi_on>; > + }; > + > +... > -- > 2.18.0 _______________________________________________ Linux-mediatek mailing list Linux-mediatek@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-mediatek From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.7 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id B7CA4C4363D for ; Tue, 6 Oct 2020 20:45:28 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 4C6E320870 for ; Tue, 6 Oct 2020 20:45:28 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="JBp/Anle" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 4C6E320870 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References:Message-ID: Subject:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=DD179LufRrO2mSSKJgKuZQ8jWsy+x0VhmF5kGu6inKM=; b=JBp/AnleN4pKkpR+4r62qJ3zl a1/6YDAGSQe23+scsKbj7y6dLwz3D2RZhqbLfYYBIggipLtedGfyPZCie6udoYAgwOMlmlBL9eW7V HRGNX1ofG8w8OWAdFICBfW5+Ag/pWE1vkYe2GSp6xN605O6JzcxplTYF8ikwH2O3q2nCHZS4gJL68 aqsx+wXrVDygIqt6J8GBAdiOuiAEIuMTWKk3yX9X9dVMQXpAJGSFr6IWAwj6l1snDNPMtuF21Afd8 u0Y5m/ZQTWRkxD6nGRyrMviGH3pjIiH6HDYEiOEnu5hxBCntorL4lZWsITRG+OjrMfqrRbyjJHc28 JZBaMnc0g==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1kPtoM-0001XW-Px; Tue, 06 Oct 2020 20:43:50 +0000 Received: from mail-ot1-f68.google.com ([209.85.210.68]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1kPtoK-0001Wo-8g; Tue, 06 Oct 2020 20:43:49 +0000 Received: by mail-ot1-f68.google.com with SMTP id 60so115749otw.3; Tue, 06 Oct 2020 13:43:46 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=4LMhyTOT+VAAaRU5CJODNmpQONO/RSgV3tZAx3nzv1s=; b=Ux6+dYl7HBaKSSTbD98iXfw7nnJlOY+IEITuwQpKXcgsWMw61V5HR57vHqOxxf0W4G KVyPIR6Oi/fRInQDvwaBgrzs0lmTt/3UIUkOf/a0UeKA2orwYCpaVFSDICrHVzoxQLYc yIKFiQK2hiTIGpr/iILck4gG9Z1vEzQwdTOS8iZBxfqWqOlg0KYDnrMnAe4IHg0rebN6 3mc82vyS4w16QpSp9flWYEhZQrD3UcRjfASpzeqhlLf5lvmGxG01GxMoYHAzQqGVCs5x vPETpHyy80lnlbRo9s1YevT8eZeKA8t/tz5uHUpY3gxtmDQSoTb3hkwByqXRKoIew5Jf 4KWw== X-Gm-Message-State: AOAM5318H0+Eki/0llM2jrsU5hKr6z0w7aAjUA1egQjGRIdrwWln2n9I OjwDY7VvJd3X+ZGxglBv/6kcuUNoYgUX X-Google-Smtp-Source: ABdhPJxcFTHl/Zxl9qzw0vdVU0w3yDGzsHIJvGPcCAWCrYTm8MbmtyeEQMqz1oTH2yBnSUGZBdrqmA== X-Received: by 2002:a05:6830:1be2:: with SMTP id k2mr675329otb.70.1602017026150; Tue, 06 Oct 2020 13:43:46 -0700 (PDT) Received: from xps15 (24-155-109-49.dyn.grandenetworks.net. [24.155.109.49]) by smtp.gmail.com with ESMTPSA id o205sm1822353oig.8.2020.10.06.13.43.45 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 06 Oct 2020 13:43:45 -0700 (PDT) Received: (nullmailer pid 2804669 invoked by uid 1000); Tue, 06 Oct 2020 20:43:44 -0000 Date: Tue, 6 Oct 2020 15:43:44 -0500 From: Rob Herring To: Jiaxin Yu Subject: Re: [PATCH 5/5] dt-bindings: mediatek: mt8192: add mt8192-mt6358-rt1015-rt5682 document Message-ID: <20201006204344.GA2791644@bogus> References: <1601624142-18991-1-git-send-email-jiaxin.yu@mediatek.com> <1601624142-18991-6-git-send-email-jiaxin.yu@mediatek.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <1601624142-18991-6-git-send-email-jiaxin.yu@mediatek.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20201006_164348_330456_A9BAD4A9 X-CRM114-Status: GOOD ( 19.48 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: devicetree@vger.kernel.org, alsa-devel@alsa-project.org, kuninori.morimoto.gx@renesas.com, shane.chien@mediatek.com, tiwai@suse.com, maowenan@huawei.com, tzungbi@google.com, broonie@kernel.org, linux-mediatek@lists.infradead.org, p.zabel@pengutronix.de, matthias.bgg@gmail.com, linux-arm-kernel@lists.infradead.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Fri, Oct 02, 2020 at 03:35:42PM +0800, Jiaxin Yu wrote: > This patch adds document for the machine board with mt6358, rt1015 and rt5682. > > Signed-off-by: Jiaxin Yu > --- > .../sound/mt8192-mt6359-rt1015-rt5682.yaml | 44 +++++++++++++++++++ > 1 file changed, 44 insertions(+) > create mode 100644 Documentation/devicetree/bindings/sound/mt8192-mt6359-rt1015-rt5682.yaml > > diff --git a/Documentation/devicetree/bindings/sound/mt8192-mt6359-rt1015-rt5682.yaml b/Documentation/devicetree/bindings/sound/mt8192-mt6359-rt1015-rt5682.yaml > new file mode 100644 > index 0000000000000..dff5004cd0368 > --- /dev/null > +++ b/Documentation/devicetree/bindings/sound/mt8192-mt6359-rt1015-rt5682.yaml > @@ -0,0 +1,44 @@ > +# SPDX-License-Identifier: GPL-2.0 Dual license new bindings: (GPL-2.0-only OR BSD-2-Clause) > +%YAML 1.2 > +--- > +$id: http://devicetree.org/schemas/sound/mt8192-mt6359-rt1015-rt5682.yaml# > +$schema: http://devicetree.org/meta-schemas/core.yaml# > + > +title: Mediatek MT8192 with MT6359, RT1015 and RT5682 ASoC sound card driver > + > +maintainers: > + - Jiaxin Yu > + - Shane Chien > + > +description: > + This binding describes the MT8192 sound card. > + > +properties: > + compatible: > + contains: Drop this. Other strings shouldn't be allowed. > + const: mediatek,mt8192_mt6359_rt1015_rt5682 Just a list of part numbers? A different codec would be a different compatible and driver? You should have a link to the codec and you can read it's compatible to get what codec you have. > + > + mediatek,platform: > + $ref: "/schemas/types.yaml#/definitions/phandle" > + description: | > + The DT/OF node which is used to specify the link's platform driver. What's "link's platform driver"? A DT doesn't have drivers. > + > +additionalProperties: false > + > +required: > + - compatible > + - mediatek,platform > + > +examples: > + - | > + > + sound: mt8192-sound { > + compatible = "mediatek,mt8192-mt6359-rt1015-rt5682"; > + mediatek,platform = <&afe>; > + pinctrl-names = "aud_clk_mosi_off", > + "aud_clk_mosi_on"; > + pinctrl-0 = <&aud_clk_mosi_off>; > + pinctrl-1 = <&aud_clk_mosi_on>; > + }; > + > +... > -- > 2.18.0 _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.8 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 829BDC4363D for ; Tue, 6 Oct 2020 20:43:49 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 25CA02087E for ; Tue, 6 Oct 2020 20:43:49 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1602017029; bh=20Ppm3eXqL31Dyc98b9cqyG6F2Kb9nNC7ZM9dhbQrdM=; h=Date:From:To:Cc:Subject:References:In-Reply-To:List-ID:From; b=VzqMeHKSB2srzlAhucnEZfi86HI7w1n2GAJCAHwTR7dySPgLI5p0mqnG/rG4XRBYn ulv+0jM0mdt5g2WEB3ZX0oedsQPg93Ko3YsM+btlH2VOeHF3Fcr4uDA2axY1TxHrsn 0lUr3snqK7chA2VxivqzeGnUv9uwBIdYun029OiI= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727176AbgJFUns (ORCPT ); Tue, 6 Oct 2020 16:43:48 -0400 Received: from mail-ot1-f65.google.com ([209.85.210.65]:44428 "EHLO mail-ot1-f65.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726997AbgJFUns (ORCPT ); Tue, 6 Oct 2020 16:43:48 -0400 Received: by mail-ot1-f65.google.com with SMTP id a2so55780otr.11 for ; Tue, 06 Oct 2020 13:43:46 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=4LMhyTOT+VAAaRU5CJODNmpQONO/RSgV3tZAx3nzv1s=; b=YUz1AITTbziHuhOke2i1BNX9eDf0E3EEoqMfsYLSNEpWnfRn6R1cl/YgsbVSfk6VsE qtfBeSFUI2Ky7fI+KWX3MtYH4wNhV8QFS8i7utZ4EEZgch/6CIcq0DIGyJn2YreYrt7B HtXkQPrXIf+XGHkVl8JO1xD38G73HUULfLJSn+D2ijMIfW3V6RbSXwSudvK8/XTPwqAf 1BuWMsEtxKXeKYP7+NQaVimYf/fkOdm6XfTrbTWbpDXjAjjDCuJOINzJGE9CtYEzljxj nTMyi3h9mGoRCzUubZZdQpj5g6NOOWioyKxetPgpqY/fEBQ6rC+8oJkFR2DPio/rbQ9r QOZA== X-Gm-Message-State: AOAM5314Ow7Xo91LIEbZnsSBFPIL4Z/QES7brAQaZpek06RKGv762LTY hNqyHTHfPpO9VYmcPUGjNQ== X-Google-Smtp-Source: ABdhPJxcFTHl/Zxl9qzw0vdVU0w3yDGzsHIJvGPcCAWCrYTm8MbmtyeEQMqz1oTH2yBnSUGZBdrqmA== X-Received: by 2002:a05:6830:1be2:: with SMTP id k2mr675329otb.70.1602017026150; Tue, 06 Oct 2020 13:43:46 -0700 (PDT) Received: from xps15 (24-155-109-49.dyn.grandenetworks.net. [24.155.109.49]) by smtp.gmail.com with ESMTPSA id o205sm1822353oig.8.2020.10.06.13.43.45 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 06 Oct 2020 13:43:45 -0700 (PDT) Received: (nullmailer pid 2804669 invoked by uid 1000); Tue, 06 Oct 2020 20:43:44 -0000 Date: Tue, 6 Oct 2020 15:43:44 -0500 From: Rob Herring To: Jiaxin Yu Cc: broonie@kernel.org, tiwai@suse.com, matthias.bgg@gmail.com, p.zabel@pengutronix.de, tzungbi@google.com, alsa-devel@alsa-project.org, linux-arm-kernel@lists.infradead.org, linux-mediatek@lists.infradead.org, devicetree@vger.kernel.org, shane.chien@mediatek.com, kuninori.morimoto.gx@renesas.com, maowenan@huawei.com Subject: Re: [PATCH 5/5] dt-bindings: mediatek: mt8192: add mt8192-mt6358-rt1015-rt5682 document Message-ID: <20201006204344.GA2791644@bogus> References: <1601624142-18991-1-git-send-email-jiaxin.yu@mediatek.com> <1601624142-18991-6-git-send-email-jiaxin.yu@mediatek.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1601624142-18991-6-git-send-email-jiaxin.yu@mediatek.com> Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org On Fri, Oct 02, 2020 at 03:35:42PM +0800, Jiaxin Yu wrote: > This patch adds document for the machine board with mt6358, rt1015 and rt5682. > > Signed-off-by: Jiaxin Yu > --- > .../sound/mt8192-mt6359-rt1015-rt5682.yaml | 44 +++++++++++++++++++ > 1 file changed, 44 insertions(+) > create mode 100644 Documentation/devicetree/bindings/sound/mt8192-mt6359-rt1015-rt5682.yaml > > diff --git a/Documentation/devicetree/bindings/sound/mt8192-mt6359-rt1015-rt5682.yaml b/Documentation/devicetree/bindings/sound/mt8192-mt6359-rt1015-rt5682.yaml > new file mode 100644 > index 0000000000000..dff5004cd0368 > --- /dev/null > +++ b/Documentation/devicetree/bindings/sound/mt8192-mt6359-rt1015-rt5682.yaml > @@ -0,0 +1,44 @@ > +# SPDX-License-Identifier: GPL-2.0 Dual license new bindings: (GPL-2.0-only OR BSD-2-Clause) > +%YAML 1.2 > +--- > +$id: http://devicetree.org/schemas/sound/mt8192-mt6359-rt1015-rt5682.yaml# > +$schema: http://devicetree.org/meta-schemas/core.yaml# > + > +title: Mediatek MT8192 with MT6359, RT1015 and RT5682 ASoC sound card driver > + > +maintainers: > + - Jiaxin Yu > + - Shane Chien > + > +description: > + This binding describes the MT8192 sound card. > + > +properties: > + compatible: > + contains: Drop this. Other strings shouldn't be allowed. > + const: mediatek,mt8192_mt6359_rt1015_rt5682 Just a list of part numbers? A different codec would be a different compatible and driver? You should have a link to the codec and you can read it's compatible to get what codec you have. > + > + mediatek,platform: > + $ref: "/schemas/types.yaml#/definitions/phandle" > + description: | > + The DT/OF node which is used to specify the link's platform driver. What's "link's platform driver"? A DT doesn't have drivers. > + > +additionalProperties: false > + > +required: > + - compatible > + - mediatek,platform > + > +examples: > + - | > + > + sound: mt8192-sound { > + compatible = "mediatek,mt8192-mt6359-rt1015-rt5682"; > + mediatek,platform = <&afe>; > + pinctrl-names = "aud_clk_mosi_off", > + "aud_clk_mosi_on"; > + pinctrl-0 = <&aud_clk_mosi_off>; > + pinctrl-1 = <&aud_clk_mosi_on>; > + }; > + > +... > -- > 2.18.0