From: kernel test robot <lkp@intel.com>
To: kbuild-all@lists.01.org
Subject: Re: [PATCH rdma-next v2] RDMA: Explicitly pass in the dma_device to ib_register_device
Date: Tue, 06 Oct 2020 22:34:40 +0800 [thread overview]
Message-ID: <202010062250.EdCw8bmN-lkp@intel.com> (raw)
In-Reply-To: <20201006073229.2347811-1-leon@kernel.org>
[-- Attachment #1: Type: text/plain, Size: 4465 bytes --]
Hi Leon,
I love your patch! Yet something to improve:
[auto build test ERROR on rdma/for-next]
[also build test ERROR on v5.9-rc8 next-20201002]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch]
url: https://github.com/0day-ci/linux/commits/Leon-Romanovsky/RDMA-Explicitly-pass-in-the-dma_device-to-ib_register_device/20201006-153413
base: https://git.kernel.org/pub/scm/linux/kernel/git/rdma/rdma.git for-next
config: riscv-randconfig-p002-20201005 (attached as .config)
compiler: riscv32-linux-gcc (GCC) 9.3.0
reproduce (this is a W=1 build):
wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
chmod +x ~/bin/make.cross
# https://github.com/0day-ci/linux/commit/3b19b99ff8c7cbe60a42582791a53bcaed52849e
git remote add linux-review https://github.com/0day-ci/linux
git fetch --no-tags linux-review Leon-Romanovsky/RDMA-Explicitly-pass-in-the-dma_device-to-ib_register_device/20201006-153413
git checkout 3b19b99ff8c7cbe60a42582791a53bcaed52849e
# save the attached .config to linux build tree
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-9.3.0 make.cross ARCH=riscv
If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>
All errors (new ones prefixed by >>):
riscv32-linux-ld: drivers/infiniband/core/device.o: in function `assign_name':
>> drivers/infiniband/core/device.c:1157: undefined reference to `dma_virt_ops'
>> riscv32-linux-ld: drivers/infiniband/core/device.c:1157: undefined reference to `dma_virt_ops'
vim +1157 drivers/infiniband/core/device.c
4e0f7b9070726a3 Parav Pandit 2019-02-26 1145
ecc82c53f9a4ce0 Leon Romanovsky 2017-06-18 1146 /*
d0899892edd0897 Jason Gunthorpe 2019-02-12 1147 * Assign the unique string device name and the unique device index. This is
d0899892edd0897 Jason Gunthorpe 2019-02-12 1148 * undone by ib_dealloc_device.
ecc82c53f9a4ce0 Leon Romanovsky 2017-06-18 1149 */
0df91bb67334eeb Jason Gunthorpe 2019-02-06 1150 static int assign_name(struct ib_device *device, const char *name)
0df91bb67334eeb Jason Gunthorpe 2019-02-06 1151 {
0df91bb67334eeb Jason Gunthorpe 2019-02-06 1152 static u32 last_id;
0df91bb67334eeb Jason Gunthorpe 2019-02-06 1153 int ret;
0df91bb67334eeb Jason Gunthorpe 2019-02-06 1154
921eab1143aadf9 Jason Gunthorpe 2019-02-06 1155 down_write(&devices_rwsem);
0df91bb67334eeb Jason Gunthorpe 2019-02-06 1156 /* Assign a unique name to the device */
0df91bb67334eeb Jason Gunthorpe 2019-02-06 @1157 if (strchr(name, '%'))
0df91bb67334eeb Jason Gunthorpe 2019-02-06 1158 ret = alloc_name(device, name);
0df91bb67334eeb Jason Gunthorpe 2019-02-06 1159 else
0df91bb67334eeb Jason Gunthorpe 2019-02-06 1160 ret = dev_set_name(&device->dev, name);
0df91bb67334eeb Jason Gunthorpe 2019-02-06 1161 if (ret)
0df91bb67334eeb Jason Gunthorpe 2019-02-06 1162 goto out;
ecc82c53f9a4ce0 Leon Romanovsky 2017-06-18 1163
0df91bb67334eeb Jason Gunthorpe 2019-02-06 1164 if (__ib_device_get_by_name(dev_name(&device->dev))) {
0df91bb67334eeb Jason Gunthorpe 2019-02-06 1165 ret = -ENFILE;
0df91bb67334eeb Jason Gunthorpe 2019-02-06 1166 goto out;
0df91bb67334eeb Jason Gunthorpe 2019-02-06 1167 }
0df91bb67334eeb Jason Gunthorpe 2019-02-06 1168 strlcpy(device->name, dev_name(&device->dev), IB_DEVICE_NAME_MAX);
0df91bb67334eeb Jason Gunthorpe 2019-02-06 1169
ea295481b6e313b Linus Torvalds 2019-03-11 1170 ret = xa_alloc_cyclic(&devices, &device->index, device, xa_limit_31b,
ea295481b6e313b Linus Torvalds 2019-03-11 1171 &last_id, GFP_KERNEL);
ea295481b6e313b Linus Torvalds 2019-03-11 1172 if (ret > 0)
0df91bb67334eeb Jason Gunthorpe 2019-02-06 1173 ret = 0;
921eab1143aadf9 Jason Gunthorpe 2019-02-06 1174
0df91bb67334eeb Jason Gunthorpe 2019-02-06 1175 out:
921eab1143aadf9 Jason Gunthorpe 2019-02-06 1176 up_write(&devices_rwsem);
0df91bb67334eeb Jason Gunthorpe 2019-02-06 1177 return ret;
ecc82c53f9a4ce0 Leon Romanovsky 2017-06-18 1178 }
0df91bb67334eeb Jason Gunthorpe 2019-02-06 1179
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all(a)lists.01.org
[-- Attachment #2: config.gz --]
[-- Type: application/gzip, Size: 31655 bytes --]
prev parent reply other threads:[~2020-10-06 14:34 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-10-06 7:32 [PATCH rdma-next v2] RDMA: Explicitly pass in the dma_device to ib_register_device Leon Romanovsky
2020-10-06 7:35 ` Christoph Hellwig
2020-10-06 7:53 ` Leon Romanovsky
2020-10-06 7:57 ` Christoph Hellwig
2020-10-06 8:13 ` Leon Romanovsky
2020-10-06 12:05 ` Jason Gunthorpe
2020-10-06 12:42 ` kernel test robot
2020-10-06 14:34 ` kernel test robot [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=202010062250.EdCw8bmN-lkp@intel.com \
--to=lkp@intel.com \
--cc=kbuild-all@lists.01.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.