Re: [Intel-gfx] [PATCH 18/61] drm/i915: Make ring submission compatible with obj->mm.lock removal.

[kernel test robot <lkp@intel.com>]

[-- Attachment #1: Type: text/plain, Size: 4158 bytes --]

CC: kbuild-all(a)lists.01.org
In-Reply-To: <20201002125939.50817-19-maarten.lankhorst@linux.intel.com>
References: <20201002125939.50817-19-maarten.lankhorst@linux.intel.com>
TO: Maarten Lankhorst <maarten.lankhorst@linux.intel.com>

Hi Maarten,

I love your patch! Perhaps something to improve:

[auto build test WARNING on 4e9a7e28ea34e4b14e66cbc53fc004e4a93f5168]

url:    https://github.com/0day-ci/linux/commits/Maarten-Lankhorst/drm-i915-Remove-obj-mm-lock/20201002-210318
base:    4e9a7e28ea34e4b14e66cbc53fc004e4a93f5168
:::::: branch date: 5 days ago
:::::: commit date: 5 days ago
config: x86_64-randconfig-m001-20201005 (attached as .config)
compiler: gcc-9 (Debian 9.3.0-15) 9.3.0

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>
Reported-by: Dan Carpenter <dan.carpenter@oracle.com>

New smatch warnings:
drivers/gpu/drm/i915/gt/intel_ring_submission.c:1233 gen7_ctx_vma() warn: passing zero to 'ERR_PTR'
drivers/gpu/drm/i915/gt/intel_ring_submission.c:1251 gen7_ctx_vma() warn: passing zero to 'ERR_CAST'

Old smatch warnings:
drivers/gpu/drm/i915/gem/i915_gem_object.h:132 __i915_gem_object_lock() error: we previously assumed 'ww' could be null (see line 124)

vim +/ERR_PTR +1233 drivers/gpu/drm/i915/gt/intel_ring_submission.c

ee2413eeed767d1 Mika Kuoppala     2020-03-06  1221  
0ce63e139392e8d Maarten Lankhorst 2020-10-02  1222  static struct i915_vma *gen7_ctx_vma(struct intel_engine_cs *engine)
0ce63e139392e8d Maarten Lankhorst 2020-10-02  1223  {
0ce63e139392e8d Maarten Lankhorst 2020-10-02  1224  	struct drm_i915_gem_object *obj;
0ce63e139392e8d Maarten Lankhorst 2020-10-02  1225  	struct i915_vma *vma;
0ce63e139392e8d Maarten Lankhorst 2020-10-02  1226  	int size, err;
0ce63e139392e8d Maarten Lankhorst 2020-10-02  1227  
0ce63e139392e8d Maarten Lankhorst 2020-10-02  1228  	if (!IS_HASWELL(engine->i915) || engine->class != RENDER_CLASS)
0ce63e139392e8d Maarten Lankhorst 2020-10-02  1229  		return 0;
0ce63e139392e8d Maarten Lankhorst 2020-10-02  1230  
0ce63e139392e8d Maarten Lankhorst 2020-10-02  1231  	err = gen7_ctx_switch_bb_setup(engine, NULL /* probe size */);
0ce63e139392e8d Maarten Lankhorst 2020-10-02  1232  	if (err <= 0)
0ce63e139392e8d Maarten Lankhorst 2020-10-02 @1233  		return ERR_PTR(err);
0ce63e139392e8d Maarten Lankhorst 2020-10-02  1234  
0ce63e139392e8d Maarten Lankhorst 2020-10-02  1235  	size = ALIGN(err, PAGE_SIZE);
0ce63e139392e8d Maarten Lankhorst 2020-10-02  1236  
0ce63e139392e8d Maarten Lankhorst 2020-10-02  1237  	obj = i915_gem_object_create_internal(engine->i915, size);
0ce63e139392e8d Maarten Lankhorst 2020-10-02  1238  	if (IS_ERR(obj))
0ce63e139392e8d Maarten Lankhorst 2020-10-02  1239  		return ERR_CAST(obj);
0ce63e139392e8d Maarten Lankhorst 2020-10-02  1240  
0ce63e139392e8d Maarten Lankhorst 2020-10-02  1241  	vma = i915_vma_instance(obj, engine->gt->vm, NULL);
0ce63e139392e8d Maarten Lankhorst 2020-10-02  1242  	if (IS_ERR(vma)) {
0ce63e139392e8d Maarten Lankhorst 2020-10-02  1243  		i915_gem_object_put(obj);
0ce63e139392e8d Maarten Lankhorst 2020-10-02  1244  		return ERR_CAST(vma);
0ce63e139392e8d Maarten Lankhorst 2020-10-02  1245  	}
0ce63e139392e8d Maarten Lankhorst 2020-10-02  1246  
0ce63e139392e8d Maarten Lankhorst 2020-10-02  1247  	vma->private = intel_context_create(engine); /* dummy residuals */
0ce63e139392e8d Maarten Lankhorst 2020-10-02  1248  	if (IS_ERR(vma->private)) {
0ce63e139392e8d Maarten Lankhorst 2020-10-02  1249  		vma->private = NULL;
0ce63e139392e8d Maarten Lankhorst 2020-10-02  1250  		i915_gem_object_put(obj);
0ce63e139392e8d Maarten Lankhorst 2020-10-02 @1251  		return ERR_CAST(vma->private);
0ce63e139392e8d Maarten Lankhorst 2020-10-02  1252  	}
0ce63e139392e8d Maarten Lankhorst 2020-10-02  1253  
0ce63e139392e8d Maarten Lankhorst 2020-10-02  1254  	return vma;
0ce63e139392e8d Maarten Lankhorst 2020-10-02  1255  }
0ce63e139392e8d Maarten Lankhorst 2020-10-02  1256  

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all(a)lists.01.org

[-- Attachment #2: config.gz --]
[-- Type: application/gzip, Size: 37450 bytes --]