From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.5 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id E2F1AC41604 for ; Wed, 7 Oct 2020 13:36:41 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 68B3920870 for ; Wed, 7 Oct 2020 13:36:41 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="AZib6rH3"; dkim=fail reason="signature verification failed" (1024-bit key) header.d=ideasonboard.com header.i=@ideasonboard.com header.b="fjQ6DIn+" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 68B3920870 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=ideasonboard.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References:Message-ID: Subject:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=StRTTA304kx40M7aOL20Wmm/Di8wI3gs1laIIKhLHLA=; b=AZib6rH3TbDdOqe3OVDZQ8ijr g0bwKHkke2bkPTsS0XIjI7/o4VRhlV9tDkR86OVD3F4T4OaPniKLnI3Uz5xl5/yimUhnYR7Y49rb3 r9p3epnf/BBEr083O3NzpxGe4JNWlo4YEXHr2JL8XiUYd3yUAA1wI8yTXYsFHuWAq1M5Ah+6mtU3q tMhq2Jd/tus98ia8LJzfLjZwnB8AXx2BBXpsLupT4RAPjJpTL7BXGeO4jEyIR2BMWNpOs588Dzaie M1U+K0Wpwdrk3kywrEC2b7InYcCt/1925GklG4FWVTqCScfNKenYxEqqrx746R7xtYlrX8UYX58ZP 9fP/IwS/A==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1kQ9ah-0004PS-Nj; Wed, 07 Oct 2020 13:34:47 +0000 Received: from perceval.ideasonboard.com ([2001:4b98:dc2:55:216:3eff:fef7:d647]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1kQ9ad-0004NJ-Fo for linux-arm-kernel@lists.infradead.org; Wed, 07 Oct 2020 13:34:45 +0000 Received: from pendragon.ideasonboard.com (62-78-145-57.bb.dnainternet.fi [62.78.145.57]) by perceval.ideasonboard.com (Postfix) with ESMTPSA id 099089DA; Wed, 7 Oct 2020 15:34:38 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com; s=mail; t=1602077679; bh=hZlEqx/vaXfkYUgExhxZr4ZIbI7/aIOnYhDz3m9bACI=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=fjQ6DIn+iG7bu1d5d60fVSmz/gJc+afU4oAlbJ92KpS6xhp2XaDMsix7kG/u/h8PZ MaJqsr2r9SmtKo88dKksdl7UP4bjoaCrFVDv3k8+FDr4m7SZu2VAVR/TgY2EDxvBcc f4qELifpIIlJCRXNLJz0SzUnhQMG9XHj1mJFFSnY= Date: Wed, 7 Oct 2020 16:33:57 +0300 From: Laurent Pinchart To: Marek Vasut Subject: Re: [PATCH v2 1/7] dt-bindings: display: mxsfb: Convert binding to YAML Message-ID: <20201007133357.GJ3937@pendragon.ideasonboard.com> References: <20201007012438.27970-1-laurent.pinchart@ideasonboard.com> <20201007012438.27970-2-laurent.pinchart@ideasonboard.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20201007_093443_650293_C28B86EA X-CRM114-Status: GOOD ( 20.32 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: devicetree@vger.kernel.org, Guido =?utf-8?Q?G=C3=BCnther?= , Stefan Agner , Rob Herring , dri-devel@lists.freedesktop.org, Pengutronix Kernel Team , linux-arm-kernel@lists.infradead.org, Lucas Stach Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hi Marek, On Wed, Oct 07, 2020 at 10:55:24AM +0200, Marek Vasut wrote: > On 10/7/20 10:43 AM, Lucas Stach wrote: > > On Mi, 2020-10-07 at 10:32 +0200, Marek Vasut wrote: > >> On 10/7/20 3:24 AM, Laurent Pinchart wrote: > >> [...] > >>> +properties: > >>> + compatible: > >>> + enum: > >>> + - fsl,imx23-lcdif > >>> + - fsl,imx28-lcdif > >>> + - fsl,imx6sx-lcdif > >>> + - fsl,imx8mq-lcdif > >> > >> There is no fsl,imx8mq-lcdif in drivers/gpu/drm/mxsfb/mxsfb_drv.c, > >> so the DT must specify compatible = "fsl,imx8mq-lcdif", > >> "fsl,imx28-lcdif" (since imx28 is the oldest SoC with LCDIF V4). > >> > >> Should the compatible be added to drivers/gpu/drm/mxsfb/mxsfb_drv.c or > >> dropped from the YAML file or neither ? > > > > Neither. As far as we know the block is compatible, so the DT should > > claim that it's compatible to "fsl,imx28-lcdif". However we don't know > > if there are any surprises, so we add the SoC specific compatible to be > > able to change the driver matching later without changing the DT if the > > need arises. For the DT validation to pass the SoC specific compatible > > needs to be documented, even if it currently unused by the driver. > > What in that binding says you should specify compatible = > "fsl,imx8mq-lcdif", "fsl,imx28-lcdif"; and not e.g. "fsl,imx8mq-lcdif", > "fsl,imx23-lcdif" or simply "fsl,imx8mq-lcdif" ? Nothing, until the next patch :-) This patch only handles the YAML conversion but doesn't fix issues. -- Regards, Laurent Pinchart _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.9 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 77879C4363D for ; Wed, 7 Oct 2020 13:34:42 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 1B44921531 for ; Wed, 7 Oct 2020 13:34:42 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=ideasonboard.com header.i=@ideasonboard.com header.b="fjQ6DIn+" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728467AbgJGNel (ORCPT ); Wed, 7 Oct 2020 09:34:41 -0400 Received: from perceval.ideasonboard.com ([213.167.242.64]:54926 "EHLO perceval.ideasonboard.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728177AbgJGNel (ORCPT ); Wed, 7 Oct 2020 09:34:41 -0400 Received: from pendragon.ideasonboard.com (62-78-145-57.bb.dnainternet.fi [62.78.145.57]) by perceval.ideasonboard.com (Postfix) with ESMTPSA id 099089DA; Wed, 7 Oct 2020 15:34:38 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com; s=mail; t=1602077679; bh=hZlEqx/vaXfkYUgExhxZr4ZIbI7/aIOnYhDz3m9bACI=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=fjQ6DIn+iG7bu1d5d60fVSmz/gJc+afU4oAlbJ92KpS6xhp2XaDMsix7kG/u/h8PZ MaJqsr2r9SmtKo88dKksdl7UP4bjoaCrFVDv3k8+FDr4m7SZu2VAVR/TgY2EDxvBcc f4qELifpIIlJCRXNLJz0SzUnhQMG9XHj1mJFFSnY= Date: Wed, 7 Oct 2020 16:33:57 +0300 From: Laurent Pinchart To: Marek Vasut Cc: Lucas Stach , dri-devel@lists.freedesktop.org, devicetree@vger.kernel.org, Guido =?utf-8?Q?G=C3=BCnther?= , Stefan Agner , Rob Herring , Pengutronix Kernel Team , linux-arm-kernel@lists.infradead.org Subject: Re: [PATCH v2 1/7] dt-bindings: display: mxsfb: Convert binding to YAML Message-ID: <20201007133357.GJ3937@pendragon.ideasonboard.com> References: <20201007012438.27970-1-laurent.pinchart@ideasonboard.com> <20201007012438.27970-2-laurent.pinchart@ideasonboard.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org Hi Marek, On Wed, Oct 07, 2020 at 10:55:24AM +0200, Marek Vasut wrote: > On 10/7/20 10:43 AM, Lucas Stach wrote: > > On Mi, 2020-10-07 at 10:32 +0200, Marek Vasut wrote: > >> On 10/7/20 3:24 AM, Laurent Pinchart wrote: > >> [...] > >>> +properties: > >>> + compatible: > >>> + enum: > >>> + - fsl,imx23-lcdif > >>> + - fsl,imx28-lcdif > >>> + - fsl,imx6sx-lcdif > >>> + - fsl,imx8mq-lcdif > >> > >> There is no fsl,imx8mq-lcdif in drivers/gpu/drm/mxsfb/mxsfb_drv.c, > >> so the DT must specify compatible = "fsl,imx8mq-lcdif", > >> "fsl,imx28-lcdif" (since imx28 is the oldest SoC with LCDIF V4). > >> > >> Should the compatible be added to drivers/gpu/drm/mxsfb/mxsfb_drv.c or > >> dropped from the YAML file or neither ? > > > > Neither. As far as we know the block is compatible, so the DT should > > claim that it's compatible to "fsl,imx28-lcdif". However we don't know > > if there are any surprises, so we add the SoC specific compatible to be > > able to change the driver matching later without changing the DT if the > > need arises. For the DT validation to pass the SoC specific compatible > > needs to be documented, even if it currently unused by the driver. > > What in that binding says you should specify compatible = > "fsl,imx8mq-lcdif", "fsl,imx28-lcdif"; and not e.g. "fsl,imx8mq-lcdif", > "fsl,imx23-lcdif" or simply "fsl,imx8mq-lcdif" ? Nothing, until the next patch :-) This patch only handles the YAML conversion but doesn't fix issues. -- Regards, Laurent Pinchart From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.5 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 74D8DC41604 for ; Wed, 7 Oct 2020 13:34:43 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 066642087D for ; Wed, 7 Oct 2020 13:34:42 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (1024-bit key) header.d=ideasonboard.com header.i=@ideasonboard.com header.b="fjQ6DIn+" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 066642087D Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=ideasonboard.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=dri-devel-bounces@lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 6B35A6E8E9; Wed, 7 Oct 2020 13:34:42 +0000 (UTC) Received: from perceval.ideasonboard.com (perceval.ideasonboard.com [IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647]) by gabe.freedesktop.org (Postfix) with ESMTPS id 2516C6E8E9 for ; Wed, 7 Oct 2020 13:34:41 +0000 (UTC) Received: from pendragon.ideasonboard.com (62-78-145-57.bb.dnainternet.fi [62.78.145.57]) by perceval.ideasonboard.com (Postfix) with ESMTPSA id 099089DA; Wed, 7 Oct 2020 15:34:38 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com; s=mail; t=1602077679; bh=hZlEqx/vaXfkYUgExhxZr4ZIbI7/aIOnYhDz3m9bACI=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=fjQ6DIn+iG7bu1d5d60fVSmz/gJc+afU4oAlbJ92KpS6xhp2XaDMsix7kG/u/h8PZ MaJqsr2r9SmtKo88dKksdl7UP4bjoaCrFVDv3k8+FDr4m7SZu2VAVR/TgY2EDxvBcc f4qELifpIIlJCRXNLJz0SzUnhQMG9XHj1mJFFSnY= Date: Wed, 7 Oct 2020 16:33:57 +0300 From: Laurent Pinchart To: Marek Vasut Subject: Re: [PATCH v2 1/7] dt-bindings: display: mxsfb: Convert binding to YAML Message-ID: <20201007133357.GJ3937@pendragon.ideasonboard.com> References: <20201007012438.27970-1-laurent.pinchart@ideasonboard.com> <20201007012438.27970-2-laurent.pinchart@ideasonboard.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: devicetree@vger.kernel.org, Guido =?utf-8?Q?G=C3=BCnther?= , Rob Herring , dri-devel@lists.freedesktop.org, Pengutronix Kernel Team , linux-arm-kernel@lists.infradead.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" Hi Marek, On Wed, Oct 07, 2020 at 10:55:24AM +0200, Marek Vasut wrote: > On 10/7/20 10:43 AM, Lucas Stach wrote: > > On Mi, 2020-10-07 at 10:32 +0200, Marek Vasut wrote: > >> On 10/7/20 3:24 AM, Laurent Pinchart wrote: > >> [...] > >>> +properties: > >>> + compatible: > >>> + enum: > >>> + - fsl,imx23-lcdif > >>> + - fsl,imx28-lcdif > >>> + - fsl,imx6sx-lcdif > >>> + - fsl,imx8mq-lcdif > >> > >> There is no fsl,imx8mq-lcdif in drivers/gpu/drm/mxsfb/mxsfb_drv.c, > >> so the DT must specify compatible = "fsl,imx8mq-lcdif", > >> "fsl,imx28-lcdif" (since imx28 is the oldest SoC with LCDIF V4). > >> > >> Should the compatible be added to drivers/gpu/drm/mxsfb/mxsfb_drv.c or > >> dropped from the YAML file or neither ? > > > > Neither. As far as we know the block is compatible, so the DT should > > claim that it's compatible to "fsl,imx28-lcdif". However we don't know > > if there are any surprises, so we add the SoC specific compatible to be > > able to change the driver matching later without changing the DT if the > > need arises. For the DT validation to pass the SoC specific compatible > > needs to be documented, even if it currently unused by the driver. > > What in that binding says you should specify compatible = > "fsl,imx8mq-lcdif", "fsl,imx28-lcdif"; and not e.g. "fsl,imx8mq-lcdif", > "fsl,imx23-lcdif" or simply "fsl,imx8mq-lcdif" ? Nothing, until the next patch :-) This patch only handles the YAML conversion but doesn't fix issues. -- Regards, Laurent Pinchart _______________________________________________ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel