Re: [RFC] Add BPF_PROG_TYPE_CGROUP_IOCTL

[kernel test robot <lkp@intel.com>]

[-- Attachment #1: Type: text/plain, Size: 2710 bytes --]

Hi Kenny,

[FYI, it's a private test report for your RFC patch.]
[auto build test WARNING on bpf-next/master]
[also build test WARNING on bpf/master ipvs/master linus/master v5.9-rc8 next-20201007]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch]

url:    https://github.com/0day-ci/linux/commits/Kenny-Ho/Add-BPF_PROG_TYPE_CGROUP_IOCTL/20201007-232535
base:   https://git.kernel.org/pub/scm/linux/kernel/git/bpf/bpf-next.git master
config: arm64-randconfig-r014-20201008 (attached as .config)
compiler: clang version 12.0.0 (https://github.com/llvm/llvm-project 4d1d8ae7100ec3c7e1709addb7b3ec6f9ad0b44f)
reproduce (this is a W=1 build):
        wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        # install arm64 cross compiling tool for clang build
        # apt-get install binutils-aarch64-linux-gnu
        # https://github.com/0day-ci/linux/commit/1846d5807418c25df81e9aa55e31dc21caf80366
        git remote add linux-review https://github.com/0day-ci/linux
        git fetch --no-tags linux-review Kenny-Ho/Add-BPF_PROG_TYPE_CGROUP_IOCTL/20201007-232535
        git checkout 1846d5807418c25df81e9aa55e31dc21caf80366
        # save the attached .config to linux build tree
        COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross ARCH=arm64 

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>

All warnings (new ones prefixed by >>):

>> kernel/bpf/cgroup.c:1211:11: warning: incompatible pointer to integer conversion initializing '__u64' (aka 'unsigned long long') with an expression of type 'struct file *' [-Wint-conversion]
                   .filp = filp,
                           ^~~~
   1 warning generated.

vim +1211 kernel/bpf/cgroup.c

  1205	
  1206	int __cgroup_bpf_check_ioctl_permission(struct file *filp, unsigned int cmd, unsigned long arg,
  1207					      enum bpf_attach_type type)
  1208	{
  1209		struct cgroup *cgrp;
  1210		struct bpf_cgroup_ioctl_ctx ctx = {
> 1211			.filp = filp,
  1212			.cmd = cmd,
  1213			.arg = arg,
  1214		};
  1215		int allow = 1;
  1216	
  1217		rcu_read_lock();
  1218		cgrp = task_dfl_cgroup(current);
  1219		allow = BPF_PROG_RUN_ARRAY(cgrp->bpf.effective[type], &ctx,
  1220					   BPF_PROG_RUN);
  1221		rcu_read_unlock();
  1222	
  1223		return !allow;
  1224	}
  1225	

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all(a)lists.01.org

[-- Attachment #2: config.gz --]
[-- Type: application/gzip, Size: 30162 bytes --]